Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
Patch Set 4:
(32 comments)
First set of comments focusing on the public interface.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 13:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/agg-fn-evaluator.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Add DECIMAL_V2 query option
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5889
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5840/1/be/src/exec/kudu-scanner.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5811/5//COMMIT_MSG
Commit Message:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 6: Code-Review+2
(8 comments)
Thanks, that's easier to follow. Just some more
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3785: Record query handle for invalid handle
..
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5748/5/tests/hs2/test_hs2.py
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 15: Code-Review+2
(4 comments)
Looks good to me but see if Marcel wants to take another pass.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 5:
(6 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4808: old hash join can reference invalid memory
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5850
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5732/4//COMMIT_MSG
Commit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 9:
What do you mean by "complicated" queries?
And how much did computing the StringSearch only once help? From your
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4809: Add Stability for codegen constants
..
Patch Set 1:
IMPALA-4809 isn't about inlining an expression related value, it's just that
the way the code is
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW"
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5802
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 18:
Alex, can you take a look at this? In particular, patchset 18 vs 17.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 16:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/exprs/string-functions-ir.cc
File
Hello Michael Ho, Zach Amsden,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5933
to look at the new patch set (#2).
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 3: Code-Review+2
(1 comment)
Carry Michael's +2.
Hello Michael Ho, Zach Amsden,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5933
to look at the new patch set (#3).
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 18: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/18/be/src/udf/udf.h
File be/src/udf/udf.h:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG
Commit Message:
PS1,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins
..
Patch Set 1: Code-Review+1
Seems okay to me.
Michael, are you okay with having this "none" mechanism?
--
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5941
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5940
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding when casting from decimal to int
..
Patch Set 2:
I'm not opposed to cleaning up the AnyVal stuff like that, but given that udf.h
stuff
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Add DECIMAL_V2 query option
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5889/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4810:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in
KuduScanNode
..
Patch Set 3:
(2 comments)
looks fine to me
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
..
Patch Set 6:
(3 comments)
AFAICT, IMPALA-1427 should have been resolved when we stopped printing the
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Make it easy to work with big numbers
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
..
Patch Set 7:
I thought the missing stats was a query warning, but it looks like it's not. I
agree it
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 8:
What's the next step on this one?
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet
files
..
Patch Set 9: Code-Review+2
(2 comments)
If you want to add the config values to the
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet
files
..
Patch Set 9:
One thing I'm a little concerned about, though, is that the user may not be
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 12:
(19 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 1:
Hi Zach, please add some regression tests for this. Take a look at exprs.test
& test_exprs.py for examples of
Dan Hecht has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 4:
(1 comment)
> (4 comments)
>
> Just a few minor things from my point of
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet
files
..
Patch Set 9:
> (1 comment)
>
> > (2 comments)
> >
> > If you want to add the config
Dan Hecht has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 4:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet
files
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5400
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 6:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 4:
> Quite a bit longer. 5~6 mins in debug builds on my machine. I think
>
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 4:
(4 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent
paths.
..
Patch Set 5:
No
--
To view, visit http://gerrit.cloudera.org:8080/5743
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 4:
(20 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5788
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3785: Record query handle for invalid handle
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5748/4/be/src/service/impala-beeswax-server.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 12:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 3:
Hmm, after posting that comment, patch set 3 showed up for me... as a
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 2:
I got an email about patch set 3, but I don't see patch sets 1 & 2.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 16: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 3:
(7 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet
files
..
Patch Set 10: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent
paths.
..
Patch Set 1:
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 13:
(10 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/17/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 18:
(4 comments)
Does this change solve the DCHECK you were hitting running expr-test?
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
..
Patch Set 2:
since you folded this in to the other change, please abandon this change so
people don't
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4282: Remove max length check for type strings.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6034/2//COMMIT_MSG
Commit Message:
Line 12:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 21: Code-Review+2
(2 comments)
Michael, can you take a final pass as well?
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4981: Re-enable spilling with MT_DOP.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6131
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 23: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5951
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014
..
Patch Set 6:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4813: Round on divide and multiply
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4813: Round on divide and multiply
..
Patch Set 2:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4813: Round on divide and multiply
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6132/2//COMMIT_MSG
Commit Message:
Line 44: |
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4877: fix precedence of unary -/+
..
Patch Set 4: Code-Review+2
Carry Marcel's +2.
--
To view, visit http://gerrit.cloudera.org:8080/6044
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4813: Round on divide and multiply
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc
File
Dan Hecht has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6151
Change subject: IMPALA-4990: fix run_tests.py --update_results
..
IMPALA-4990: fix run_tests.py --update_results
Seems to have broken with
Dan Hecht has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6150
Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests
..
IMPALA-4810: add DECIMAL test case to strict_mode tests
The
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 21:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/19/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 22: Code-Review+2
Michael, any more comments?
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG
Commit Message:
Line 122: do to
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6038/4//COMMIT_MSG
Commit Message:
PS4, Line 25: types
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6038
To unsubscribe, visit
Hello Marcel Kornacker, Michael Ho, Zach Amsden,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5952
to look at the new patch set (#14).
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
..
Patch Set 2:
> Uploaded patch set 2.
buffer-block-mgr-test needed an update due to the error message text
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding when casting from decimal to int
..
Patch Set 3:
> > I'm not opposed to cleaning up the AnyVal stuff like that, but
> > given that udf.h
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5940
to look at the new patch set (#2).
Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Patch Set 1:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5989/1//COMMIT_MSG
Commit Message:
Hello Michael Ho, Zach Amsden,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5952
to look at the new patch set (#13).
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
Dan Hecht has uploaded a new patch set (#2).
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
IMPALA-4810: fix incorrect expr-test decimal types
Many of the types for the decimal round/truncate and related
Dan Hecht has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 23: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5161
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5950/1/be/src/exec/partitioned-aggregation-node.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 21:
Is that just a rebase? Any fixes needed for the last failing run?
--
To view, visit
Dan Hecht has uploaded a new patch set (#6).
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
..
IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Implement the new DECIMAL
Dan Hecht has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5959
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
IMPALA-4810: fix incorrect expr-test decimal types
Many of the types
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 2: Code-Review+2
(2 comments)
Please take a look at whether it makes sense to add coverage in
Dan Hecht has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5967
Change subject: Fix merge conflict
..
Fix merge conflict
Commits fcc2d81 and 1335af3 conflicted.
Change-Id:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 1:
We also have test_decimal_casting.py. I haven't looked at it in detail but
maybe there's
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding when casting from decimal to int
..
Patch Set 3:
(2 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc
File
Dan Hecht has uploaded a new patch set (#7).
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
..
IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Implement the new DECIMAL
1 - 100 of 1021 matches
Mail list logo
