Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 2:
(16 comments)
Nice! I think this counter may be useful more generally, though I think we
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4371/2/tests/query_test/test_scanners.py
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4111: backend death tests should not produce minidumps
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4353/2/be/src/testutil/death-test
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4111: backend death tests should not produce minidumps
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4353/2/be/src/testutil/death-test
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4111: backend death tests should not produce minidumps
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4353/2/be/src/testutil/death-test
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4371/3/be/src/exec/hdfs-parquet-scanner
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
Patch Set 1:
(8 comments)
Thanks for the feedback.
My thought with xfail was that I wanted them to
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3973: add position and occurrence to instr()
..
Patch Set 17: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4094
To unsubscribe, visit
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-3973: add position and occurrence to instr()
..
IMPALA-3973: add position and occurrence to instr()
Change-Id: Ie9648de458d243306fa14adc5e7f7002
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3973: add position and occurrence to instr()
..
Patch Set 18:
I carried the +2 and pushed to asf. Thanks, Zoltan.
--
To view, visit http://gerrit.cloud
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
IMPALA-3718: Support subset of functional-query for Kudu
Adds initial support for the functional-query
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
Patch Set 2:
> (8 comments)
>
> Thanks for the feedback.
>
> My thought with xfail was that I
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
Patch Set 4: Code-Review+2
Fixed the commit msg, carrying the +2
--
To view, visit http://gerrit.c
Hello Michael Brown, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4175
to look at the new patch set (#4).
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
Hello Michael Brown, Internal Jenkins, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4175
to look at the new patch set (#5).
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3718: Support subset of functional-query for Kudu
..
Patch Set 5: Code-Review+2
planner test output had output from before a recent kudu client change so
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 4:
(15 comments)
I was hoping to get to +1 this pass but there's a bit more still...
Most
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 1:
(28 comments)
Ok, here's a bit to get started. Just made my way through most of
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4420
Change subject: Bump Kudu version to 1.0-RC1
..
Bump Kudu version to 1.0-RC1
Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da
---
M
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4420
to look at the new patch set (#2).
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4371
To unsubscribe, vis
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4371/4/be/src/util/runtime-profile-coun
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4426
Change subject: IMPALA-4136: testKudu planner test hangs if Kudu is not
supported
..
IMPALA-4136: testKudu planner test hangs if Kudu i
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4111: backend death tests should not produce minidumps
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4353
To unsubscri
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4420/2/bin/impala-config.sh
File bin/
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4420
to look at the new patch set (#3).
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4420/3/bin/impala-config.sh
File bin/
Hello Internal Jenkins, Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4420
to look at the new patch set (#4).
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes
..
Patch Set 4: Code-Review+2
Carrying the +2-- was missing changes to the config files for running ku
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 1:
(17 comments)
another batch of comments, still a lot of files i haven't touched
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 1:
(31 comments)
Ok, part 3. I have one more batch left...
http://gerrit.cloudera.
Matthew Jacobs has posted comments on this change.
Change subject: Remove Llama support.
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/request-pool-service.cc
File be/src/scheduling/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscr
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 2:
After discussing with Dan on the Kudu team, we can make this simpler by
checkin
Matthew Jacobs has uploaded a new patch set (#4).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Creating a table in Impala, cha
Matthew Jacobs has uploaded a new patch set (#5).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Creating a table in Impala, cha
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to latest Kudu master
..
Patch Set 2: Code-Review+2
prev build failed due to IMPALA-3040.
rebasing
--
To view, visit http://gerrit.cloudera
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
..
Patch Set 1:
(1 comment)
Nice! I think it looks good, just a comment about some additional test cases a
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5840
to look at the new patch set (#6).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5840/5//COMMIT_MSG
Commit Messa
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 6: Code-Review+1
carrying Sailesh's +1
--
To view, visit http://gerrit.cloudera.o
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5970
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Revert "IMPALA-4829: Change default Kudu read beha
Matthew Jacobs has posted comments on this change.
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5970/1/be/src/exec/kudu-scan
Matthew Jacobs has posted comments on this change.
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5970/1/be/src/exec/kudu-scan
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""
Reverting until we have a
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscr
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscr
Matthew Jacobs has posted comments on this change.
Change subject: Make sure impala doesn't pickup the system's boost cmake module
..
Patch Set 1:
Seems reasonable to me too, thanks for the fix. Just curious, where did you
fin
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6006
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
..
IMPALA-4931: Update squeasel to include patch to d
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
..
Patch Set 1:
> I'm not too clear on how this CMAKE option would get affected
> because of
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
..
Patch Set 1:
> > I'm not too clear on how this CMAKE option would get affected
> > becaus
Matthew Jacobs has posted comments on this change.
Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for
"RYW""
..
Patch Set 3: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/5970
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6006
to look at the new patch set (#2).
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
..
Patch Set 2: Code-Review+2
removed the old cmake line and rebased
--
To view, visit http
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kudu-scanne
Hello Thomas Tauber-Marshall, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5840
to look at the new patch set (#7).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6021
Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
..
IMPALA-4937: Remove unused kudu scanner keep alive variab
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6027
Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup
..
IMPALA-4933: Force thrift to initialize SSL on process
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4933: Force thrift to initialize SSL on process startup
..
Patch Set 1:
Running jenkins job now, will also deploy to a secure cluster for additional
tes
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 1:
I'll do a CR later tonight or tmr morning.
--
To view, visit http://gerrit.cloudera.org:8080/
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup
..
IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup
OpenSSL initialization functi
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-4931: Update squeasel to include patch to disable SSL
init
..
Abandoned
merged with https://gerrit.cloudera.org/#/c/6027/
--
To view, visit http://gerrit.cloud
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup
..
Patch Set 2:
private job succeeded
--
To view, visit http://gerrit.cloudera.org:8080/6027
Matthew Jacobs has posted comments on this change.
Change subject: [DOCS] Major update to Impala + Kudu page
..
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5649
To unsubscribe, visit http://ge
Matthew Jacobs has posted comments on this change.
Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables
..
Patch Set 1:
(6 comments)
just some high level comments for now since this is WIP.
would you mind
Hello Thomas Tauber-Marshall, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5840
to look at the new patch set (#8).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5840/7/tests/query_test/test_k
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4933, IMPALA-4931: Simplify SSL initialization on startup
..
Patch Set 2: Code-Review+2
Assuming that Henry's comment implied a +2 after Sailesh reviewed
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 2:
(17 comments)
this probably needs some new test cases, especially cases where there are
multi
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6046
Change subject: Bump Kudu java version to 1.3
..
Bump Kudu java version to 1.3
Change-Id: Ia0dde8afe096c852a202cf0e331b4e179080e0ad
---
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6056
Change subject: IMPALA-4934: Disable Kudu initialization
..
IMPALA-4934: Disable Kudu initialization
Bumps the Kudu version to include
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
IMPALA-4934: Disable Kudu OpenSSL initialization
Bumps the Kudu version to include the change to the client
th
Matthew Jacobs has uploaded a new patch set (#3).
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
IMPALA-4934: Disable Kudu OpenSSL initialization
Bumps the Kudu version to include the change to the client
th
Matthew Jacobs has abandoned this change.
Change subject: Bump Kudu java version to 1.3
..
Abandoned
merged into another change
--
To view, visit http://gerrit.cloudera.org:8080/6046
To unsubscribe, visit http://gerrit.cloude
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
..
Patch Set 9: Code-Review+2
fixed spelling and carry +2
--
To view, visit http://gerrit.clou
Hello Thomas Tauber-Marshall, Sailesh Mukil, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5840
to look at the new patch set (#9).
Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read
.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6056/3/be/src/rpc/authentication.cc
File be/s
Matthew Jacobs has uploaded a new patch set (#4).
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
IMPALA-4934: Disable Kudu OpenSSL initialization
Bumps the Kudu version to include the change to the client
th
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6025/2/be/src/exprs/aggregate-functions-ir.cc
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 4:
python tests don't handle this yet, need to wait for a patch from kudu that
avoids DFATAL logg
Matthew Jacobs has posted comments on this change.
Change subject: Avoid including Boost cmake support from system path
..
Patch Set 1:
Hm David posted this as well but it looks like we never got it in. I'm guessing
he's busy
Matthew Jacobs has posted comments on this change.
Change subject: Avoid including Boost cmake support from system path
..
Patch Set 1:
David's review https://gerrit.cloudera.org/#/c/5994/2
--
To view, visit http://gerrit.clo
Matthew Jacobs has posted comments on this change.
Change subject: kudu: fix uninitialized variable usage warning
..
Patch Set 1:
might we be seeing this in practice on any real clusters? If so, it should have
a JIRA so we can
Matthew Jacobs has posted comments on this change.
Change subject: build: don't look in system paths for kudu client
..
Patch Set 1: Code-Review+2
assuming this passes real builds
--
To view, visit http://gerrit.cloudera.org:
Matthew Jacobs has posted comments on this change.
Change subject: kudu: fix uninitialized variable usage warning
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6098
To unsubscribe, visit http:
Hello Impala Public Jenkins, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6056
to look at the new patch set (#5).
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
...
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 5: Code-Review+2
had to bump the client version one more time to get another change in Kudu
--
T
Matthew Jacobs has posted comments on this change.
Change subject: build: don't look in system paths for kudu client
..
Patch Set 1:
I submit it, it doesn't get kicked off automatically
--
To view, visit http://gerrit.clouder
Matthew Jacobs has posted comments on this change.
Change subject: Make sure impala doesn't pickup the system's boost cmake module
..
Patch Set 2:
I filed https://issues.cloudera.org/browse/IMPALA-4959
Please just add that to
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/6025/2/be/src/exprs/aggregate-functions-ir.cc
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 6:
(3 comments)
I'm still not convinced the new paths are necessarily, e.g. the case I
mentioned
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module
..
Patch Set 3: Code-Review+2
ah, i forgot you could steal someone's CR by just posting w/ the sam
Hello Impala Public Jenkins, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6056
to look at the new patch set (#6).
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
...
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4934: Disable Kudu OpenSSL initialization
..
Patch Set 6: Code-Review+2
fixed a python test that failed, I had missed it locally because my local
didn't
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6025/6/be/src/exprs/aggregate-functions-ir.cc
Matthew Jacobs has posted comments on this change.
Change subject: Three misc webpage changes
..
Patch Set 1: Code-Review+1
seems fine but I don't really know jquery
--
To view, visit http://gerrit.cloudera.org:8080/6045
To u
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage
..
Patch Set 8: Code-Review+1
(2 comments)
Thanks! Let's see if Alex has any more comments.
http://gerrit.clo
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module
..
Patch Set 3:
yup thanks for pinging about that, I just submitted it for gvm
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: Three misc webpage changes
..
Patch Set 1: Code-Review+2
> Thanks for the reviews!
>
> > seems fine but I don't really know jquery
>
> If it makes it easi
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4987: Skip test_rows_availability when testing over a
network.
..
Patch Set 1: Code-Review+1
(1 comment)
seems like a flaky test in general...
http://
1 - 100 of 1218 matches
Mail list logo
