[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2033 (part 2). Add test for Java client failover support.

2017-08-18 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7722 Change subject: KUDU-2033 (part 2). Add test for Java client failover support. .. KUDU-2033 (part 2). Add test for Java client failover

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7687 to look at the new patch set (#5). Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-18 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7692 to look at the new patch set (#5). Change subject: KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7707 to look at the new patch set (#4). Change subject: KUDU-2101 Include a table summary at the bottom .. KUDU-2101

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7707/2/src/kudu/tools/ksck.cc File

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7707 to look at the new patch set (#3). Change subject: KUDU-2101 Include a table summary at the bottom .. KUDU-2101

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7707/2/src/kudu/tools/ksck.cc File

[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools

2017-08-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#2). Change subject: [java] Include Spark/Scala base version in kudu-spark-tools .. [java] Include Spark/Scala base version in kudu-spark-tools Renames the kudu-spark-tools artifact to

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7699 To unsubscribe, visit

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7707 To unsubscribe, visit

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 5: Code-Review+1 (4 comments)

[kudu-CR] [java] Include spark/scala base version in spark-tools

2017-08-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7723 Change subject: [java] Include spark/scala base version in spark-tools .. [java] Include spark/scala base version in spark-tools Renames

[kudu-CR] security: only lookup hostname if HOST substitution is required

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: security: only lookup hostname if _HOST substitution is required .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7694 To

[kudu-CR] security: only lookup hostname if HOST substitution is required

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: security: only lookup hostname if _HOST substitution is required .. security: only lookup hostname if _HOST substitution is required The Kerberos

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7687 To

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 4: Wondering... should we had a flag to disable the summary at the end? Maybe a way to have a

[kudu-CR] [java] Upgrade to Spark 2.2.0

2017-08-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7720 Change subject: [java] Upgrade to Spark 2.2.0 .. [java] Upgrade to Spark 2.2.0 Upgrades to Spark 2.2.0 and documents the Java 8 runtime

[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Include Spark/Scala base version in kudu-spark-tools .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7723 To unsubscribe,

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7699 To unsubscribe, visit

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2104. Upgrade to Spark 2.2.0 .. Patch Set 2: I guess that begs the question: are we still compatible with Spark 2.0 and 2.1? I think we are at this point,

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-18 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7718 to look at the new patch set (#3). Change subject: consensus: Tablet copy should clear last-logged opid from superblock

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

2017-08-18 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7720 to look at the new patch set (#2). Change subject: KUDU-2104. Upgrade to Spark 2.2.0 .. KUDU-2104. Upgrade to

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7692 To unsubscribe,

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7707/3/src/kudu/tools/ksck.cc File

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Deprecate Java 7 and Spark 1 .. [docs] Deprecate Java 7 and Spark 1 Starts the release notes for Kudu 1.5.0 and adds entries for Java 7 and

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7718/2//COMMIT_MSG Commit

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

2017-08-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-2104. Upgrade to Spark 2.2.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc File docs/developing.adoc: Line

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2104. Upgrade to Spark 2.2.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc File docs/developing.adoc: Line

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Deprecate Java 7 and Spark 1 .. Patch Set 3: Code-Review+2 Wanted to give you a change to weigh in on the fixes. But if you insist SHIP IT! -- To view,

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7693 To

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. KUDU-1942. Kerberos fails to log in on hostnames with capital letters This

[kudu-CR] KUDU-2104. Upgrade to Spark 2.2.0

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2104. Upgrade to Spark 2.2.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7720/2/docs/developing.adoc File docs/developing.adoc: Line

[kudu-CR] [java] Fix gradle wrapper with 4.1

2017-08-18 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7726 Change subject: [java] Fix gradle wrapper with 4.1 .. [java] Fix gradle wrapper with 4.1 Gradle doesn’t use trailing zeros with new minor

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 12: Code-Review-1 (1 comment) I'm a little suspicious of the build failure; I'm currently running a dist-test to

[kudu-CR] [java] Fix gradle wrapper with 4.1

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [java] Fix gradle wrapper with 4.1 .. [java] Fix gradle wrapper with 4.1 Gradle doesn’t use trailing zeros with new minor versions which broke the

[kudu-CR] [java] Fix gradle wrapper with 4.1

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] Fix gradle wrapper with 4.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7726 To unsubscribe, visit

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 5: (1 comment)

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7718/3//COMMIT_MSG Commit

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-18 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7717 to look at the new patch set (#3). Change subject: consensus: Improve contract for API to fetch last-logged op id

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#14). Change subject: KUDU-1407: reassign failed tablets ..

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#9). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 1: (1 comment)

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 1: It's interesting to compare this approach with the one I originally went with (consolidating

[kudu-CR] [iwyu] first pass

2017-08-18 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#19). Change subject: [iwyu] first pass .. [iwyu] first pass Updated C++ source

[kudu-CR] [iwyu] first pass

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] first pass .. Patch Set 18: (41 comments) Thank you for the thorough review!

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 4: I think a flag for machine-parseable (eg json) output would be nice if we have a need to parse

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#18). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] KUDU-1489: move tablet metadata

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7617 to look at the new patch set (#3). Change subject: KUDU-1489: move tablet metadata .. KUDU-1489: move tablet

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#19). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/7270/18/src/kudu/fs/data_dirs.cc File

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7735 to review the following change. Change subject: consensus: use periodic timers for failure detection

[kudu-CR] rpc: periodic timers

2017-08-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7733 to review the following change. Change subject: rpc: periodic timers .. rpc:

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7734 to review the following change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers

[kudu-CR] util: remove old failure detector and resettable heartbeater code

2017-08-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7736 to review the following change. Change subject: util: remove old failure detector and resettable heartbeater code

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#17). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 12: (1 comment) Feel free to ignore my feedback if you weren't going to generate a new patch since it's minor.

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states .. Patch Set 15: (30 comments) http://gerrit.cloudera.org:8080/#/c/7270/15//COMMIT_MSG Commit Message: Line 11: failed

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7440/12/src/kudu/tserver/ts_tablet_manager.cc File

[kudu-CR] disk failure: add persistent disk states

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#16). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] [iwyu] first pass

2017-08-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [iwyu] first pass .. Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/4738/19/src/kudu/client/shared_ptr.h File src/kudu/client/shared_ptr.h: Line

[kudu-CR] [iwyu] first pass

2017-08-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] first pass .. Patch Set 18: (3 comments) > Other than the 1 nit in sp::shared_ptr, this looks good to me Great -- thank you for reviewing this

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-18 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7735 to look at the new patch set (#2). Change subject: consensus: use periodic timers for failure detection ..

[kudu-CR] rpc: periodic timers

2017-08-18 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7733 to look at the new patch set (#2). Change subject: rpc: periodic timers .. rpc: periodic timers This patch

[kudu-CR] rpc: periodic timers

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7733/1/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc:

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7735/1/src/kudu/consensus/raft_consensus.cc

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 1: I looped raft_consensus-itest in slow mode 1000 times both with and without this patch.

[kudu-CR] KUDU-1489: move tablet metadata

2017-08-18 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7617 to look at the new patch set (#4). Change subject: KUDU-1489: move tablet metadata .. KUDU-1489: move tablet

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#13). Change subject: KUDU-1407: reassign failed tablets ..

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 13: (1 comment) @dralves Opted out of doing the enums thing we discussed offline. I think there are few enough

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#8). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7717 to look at the new patch set (#2). Change subject: consensus: Improve contract for API to fetch last-logged op id

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 1: (15 comments)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/7/src/kudu/tserver/tablet_service.cc File

[kudu-CR] KUDU-2089: Failed java tests can orphan test-tmp files

2017-08-18 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/7719 Change subject: KUDU-2089: Failed java tests can orphan test-tmp files .. KUDU-2089: Failed java tests can orphan test-tmp files This changes

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7707/1/src/kudu/tools/ksck.cc File

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2017-08-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 2: Todd, is it possible to rewrite this patch without the change to request

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2017-08-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 2: sure, will do. -- To view, visit http://gerrit.cloudera.org:8080/7362 To

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7699 to look at the new patch set (#2). Change subject: [docs] Deprecate Java 7 and Spark 1 .. [docs]

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7707 to look at the new patch set (#2). Change subject: KUDU-2101 Include a table summary at the bottom .. KUDU-2101

[kudu-CR] KUDU-2101 Include a table summary at the bottom

2017-08-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2101 Include a table summary at the bottom .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7707/1/src/kudu/tools/ksck.cc File

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-18 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7699 to look at the new patch set (#3). Change subject: [docs] Deprecate Java 7 and Spark 1 .. [docs]