[kudu-CR] [metrics] Remove incorrect comments

Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12921 to look at the new patch set (#2). Change subject: [metrics] Remove incorrect comments .. [metrics]

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. [kudu-tool-test] deflake

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+1 I don't have the ability to test this since I

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. Patch Set 1: (3 comments)

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [metrics] Remove incorrect comments

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. [metrics] Remove incorrect comments Data store in std::map with key type

[kudu-CR] [metrics] Remove incorrect comments

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12932 to look at the new patch set (#2). Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable

[kudu-CR] [metrics] Remove incorrect comments

Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 1: (2 comments)

[kudu-CR] sentry: generate table privileges

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12941 Change subject: sentry: generate table privileges .. sentry: generate table privileges This patch adds token generation to the authz

[kudu-CR] wip sentry: generate authz tokens

Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12897 ) Change subject: wip sentry: generate authz tokens .. Abandoned This is split into multiple other patches. -- To view, visit

[kudu-CR] [build] Fix building codegen on MacOS Mojave

Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix building codegen on MacOS Mojave .. [build] Fix building codegen on MacOS Mojave When

[kudu-CR] [build] Fix building codegen on MacOS Mojave

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix building codegen on MacOS Mojave .. Patch Set 2: Verified+1 Code-Review+2 (1 comment) > Patch Set 1:

[kudu-CR] sentry: generate table privileges

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#2). Change subject: sentry: generate table privileges .. sentry: generate table

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: > Patch Set 1: Code-Review+1 > > I don't have the ability

[kudu-CR] [build] Fix bulding codegen on MacOS Mojave

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+2 (1 comment) Fix the one misspelling and

[kudu-CR] [build] Fix building codegen on MacOS Mojave

Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12936 to look at the new patch set (#2). Change subject: [build] Fix building codegen on MacOS Mojave

[kudu-CR] row operations: suppress a gcc warning

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12943 to review the following change. Change subject: row_operations: suppress a gcc warning ..

[kudu-CR] remove schema copies from RowBlock and RowBuilder

Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12907 to look at the new patch set (#5). Change subject: remove schema copies from RowBlock and RowBuilder

[kudu-CR] tool: perf tablet scan action

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12945 to review the following change. Change subject: tool: perf tablet_scan action .. tool: perf tablet_scan

[kudu-CR] generic iterators: implement three-heap merge algorithm

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12947 to review the following change. Change subject: generic_iterators: implement three-heap merge algorithm

[kudu-CR] sentry: sanitize and parse privileges from Sentry

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: > (14 comments) > > Sorry I'm late to the party;

[kudu-CR] authz: add interface for generating authz tokens

Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12896 ) Change subject: authz: add interface for generating authz tokens .. Abandoned This is being done in another patch. -- To view, visit

[kudu-CR] authz: authorize ListTablets

Hello Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11752 to look at the new patch set (#2). Change subject: authz: authorize ListTablets .. authz:

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

raym...@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12949 Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. KUDU-2689: Made PartialRow setters use a fluent-style.

[kudu-CR] tool: perf tablet scan action

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 1: (1 comment)

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

Hello Tidy Bot, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#9). Change subject: WIP [master] introduced SentryPrivilegesFetcher

[kudu-CR] generic iterators: pass rowset bounds into grouping iterators

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12946 to review the following change. Change subject: generic_iterators: pass rowset bounds into grouping iterators

[kudu-CR] generic iterators: basic MergeIterator dominance

Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Abandoned This has been superceded by https://gerrit.cloudera.org/c/12947/ --

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12944 to review the following change. Change subject: generic_iterators: switch MergeIterator to intrusive list of states

[kudu-CR] WIP [HaClient] introduce client metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: WIP [HaClient] introduce client metrics .. Patch Set 1: Verified+1 unrelated flakes in:

[kudu-CR] WIP [HaClient] introduce client metrics

Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: WIP [HaClient] introduce client metrics .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] WIP [HaClient] introduce client metrics

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12951 Change subject: WIP [HaClient] introduce client metrics .. WIP [HaClient] introduce client metrics Introduced metrics for Sentry

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: Is this ABI-compatible? (do we have a documented