[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2806 to look at the new patch set (#12). Change subject: KUDU-1307 [master] support tables with range partition bounds

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 11: (1 comment)

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 1: actually it's missing tests for a few of the guarantees, I'll add specific tests for those.

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2806 To

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3240 To unsubscribe, visit

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1307 [master] support tables with range partition bounds .. KUDU-1307 [master] support tables with range partition bounds This commit adds support

[kudu-CR] KUDU-1385 Part 1: Modify documentation landing page

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2675 to look at the new patch set (#4). Change subject: KUDU-1385 Part 1: Modify documentation landing page ..

[kudu-CR] Don't use InMemoryEnv in deltafile-test

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Don't use InMemoryEnv in deltafile-test .. Don't use InMemoryEnv in deltafile-test Get out the vote: #NeverMemEnv. This is causing problems due to

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG Commit Message:

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 8: Hi Bruce, This issue looks like a bug in Boost versions 1.56 and 1.57:

[kudu-CR] Kudu 0.9.0 release notes edit

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3176 to look at the new patch set (#5). Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit

[kudu-CR] Kudu 0.9.0 release notes edit

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has posted comments on this change. Change subject: Kudu 0.9.0 release notes edit .. Patch Set 5: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3176 To unsubscribe, visit

[kudu-CR] Kudu 0.9.0 release notes edit

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has submitted this change and it was merged. Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit Change-Id: I6242089b099a7e220ce4094f3ba0377859338b97 Reviewed-on:

[kudu-CR](branch-0.9.x) Kudu 0.9.0 release notes edit

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has uploaded a new change for review. http://gerrit.cloudera.org:8080/3251 Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit Change-Id:

[kudu-CR](branch-0.9.x) Kudu 0.9.0 release notes edit

2016-05-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit Change-Id: I6242089b099a7e220ce4094f3ba0377859338b97 Reviewed-on:

[kudu-CR](branch-0.9.x) Kudu 0.9.0 release notes edit

2016-05-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Kudu 0.9.0 release notes edit .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3251 To unsubscribe, visit

[kudu-CR] Document advice about max columns and record size

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has submitted this change and it was merged. Change subject: Document advice about max columns and record size .. Document advice about max columns and record size Change-Id:

[kudu-CR](branch-0.9.x) Document advice about max columns and record size

2016-05-31 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has uploaded a new change for review. http://gerrit.cloudera.org:8080/3252 Change subject: Document advice about max columns and record size .. Document advice about max columns and record size Change-Id:

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark .. Patch Set 3: LGTM with the caveat of updating the comment per Todd's suggestion.  I think it's worth rushing this

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Dan Burkert (Code Review)
Hello Internal Jenkins, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1868 to look at the new patch set (#13). Change subject: Replace uses of boost::thread with std::thread

[kudu-CR] Fix license issues

2016-05-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3254 Change subject: Fix license issues .. Fix license issues Change-Id: Id23c13f3bb0b5f2b8dd21af5decf061c9ee825a4 --- M

[kudu-CR] Fix license issues

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix license issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3254 To unsubscribe, visit

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Dan Burkert (Code Review)
Hello Internal Jenkins, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1868 to look at the new patch set (#14). Change subject: Replace uses of boost::thread with std::thread

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3255 to review the following change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread song bruce zhang (Code Review)
song bruce zhang has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 9: > Hi Bruce, > > This issue looks like a bug in Boost versions 1.56 and 1.57: >

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove last two usages of MemEnv in tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3257 To unsubscribe, visit

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3258 to look at the new patch set (#2). Change subject: Remove InMemoryEnv completely .. Remove InMemoryEnv completely

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: Ah, should've used git grep. -- To view, visit http://gerrit.cloudera.org:8080/3258 To unsubscribe, visit

[kudu-CR](branch-0.9.x) Make 0.9.0 not SNAPSHOT for release

2016-05-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Make 0.9.0 not SNAPSHOT for release .. Make 0.9.0 not SNAPSHOT for release Change-Id: I912336be4cce91f8708673b32e6f18ff0022f0cf --- M

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: > There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base > that I could find. I found a

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#2). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: I think memenv would have been useful had we ever used it in non-trivial tests (i.e. tests that perform real I/O).

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread song bruce zhang (Code Review)
song bruce zhang has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/3233/8//COMMIT_MSG Commit

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Replace uses of boost::thread with std::thread .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1868 To unsubscribe, visit

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3258 To unsubscribe, visit

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (15 comments) I reviewed everything but the change to

[kudu-CR] Fix license issues

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Fix license issues .. Fix license issues Change-Id: Id23c13f3bb0b5f2b8dd21af5decf061c9ee825a4 Reviewed-on: http://gerrit.cloudera.org:8080/3254

[kudu-CR] Fix license issues

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix license issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3254 To unsubscribe, visit

[kudu-CR] KUDU-1262. Fix WritableFile::PreAllocate() on MemEnv

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: KUDU-1262. Fix WritableFile::PreAllocate() on MemEnv .. Abandoned MemEnv has been removed -- To view, visit http://gerrit.cloudera.org:8080/1439 To unsubscribe, visit

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3257 to review the following change. Change subject: Remove last two usages of MemEnv in tests .. Remove last two usages of

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3258 to review the following change. Change subject: Remove InMemoryEnv completely .. Remove InMemoryEnv completely Every

[kudu-CR] Remove InMemoryEnv completely

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove InMemoryEnv completely .. Patch Set 1: There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base that I could find. For the

[kudu-CR] Remove last two usages of MemEnv in tests

2016-05-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Remove last two usages of MemEnv in tests .. Remove last two usages of MemEnv in tests TestEnv.TestReadFully still only takes about 6ms to execute.

[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1470 Exceptions on getting a column value should return the column name not the column number .. Patch Set 3: Code-Review+2 Looks good, I'm retrying the