[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT

2016-06-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3363 Change subject: Hotfix the 0.9.0 release notes to add UPSERT .. Hotfix the 0.9.0 release notes to add UPSERT Change-Id:

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: (1 comment) can you add a test for this? something simple like setting the

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Patch Set 2: where is this used? -- To view, visit http://gerrit.cloudera.org:8080/3345 To unsubscribe,

[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT

2016-06-10 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has posted comments on this change. Change subject: Hotfix the 0.9.0 release notes to add UPSERT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3363 To unsubscribe, visit

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Patch Set 2: It's used in the following patch. Maybe I should just squash it. -- To view, visit

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: > (1 comment) > > can you add a test for this? something simple like setting the >

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: general wondering. Should we just kill the consensus.h interface and refactor

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3360 to look at the new patch set (#2). Change subject: Do not run (g)addr2line translator on MacOS X .. Do

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3340 To unsubscribe, visit

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed some weird things going on after fixing

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: yeah was not saying that we needed to do it here. Not sure there is much to discuss though,

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+2 Ran the tests in my mac. When running on ctest all tests that injected

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: Code-Review+1 Thanks for making those changes. Looks good to me, though ultimately I'll defer to

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 1: (2 comments) > (2 comments) > > My understanding is that sanitizer-enabled Kudu builds on Mac

[kudu-CR] Do not run (g)addr2line translator on MacOS X

2016-06-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X .. Patch Set 2: > Thanks for making those changes. Looks good to me, though > ultimately I'll defer to someone

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#4). Change subject: Remove the LocalConsensus implementation .. Remove the LocalConsensus implementation This implementation was intended as scaffolding while we built a true consensus

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1813/ -- To view, visit

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/1814/ -- To view, visit

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: RaftConsensus: Trigger election at startup if single node .. RaftConsensus: Trigger election at startup if single node If a tablet's replication factor is 1 then

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1812/ -- To view, visit

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Use RaftConsensus instead of LocalConsensus in tests This paves the way to remove the LocalConsensus

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/1815/ -- To view, visit

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/1816/ -- To view, visit

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1817/ -- To view, visit

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Abandoned Squashing this into the following commit. -- To view, visit http://gerrit.cloudera.org:8080/3345 To unsubscribe,

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 2: (1 comment)

[kudu-CR] Remove the LocalConsensus implementation

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 3: OK, still let's do it a bit later. -- To view, visit http://gerrit.cloudera.org:8080/3350 To

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#4). Change subject: RaftConsensus: Trigger election at startup if single node .. RaftConsensus: Trigger election at startup if single node If a tablet's replication factor is 1 then

[kudu-CR] Fix variable name typo in ITBLL

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix variable name typo in ITBLL .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1819/ -- To view, visit

[kudu-CR] create-demo-table must specify parition columns

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: create-demo-table must specify parition columns .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3368/1//COMMIT_MSG Commit Message: PS1, Line 7:

[kudu-CR] create-demo-table must specify partition columns

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: create-demo-table must specify partition columns .. create-demo-table must specify partition columns This is a recent API change that didn't make it into this dev

[kudu-CR] create-demo-table must specify partition columns

2016-06-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: create-demo-table must specify partition columns .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1821/ -- To view, visit

[kudu-CR] create-demo-table must specify partition columns

2016-06-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: create-demo-table must specify partition columns .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3368 To unsubscribe, visit

[kudu-CR] Fix variable name typo in ITBLL

2016-06-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3367 Change subject: Fix variable name typo in ITBLL .. Fix variable name typo in ITBLL Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release Change-Id: I70b4be74e350232110e580844d4f71e012fa813f Reviewed-on:

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for 0.9.0 release .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3357/2/_posts/2016-06-10-apache-kudu-0-9-0-released.md File

[kudu-CR](gh-pages) Blog post for 0.9.0 release

2016-06-10 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3357 to look at the new patch set (#3). Change subject: Blog post for 0.9.0 release .. Blog post for 0.9.0 release

[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs

2016-06-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 0.9.0 release and refresh docs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3355 To unsubscribe, visit