---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/#review84884
---
Where will this get re-used?
src/tests/port_mapping_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review84882
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34432/#review84885
---
src/slave/containerizer/isolators/network/port_mapping.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84881
---
bunch of grammatical stuff, much of it not actually yours but might
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review84893
---
src/master/allocator/mesos/hierarchical.hpp
On May 18, 2015, 4:38 p.m., Chi Zhang wrote:
src/slave/containerizer/provisioners/appc/store.hpp, line 116
https://reviews.apache.org/r/34140/diff/1/?file=957276#file957276line116
Looks like this is a global store for all images. Would it make sense
to make sure at most one
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34616/
---
Review request for mesos, Jie Yu and Niklas Nielsen.
Bugs: MESOS-2734
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34268/#review84974
---
Patch looks great!
Reviews applied: [34268]
All tests passed.
-
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 49
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line49
I have some concerns about this design - given the Note above, this
would imply that we would have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34613/#review85006
---
Ship it!
src/master/allocator/sorter/drf/sorter.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 9:45 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review84984
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
On May 22, 2015, 7:27 a.m., Ian Downes wrote:
src/tests/port_mapping_tests.cpp, lines 186-187
https://reviews.apache.org/r/34436/diff/1/?file=966863#file966863line186
How much noise is there? This seems onerous to users to modify source
and recompile to enable some debug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34614/
---
Review request for mesos, Jie Yu and Niklas Nielsen.
Bugs: MESOS-2730
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34614/
---
(Updated May 22, 2015, 9:42 p.m.)
Review request for mesos, Jie Yu and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review84998
---
Two high level comments:
1) We need a slave flag to control if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34616/#review85004
---
Patch looks great!
Reviews applied: [34613, 34614, 34616]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 7:46 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/
---
(Updated May 22, 2015, 8:48 p.m.)
Review request for mesos, Chi Zhang, Ian
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 30
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line30
nit: s/correction/corrective action
also, prefer needs to be taken
Agree.
Also there is gramma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85016
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote:
I'm ok with adding these kinds of things to .gitignore.
I'm confused here - see comments to https://reviews.apache.org/r/33448
Also, what's the relationship with .gitignore-template? are we dropping it?
To be clear, I fully support these
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34614/
---
(Updated May 22, 2015, 9:40 p.m.)
Review request for mesos, Jie Yu and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34614/#review85029
---
Ship it!
include/mesos/master/allocator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/#review85032
---
Patch looks great!
Reviews applied: [34321, 34426, 34428, 34431,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34268/#review85054
---
Ship it!
Ship It!
- Stan Teresen
On May 22, 2015, 7:15 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34620/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34619/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/
---
(Updated May 22, 2015, 11:45 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34616/
---
(Updated May 23, 2015, 12:33 a.m.)
Review request for mesos, Jie Yu and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85055
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85045
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 23, 2015, 3:30 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34620/#review85026
---
Ship it!
Ship It!
- Vinod Kone
On May 22, 2015, 11:39 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34619/#review85025
---
Ship it!
Ship It!
- Vinod Kone
On May 22, 2015, 11:39 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34616/#review85031
---
Ship it!
LGTM! Could you please add a NOTE somewhere stating that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 23, 2015, 3:27 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34545/#review84903
---
docs/allocation-module.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review84908
---
First pass.
3rdparty/libprocess/include/process/http.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12550/#review84916
---
Hi Jason, do you still want this in?
- Niklas Nielsen
On July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34428/
---
(Updated May 22, 2015, 4:53 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/#review84919
---
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14039/#review84918
---
We have ''packages': [ 'mesos' ],' in src/python/setup.py.in - do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review84920
---
Can we split this in two? I am not sure about our policy with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/#review84915
---
src/linux/cgroups.cpp
On May 22, 2015, 5:28 a.m., Cong Wang wrote:
src/linux/routing/handle.hpp, line 118
https://reviews.apache.org/r/34321/diff/7/?file=968966#file968966line118
Same comments near the definitions in handle.cpp, duplicated?
Paul Brett wrote:
Once for the declaration, second for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated May 22, 2015, 4:31 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14039/#review84929
---
Bad patch!
Reviews applied: [14039]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review84914
---
There hasn't been any traffic on this review for almost 2 years.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/
---
(Updated May 22, 2015, 3:56 p.m.)
Review request for mesos, Chi Zhang, Ian
On May 20, 2015, 7:34 p.m., Paul Brett wrote:
src/slave/containerizer/isolators/filesystem/linux.cpp, line 69
https://reviews.apache.org/r/34135/diff/1/?file=957256#file957256line69
We don't need to be root, we just need to have CAP_SYS_ADMIN, and we
could pick that up through a
On May 14, 2015, 12:41 p.m., Timothy Chen wrote:
src/slave/containerizer/mesos/containerizer.cpp, line 193
https://reviews.apache.org/r/34137/diff/1/?file=957264#file957264line193
Not sure if I follow this logic or if I'm missing something, but the
provisioners hashmap seems to
On May 19, 2015, 12:17 a.m., Till Toenshoff wrote:
Thanks a lot for this, Stan - much appreciated!
There are a couple of style nits here and there and one basic question on
the need of the `read`-variant for Solaris.
For submitting an updated patch, please consult the patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321/#review84935
---
src/linux/routing/handle.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34432/
---
(Updated May 22, 2015, 5:28 p.m.)
Review request for mesos, Chi Zhang, Ian
On May 19, 2015, 12:17 a.m., Till Toenshoff wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, line 72
https://reviews.apache.org/r/34268/diff/1/?file=961220#file961220line72
Could you please explain why the standard implementation of this
function would not
On May 22, 2015, 3:56 p.m., Niklas Nielsen wrote:
Is this obsoleted by https://reviews.apache.org/r/29507/?
Yes, I believe so.
- Brenden
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review84944
---
Looks good! A few nits and let's get it in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84953
---
Patch looks great!
Reviews applied: [33792, 34068]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34268/
---
(Updated May 22, 2015, 7:15 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12885/#review84939
---
Bad patch!
Reviews applied: [12885]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 22, 2015, 5:49 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review84830
---
Thanks for the efforts! Here are my main sugguestions for this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34431/
---
(Updated May 22, 2015, 5:10 p.m.)
Review request for mesos, Chi Zhang, Ian
On May 22, 2015, 7:31 a.m., Ian Downes wrote:
src/slave/containerizer/isolators/network/port_mapping.hpp, lines 67-73
https://reviews.apache.org/r/34432/diff/1/?file=965780#file965780line67
Please state why they are exposed.
The same literarl strings are used in
65 matches
Mail list logo
