Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92739 --- docs/reconciliation.md (line 43)

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 23, 2015, 1:48 p.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92741 --- Ship it! docs/reconciliation.md (line 94)

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 23, 2015, 2:01 p.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 23, 2015, 12:19 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 23, 2015, 12:21 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92742 --- Patch looks great! Reviews applied: [36617] All tests passed. - M

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92747 --- Patch looks great! Reviews applied: [36612, 36620] All tests passe

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 9:42 a.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 297 > > > > > > According > > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definit

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/#review92769 --- Ship it! Ship It! - Joris Van Remoortere On July 23, 2015, 12:17

Review Request 36733: Moved framework struct in master to end of file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36732/ --- (Updated July 23, 2015, 5:27 p.m.) Review request for mesos, Jan Schlicht and V

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 5:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36732/ --- (Updated July 23, 2015, 5:33 p.m.) Review request for mesos, Jan Schlicht and V

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 23, 2015, 10:38 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92774 --- src/linux/cgroups.cpp (line 1672)

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36732/#review92776 --- Ship it! Can't remember if anyone sent a deprecation notice to dev

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

> On July 23, 2015, 5:47 p.m., Vinod Kone wrote: > > Can't remember if anyone sent a deprecation notice to dev list regarding > > this. If not, mind sending it? Will check/do, Thanks! - Joerg --- This is an automatically generated e-ma

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92627 --- Ship it! Nice test! 3rdparty/libprocess/3rdparty/stout/include/st

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36732/#review92782 --- Patch looks great! Reviews applied: [36732] All tests passed. - M

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/#review92784 --- Ship it! include/mesos/scheduler/scheduler.proto (lines 46 - 52) <

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

> On July 23, 2015, 6:24 p.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, lines 46-52 > > > > > > "does not receive heartbeats, or any other events, for an extended"? > > > > Just thinking

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92785 --- Overall looks good to me! I wish we could merge all the protobuf rel

Re: Review Request 36733: Moved framework struct in master to end of file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/#review92792 --- Is there anything preventing you from using forward declarations? O

Review Request 36742: Fixed the sanity check on OSX for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36742/ --- Review request for mesos, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: ME

Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/ --- (Updated July 23, 2015, 7:49 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36733: Moved framework struct in master to end of file

> On July 23, 2015, 7:25 p.m., Joseph Wu wrote: > > Is there anything preventing you from using forward declarations? Or just > > implementing the templated send function after the Master has been defined? > > > > i.e. > > ``` > > struct Framework { > > ... > > template > > void send(c

Re: Review Request 36742: Fixed the sanity check on OSX for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36742/#review92798 --- Ship it! LGTM Could you maybe add a comment or something to indica

Re: Review Request 36742: Fixed the sanity check on OSX for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36742/#review92799 --- Patch looks great! Reviews applied: [36742] All tests passed. - M

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/#review92800 --- Ship it! - Joseph Wu On July 22, 2015, 12:07 p.m., Michael Park w

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 23, 2015, 8:29 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 36672: Removed pthread specialization from Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/#review92801 --- Ship it! Ship It! - Joseph Wu On July 21, 2015, 9:07 p.m., Joris

Re: Review Request 36673: Removed pthread from Once and Gate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92802 --- Ship it! Ship It! - Joseph Wu On July 21, 2015, 10:55 p.m., Jori

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/#review92804 --- Ship it! Ship It! - Joseph Wu On July 21, 2015, 10:56 p.m., Jori

Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/#review92809 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 647)

Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/#review92811 --- Patch looks great! Reviews applied: [36629, 36672, 36673, 36674, 36

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/#review92814 --- Since this change removes all the uses of ThreadLocal (outside of s

Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/#review92815 --- Ship it! Ship It! - Artem Harutyunyan On July 21, 2015, 10:56 p.

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/#review92816 --- Ship it! Ship It! - Artem Harutyunyan On July 22, 2015, 12:07 p.

Re: Review Request 36672: Removed pthread specialization from Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/#review92817 --- Ship it! Ship It! - Artem Harutyunyan On July 21, 2015, 9:07 p.m

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 23, 2015, 9:33 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 23, 2015, 9:46 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/ --- (Updated July 23, 2015, 6:16 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92826 --- Bad patch! Reviews applied: [36718] Failed command: ./support/appl

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/ --- (Updated July 23, 2015, 7:24 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36740: Add small fixes allowing CMake to build Stout tests on OS X 10.10

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36740/ --- (Updated July 23, 2015, 11:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36743: Cause CMake to fail and return error code if C++11 not supported

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36743/ --- (Updated July 23, 2015, 11:40 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36741/ --- (Updated July 23, 2015, 11:40 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92834 --- src/master/master.cpp (lines 344 - 346)

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92812 --- The names 'encode' and 'decode' seem weird for the function paramete

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 23, 2015, 11:54 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 36663: Added ip_address field to MasterInfo

> On July 23, 2015, 11:51 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 1022 > > > > > > This test is testing the createMasterInfo() method which is not used in > > production. Can you also write a t

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 24, 2015, 12:17 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 36663: Added ip_address field to MasterInfo

> On July 23, 2015, 11:51 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 1022 > > > > > > This test is testing the createMasterInfo() method which is not used in > > production. Can you also write a t

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92849 --- Patch looks great! Reviews applied: [36718] All tests passed. - M

Review Request 36754: Updated Isolator::prepare to return IsolatorPrepareInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36754/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3133 https://issues.apache

Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3133 https://issues.apache

Review Request 36757: Added https support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/ --- Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs: MESOS-30

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92853 --- Patch looks great! Reviews applied: [36663] All tests passed. - M

Re: Review Request 36757: Added https support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92852 --- LGTM, just some minor comments. 3rdparty/libprocess/src/http.cpp (

Review Request 36759: Added an ExecutorToFramework message handler on the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36759/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3132 h

Review Request 36760: Handle scheduler pid as optional in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3132 h

Review Request 36761: Added tests for unset framework pid in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36761/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3132 h

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/#review92856 --- Patch looks great! Reviews applied: [36718, 36754, 36755] All test

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/#review92855 --- Looks very good ! src/messages/messages.proto (line 352)

Re: Review Request 36757: Added https support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/ --- (Updated July 24, 2015, 2:28 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36759/#review92859 --- Ship it! src/master/master.cpp (line 716)

Re: Review Request 36757: Added https support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92861 --- Patch looks great! Reviews applied: [36712, 36757] All tests passe

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review92862 --- src/tests/memory_test_helper.cpp (line 87)

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92863 --- Ship it! Ship It! - Jie Yu On July 23, 2015, 11:24 p.m., Kapil A

Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/#review92864 --- Ship it! Ship It! - Artem Harutyunyan On July 23, 2015, 12:49 p.

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/#review92865 --- Ship it! Ship It! - Artem Harutyunyan On July 22, 2015, 1:23 p.m

Re: Review Request 36761: Added tests for unset framework pid in the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36761/#review92866 --- Patch looks great! Reviews applied: [36759, 36760, 36761] All test

Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/ --- Review request for mesos, Ben Mahler, Kapil Arya, and Vinod Kone. Bugs: MESOS-3

Re: Review Request 36742: Fixed the sanity check on OSX for persistent volumes.

> On July 23, 2015, 8:15 p.m., Marco Massenzio wrote: > > LGTM > > > > Could you maybe add a comment or something to indicate why this failed on > > OSX (and what the fix was), in case someone introduces something similar in > > future, we'll have a reference to guide us. > > > > Thanks for s

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92872 --- Patch looks great! Reviews applied: [36763] All tests passed. - M