Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

> On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: > > I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be > > placed inside `include/mesos/master/` instead since the authorizer is only > > for the master. Does it make sense to do that? If it does, then should we > > also

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

> On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: > > I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be > > placed inside `include/mesos/master/` instead since the authorizer is only > > for the master. Does it make sense to do that? If it does, then should we > > also

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review94014 --- Patch looks great! Reviews applied: [36908] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94018 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94019 --- Patch looks great! Reviews applied: [36402] All tests passed. - M

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review93562 --- src/health-check/main.cpp (line 242)

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94023 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Al

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94024 --- src/master/master.hpp (line 916)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 3, 2015, 2:21 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.hpp, lines 26-27 > > > > > > I think we should wrap it into `master` namespace as well. `quota_handler.cpp` still lacks the `maste

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 2:39 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 916 > > > > > > I think we don't need this instance any more. I think so, too. - Bernd ---

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94027 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Al

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 9:52 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 37046: Merged registerFramework() and reregisterFramework().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37046/#review94028 --- Patch looks great! Reviews applied: [37046] All tests passed. - M

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94030 --- src/master/master.hpp (line 766)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94033 --- src/master/master.hpp (line 764)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94037 --- src/master/master.hpp (line 766)

Re: Review Request 36911: Removed unnecessary using directive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36911/#review94036 --- Ship it! Ship It! - Alexander Rojas On Aug. 3, 2015, 4:58 p.m.,

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 3:08 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 766 > > > > > > s/and / See my previous review. This is correct syntax IMHO. - Bernd -

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Aug. 4, 2015, 10:08 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 766 > > > > > > s/and / > > Bernd Mathiske wrote: > See my previous review. This is correct syntax IMHO. See Bernds comm

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 10:34 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 10:40 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94040 --- 3rdparty/libprocess/include/process/http.hpp (line 747)

Review Request 37072: Added test for allocator update on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2880 https://issues.ap

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94041 --- Ship it! Pending consistency with subsequent RRs in this chain, thi

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:54 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:57 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94048 --- Patch looks great! Reviews applied: [37065] All tests passed. - M

Re: Review Request 37072: Added test for allocator update on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/#review94050 --- Patch looks great! Reviews applied: [37072] All tests passed. - M

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/#review94054 --- Re-based the PR - Chris Heller On July 29, 2015, 1:41 p.m., Chris

Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/ --- Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/ --- (Updated Aug. 4, 2015, 1:49 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94058 --- Patch looks great! Reviews applied: [36913] All tests passed. - M

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94059 --- include/mesos/authorizer/authorizer.hpp (line 83)

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 2:32 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

> On Aug. 3, 2015, 11:36 p.m., Michael Park wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 81 > > > > > > What's the significance in the order in which these are called? I > > would've expected somet

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94067 --- Patch looks great! Reviews applied: [36847] All tests passed. - M

Re: Review Request 36867: Add "labels" to FrameworkInfo.

Hi folks, Thanks for the great feedback! I addressed almost all of these issues, but had a few things left to wrap up before uploading a new patch -- I'm traveling at the moment, but I should have a new patch by tomorrow. Neil On Mon, Aug 3, 2015 at 8:45 PM Adam B wrote: > This is an automatical

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

> On Aug. 4, 2015, 6:36 a.m., Michael Park wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 81 > > > > > > What's the significance in the order in which these are called? I > > would've expected someth

Review Request 37080: Introduced RecordIO response reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37080/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 36049: Added support for modularized Authorizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 4, 2015, 6:26 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 4, 2015, 6:27 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 36050: Added test authorizer module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 4, 2015, 6:27 p.m.) Review request for mesos, Adam B, Bernd Mathi

Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- Review request for mesos and Marco Massenzio. Bugs: MESOS-2337 https://issu

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 4:33 p.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 4:33 p.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On July 29, 2015, 7:12 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2128-2159 > > > > > > Any reason you're skipping validation (authorization) of the framework? > > Looks like we should pull out the

Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 4, 2015, 4:57 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 5:12 p.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

> On Aug. 4, 2015, 6:36 a.m., Michael Park wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 81 > > > > > > What's the significance in the order in which these are called? I > > would've expected someth

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 4, 2015, 5:15 p.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94084 --- Can you please define how did you test that this works in the 'tests

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

> On Aug. 4, 2015, 6:36 a.m., Michael Park wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 81 > > > > > > What's the significance in the order in which these are called? I > > would've expected someth

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 4, 2015, 5:33 p.m.) Review request for mesos, Kapil Arya and Marc

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

> On Aug. 4, 2015, 6:36 a.m., Michael Park wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 81 > > > > > > What's the significance in the order in which these are called? I > > would've expected someth

Re: Review Request 37010: stout: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37010/ --- (Updated Aug. 4, 2015, 5:42 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 4, 2015, 5:42 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 3, 2015, 9:38 p.m., Ben Mahler wrote: > > Is this ready to review? Mind updating the 'issues' accordingly? Just did, thanks for comments :) - Isabel --- This is an automatically generated e-mail. To reply, visit: https://revie

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/ --- (Updated Aug. 4, 2015, 5:43 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37012/ --- (Updated Aug. 4, 2015, 5:43 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 36956: Created a test abstraction for preparing test rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36956/#review93921 --- Ship it! src/tests/containerizer/rootfs.hpp (line 66)

Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-3196 h

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/ --- (Updated Aug. 4, 2015, 2:32 p.m.) Review request for mesos, Niklas Nielsen and

Review Request 37091: Stopped mutating executor info with default container info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37091/ --- Review request for mesos, Ben Mahler, Ian Downes, Timothy Chen, and Vinod Kone.

Re: Review Request 37072: Added test for allocator update on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/#review94104 --- Nice test! src/tests/oversubscription_tests.cpp (line 864)

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94105 --- Looking better! Can you please pull out the fixes to 'acceptsEncodin

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/#review94103 --- Patch looks great! Reviews applied: [37075] All tests passed. - M

Re: Review Request 35797: Updated Frameworkinfo.capabilities on framework re-registration to support adding capabilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35797/#review94102 --- Looks like you realized that you need to create a new review :) So I

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94112 --- 3rdparty/libprocess/src/http.cpp (line 155)

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 219 > > > > > > This will crash the program if tokens is empty! This will not crash, tokenize will always return a vector of

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 156 > > > > > > This will crash the program if tokens is empty! Please see comment below. - Isabel -

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 219 > > > > > > This will crash the program if tokens is empty! > > Isabel Jimenez wrote: > This will not crash, tokeniz

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

> On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote: > > Can you please define how did you test that this works in the 'tests' > > section? > > I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce > > the issue, and then applying the patch. > > > > Once we verify that it w

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 219 > > > > > > This will crash the program if tokens is empty! > > Isabel Jimenez wrote: > This will not crash, tokeniz

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/#review94121 --- Patch looks great! Reviews applied: [36910] All tests passed. - M

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94111 --- I'll get the /call validation committed. src/master/http.cpp (line

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 4, 2015, 9:29 p.m.) Review request for mesos and Ben Mahler. Re

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 10 p.m.) Review request for mesos, Ben Mahler and Vinod

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 4, 2015, 10:02 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94133 --- Patch looks great! Reviews applied: [36913] All tests passed. - M

Review Request 37101: Remove unused sched API's

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/ --- Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. Repository: mesos

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

> On Aug. 4, 2015, 9:07 p.m., Ben Mahler wrote: > > I'll get the /call validation committed. Let's follow up to get tests added for each of the error cases in /call. - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 4, 2015, 10:43 p.m.) Review request for mesos and Ben Mahler. R

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 219 > > > > > > This will crash the program if tokens is empty! > > Isabel Jimenez wrote: > This will not crash, tokeniz

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94130 --- I'll get the exited changes committed. src/master/master.cpp (line

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/#review94143 --- Ship it! src/slave/slave.cpp (lines 2720 - 2721)

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 4, 2015, 11:05 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 36402: Adding 'Accept' header in request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 4, 2015, 11:05 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 37091: Stopped mutating executor info with default container info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37091/#review94145 --- Ship it! Ship It! - Timothy Chen On Aug. 4, 2015, 7:01 p.m., Jie

Re: Review Request 36402: Adding 'Accept' header in request

> On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: > > Looking better! Can you please pull out the fixes to 'acceptsEncoding' into > > a separate review? Also, would like to see tests for the cases that weren't > > handled correctly (e.g. "gzipp;q=1.0" should not match "gzip"). Pulling the > > ch

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94148 --- Looks great paul! Just some minor things around style before we can

Review Request 37105: Removed the code of checkpointing container root filesystem path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

> On Aug. 4, 2015, 11:45 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 314-316 > > > > > > Any reason you're changing the style of the failure messages? Let's > > leave them untouched in this patch, since th

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 4, 2015, 11:57 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94152 --- Patch looks great! Reviews applied: [37045] All tests passed. - M

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 4, 2015, 11:59 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 5, 2015, midnight) Review request for mesos, Ben Mahler and Vinod

  1   2   >