Re: Review Request 38102: MESOS-3046

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/#review97639 --- Patch looks great! Reviews applied: [38102] All tests passed. -

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97641 --- looks good overall. some minor issues. src/master/master.cpp

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/ --- (Updated Sept. 3, 2015, 3:08 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38102: MESOS-3046

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/ --- (Updated Sept. 3, 2015, 2:01 p.m.) Review request for mesos and Ben Mahler.

Review Request 38102: MESOS-3046

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38102/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review97598 --- src/slave/containerizer/provisioners/docker/store.hpp (line 49)

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review97660 --- src/slave/containerizer/provisioners/docker/store.hpp (line 100)

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/#review97645 --- Patch looks great! Reviews applied: [37699] All tests passed. -

Re: Review Request 37873: Add quiesce logic in allocator

> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 153 > > > > > > Are we quiescing resources or rather offers? I think it should be > > called

Re: Review Request 37669: Ignore overflow docker components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97643 --- Ship it! src/tests/containerizer/docker_tests.cpp (line 229)

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Sept. 1, 2015, 9:46 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 553-555 > > > > > > Can you explain why this is a struct rather than a function? > >

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/#review97683 --- Perhaps a dumb question, but may I ask why you needed to introduce

Re: Review Request 38000: WIP: Added an API for libprocess users to interact with http::AuthenticatorManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Sept. 3, 2015, 10:40 a.m.) Review request for mesos and Benjamin

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97621 --- Patch looks great! Reviews applied: [38050] All tests passed. -

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:45 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37669: Ignore overflow docker components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97624 --- Ship it! Minor fixes can be dealt with when committing.

Re: Review Request 37669: Ignore overflow docker components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97628 --- Patch looks great! Reviews applied: [37669] All tests passed. -

Re: Review Request 37669: Ignore overflow docker components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Sept. 3, 2015, 11:16 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

> On Sept. 2, 2015, 5:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/appc/store.cpp, line 235 > > > > > > The wording sounds wierd, how about: > > > > "Cannot match any image in store

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

> On Aug. 31, 2015, 2:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:04 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37880/#review97701 --- Ship it! Ship It! - Chi Zhang On Aug. 31, 2015, 5:44 p.m.,

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

> On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 79 > > > > > > why the change to process::Message here and everywhere else? Actually, namespace "using process::Message;" has

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97693 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

> On Aug. 31, 2015, 9:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote: > > For any future CMake reviews, could you also add Artem (hartem) and I > > (kaysoky) as reviewers? > > Thanks in advance :) Sure? thank you very much. - haosdent --- This is an

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97674 --- 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 4, 2015, 2:20 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37873: Add quiesce logic in allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 4, 2015, 2:19 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 37669: Ignore overflow docker components in version parsing.

> On Sept. 3, 2015, 3:55 p.m., Jan Schlicht wrote: > > src/tests/containerizer/docker_tests.cpp, line 229 > > > > > > This is a test of the special case with a "1.7.1.fc22" version string. > > How about an

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Sept. 1, 2015, 4:46 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 553-555 > > > > > > Can you explain why this is a struct rather than a function? > >

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Sept. 3, 2015, 1:25 p.m.) Review request for mesos, Adam B and

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/ --- (Updated Sept. 3, 2015, 1:32 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/ --- (Updated Sept. 3, 2015, 1:33 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 3, 2015, 1:33 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Sept. 1, 2015, 4:46 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 553-555 > > > > > > Can you explain why this is a struct rather than a function? > >

Re: Review Request 37505: Fix broken health check in docker executor.

> On Aug. 31, 2015, 4:32 a.m., Timothy Chen wrote: > > src/docker/executor.cpp, line 361 > > > > > > You should be able to push the arguments with another vector insert? > > > > e.g: > > > >

Re: Review Request 37873: Add quiesce logic in allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97728 --- Patch looks great! Reviews applied: [37532, 37873] All tests

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:18 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97709 --- Ship it! Ship It! - Vinod Kone On Sept. 4, 2015, 1:18 a.m.,

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review97713 --- Patch looks great! Reviews applied: [38117] All tests passed. -

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Sept. 4, 2015, 3:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37669: Ignore overflow docker components in version parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Sept. 4, 2015, 2:27 a.m.) Review request for mesos, Ben Mahler,