Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 4:27 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1017-1020 > > > > > > Why do we put these code inside the framework sorters foreach loop? I > > do not see it

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 34 > > > > > > `strlen()` might be better/more-readable. So, I could definitely

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 10:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. Really?:-)

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:30 a.m.) Review request for mesos, Artem

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39540/ --- (Updated Oct. 27, 2015, 6:33 a.m.) Review request for mesos, Artem

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > lines 36-41 > > > > > > The posix spec says that `XX` suffix is required, so > >

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 9:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Oct. 27, 2015, 8:14 a.m.) Review request for mesos, Artem

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 34 > > > > > > `strlen()` might be better/more-readable. > > Alex Clemmer wrote:

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:23 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/ --- (Updated Oct. 27, 2015, 8:33 a.m.) Review request for mesos, Artem

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39539/ --- (Updated Oct. 27, 2015, 6:32 a.m.) Review request for mesos, Artem

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/ --- (Updated Oct. 27, 2015, 6:31 a.m.) Review request for mesos, Artem

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/ --- (Updated Oct. 27, 2015, 6:41 a.m.) Review request for mesos, Artem

Re: Review Request 39678: Allow environment variables when lanuch Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39678/#review104149 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 48 > > > > > > That `- 1` doesn't match the "size" described by the variable

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Oct. 27, 2015, 8:17 a.m.) Review request for mesos, Artem

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Oct. 26, 2015, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 42 > > > > > > `X:\blah*` isn't clear. Did you mean `currentPath` + `*`? I

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104156 ---

Review Request 39678: Allow environment variables when lanuch Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39678/ --- Review request for mesos. Bugs: MESOS-3787

Re: Review Request 39415: Error out when root qdisc already exists

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/#review104187 --- src/slave/containerizer/isolators/network/port_mapping.cpp (lines

Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3129

Re: Review Request 39415: Error out when root qdisc already exists

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/#review104185 --- Ship it! Ship It! - Ian Downes On Oct. 17, 2015, 5:22 p.m.,

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review104183 --- src/slave/containerizer/isolators/network/port_mapping.cpp (line

Re: Review Request 39416: Document --egress_unique_flow_per_container in docs/configuration.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39416/#review104117 --- docs/configuration.md (lines 1533 - 1534)

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 26, 2015, 6:52 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 897 > > > > > > I think we are not *moving" the role into the quota'ed role sorter, > > instead, we are adding

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Oct. 27, 2015, 7:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review104111 --- support/apply-reviews.py (line 38)

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/#review104204 --- Patch looks great! Reviews applied: [39695] All tests passed. -

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 27, 2015, 7:27 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have a stringify for this. > > Anand Mazumdar

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Oct. 27, 2015, 7:17 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

> On Oct. 26, 2015, 1:43 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, > > lines 35-40 > > > > > > Use `strings::endsWith`. > > > > And you might also

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Oct. 27, 2015, 10:45 p.m.) Review request for mesos, Alexander

Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3688

Review Request 39703: [WIP] Exposed container-id via TaskStatus updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39703/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3688

Re: Review Request 39415: Error out when root qdisc already exists

> On Oct. 27, 2015, 5:51 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1403-1404 > > > > > > Can you explain more? What if the slave restarts after creating the > >

Review Request 39707: Minor code refactor for fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/ --- Review request for mesos, Bernd Mathiske and Jie Yu. Repository: mesos

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 2:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. > > Qian

Re: Review Request 39416: Document --egress_unique_flow_per_container in docs/configuration.md

> On Oct. 27, 2015, 5:35 p.m., Ian Downes wrote: > > docs/configuration.md, lines 1533-1534 > > > > > > Does it actually create a flow per container or is it really based on > > the 5 tuple, which will be

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review104230 --- Patch looks great! Reviews applied: [39317, 38218, 39399, 39400,

Re: Review Request 39490: Always create non-IP egress filters

> On Oct. 27, 2015, 5:38 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2431 > > > > > > Why is this no longer a failure? They could be already created by the slave if

Re: Review Request 39415: Error out when root qdisc already exists

> On Oct. 27, 2015, 5:51 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1403-1404 > > > > > > Can you explain more? What if the slave restarts after creating the > >

Re: Review Request 39703: [WIP] Exposed container-id via TaskStatus updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39703/#review104240 --- Patch looks great! Reviews applied: [39702, 39703] All tests

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:39 a.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:58 a.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39710/ --- (Updated Oct. 28, 2015, 4:54 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/ --- (Updated Oct. 28, 2015, 4:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39710/ --- (Updated Oct. 28, 2015, 4:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/ --- (Updated Oct. 28, 2015, 4:54 a.m.) Review request for mesos, Ben Mahler,

Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39710/ --- Review request for mesos. Repository: mesos Description --- See summary

Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.

Review Request 39708: Removed redundant code for conversion from PID to HTTP based frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39708/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. Summary

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review104253 --- Patch looks great! Reviews applied: [37853] All tests passed. -

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/ --- (Updated Oct. 28, 2015, 3:35 a.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 37853: Overlay filesystem provisioning backend

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review104245 --- Bad patch! Reviews applied: [37853] Failed command:

Re: Review Request 39707: Minor code refactor for fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39707/#review104243 --- Patch looks great! Reviews applied: [39707] All tests passed. -

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 27, 2015, 2:27 p.m.) Review request for mesos, Jie Yu, Timothy