Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 11, 2015, 7:55 a.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 67-87 > > > > > > How come we don't leverage the validation routine you introduced in > > this patch here? As the v

Review Request 40179: Fixed a typo in a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40179/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3884 https:/

Review Request 40181: Corrected formatting in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40181/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3884 https:/

Review Request 40180: Removed namespaces in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40180/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3884 https:/

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

> On Nov. 10, 2015, 12:23 p.m., Vinod Kone wrote: > > support/apply-review.sh, line 5 > > > > > > do we even need this script anymore? is this for backwards compatiblity > > with existing tooling? is that plan to kill

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 11, 2015, 2:08 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 11, 2015, 2:10 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39288: Quota: Added authentication of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/ --- (Updated Nov. 11, 2015, 11:19 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 39289: Quota: Added authorization of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/ --- (Updated Nov. 11, 2015, 11:20 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/ --- (Updated Nov. 11, 2015, 10:28 a.m.) Review request for mesos, Bernd Mathiske, J

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 337 > > > > > > let's pull fixes like this out separately. I'll gladly commit it as a > > distinct pat

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/ --- (Updated Nov. 11, 2015, 10:29 a.m.) Review request for mesos, Bernd Mathiske, J

Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40181/#review106031 --- Patch looks great! Reviews applied: [40179, 40180, 40181] All tes

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 83-88 > > > > > > Why don't you just parse a QuotaInfo object instead of a > > form-serialized body (with JSON components)? > >

Re: Review Request 39289: Quota: Added authorization of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review106035 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 39289: Quota: Added authorization of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review106037 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 40179: Fixed a typo in a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40179/#review106039 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 11, 2015, 10:0

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review106038 --- src/tests/master_quota_tests.cpp (line 288)

Re: Review Request 40179: Fixed a typo in a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40179/#review106043 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 10:03 a.m., Al

Re: Review Request 40180: Removed namespaces in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40180/#review106044 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 10:05 a.m., Al

Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40181/#review106045 --- src/master/allocator/mesos/hierarchical.cpp (line 164)

Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".

> On Nov. 11, 2015, 12:57 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 166 > > > > > > Why moving the check here? This should be at the beginning of the > > function. Because every

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 463 > > > > > > We try to keep tests atomic: testing one thing at a time. However, I > > think it does make sense

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review106053 --- support/apply-reviews.py (lines 148 - 154)

Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/ --- Review request for mesos, Benjamin Bannier and Till Toenshoff. Bugs: MESOS-3899

Re: Review Request 40180: Removed namespaces in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40180/#review106056 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 11, 2015, 10:0

Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40181/#review106057 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 11, 2015, 10:0

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106059 --- Ship it! - Benjamin Bannier On Nov. 11, 2015, 2:16 p.m., Jan Sch

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106061 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 5:59 a.m., Jam

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106064 --- Patch looks great! Reviews applied: [40187] All tests passed. -

Re: Review Request 40187: Fixed and formatted JSON examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106065 --- Patch looks great! Reviews applied: [40187] All tests passed. -

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

> On Nov. 10, 2015, 8:23 p.m., Vinod Kone wrote: > > support/apply-review.sh, line 5 > > > > > > do we even need this script anymore? is this for backwards compatiblity > > with existing tooling? is that plan to kill

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 11, 2015, 5:35 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Nov. 11, 2015, 9:49 a.m.) Review request for mesos, Anand Mazumdar, Ji

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review106102 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 39331: Support docker local store pull image simultaneously

> On Nov. 10, 2015, 1:59 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 136 > > > > > > Wondering if you need to pass "recursive" (true) to mkdir. This flag > > ensur

Re: Review Request 39331: Support docker local store pull image simultaneously

> On Nov. 9, 2015, 4:33 p.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 1193 > > > > > > Owned puller(new MockPuller()) I search through all tests that use mock object. Seem

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review106114 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913, 3

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106118 --- I have troubles seeing the whole patch. Maybe it's because a circul

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/ --- (Updated Nov. 11, 2015, 10:43 a.m.) Review request for mesos, Anand Mazumdar, J

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review106125 --- Ship it! - Vinod Kone On Nov. 11, 2015, 12:14 a.m., Jojy Varghes

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review106127 --- support/verify_reviews.py (line 122)

Re: Review Request 40162: Updated docker build script to install libev package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40162/#review106128 --- Ship it! Ship It! - Vinod Kone On Nov. 10, 2015, 11:47 p.m., Jo

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review106122 --- One thing I think is not entirely clean is repetition of some valid

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/#review106124 --- src/CMakeLists.txt (lines 198 - 199)

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review106134 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39331: Support docker local store pull image simultaneously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review106137 --- Patch looks great! Reviews applied: [39331] All tests passed. -

Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 11, 2015, 6:48 p.m., Alexander Rukletsov wrote: > > One thing I think is not entirely clean is repetition of some validation > > checks. For example, you check whether a role is set twice: while > > constructing a `QuotaInfo` instance and while validating it. I think we can > > sacri

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/#review106139 --- can you rebase? - Vinod Kone On Nov. 7, 2015, 7:08 p.m., Guangya

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 11, 2015, 8:13 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 11, 2015, 6:48 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 148 > > > > > > You call it "request query string" above, any reason you change the > > name? > > Joerg Schad wrote:

Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/ --- Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen. Reposi

Re: Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106151 --- Ship it! Ship It! - Jojy Varghese On Nov. 11, 2015, 9:09 p.m.,

Re: Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106152 --- Ship it! Ship It! - Gilbert Song On Nov. 11, 2015, 1:09 p.m., J

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106142 --- src/slave/slave.cpp (lines 4244 - 4247)

Re: Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106157 --- Patch looks great! Reviews applied: [40199] All tests passed. -

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/#review106154 --- bootstrap.bat (line 40)

Re: Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106158 --- Ship it! Ship It! - Timothy Chen On Nov. 11, 2015, 9:09 p.m., J

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/ --- (Updated Nov. 11, 2015, 1:53 p.m.) Review request for mesos, Jie Yu, Jojy Vargh

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review106159 --- Bad patch! Reviews applied: [38901, 38919, 39712] Failed command:

Re: Review Request 40199: Fix CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106162 --- Patch looks great! Reviews applied: [40199] All tests passed. -

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/ --- (Updated Nov. 11, 2015, 2:55 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/#review106167 --- Ship it! Ship It! - Jie Yu On Nov. 11, 2015, 10:55 p.m., Gilber

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39695/#review106169 --- Patch looks great! Reviews applied: [39695] All tests passed. -

Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/ --- Review request for mesos, Jie Yu and Jojy Varghese. Repository: mesos Descrip

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review106182 --- docs/mesos-provisioner.md (line 13)

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4244-4247 > > > > > > why do it here instead of in recoverFramework() #4363? that feels more > > consistent with #1345. I did this af

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review106184 --- Patch looks great! Reviews applied: [40211] All tests passed. -

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review106186 --- Patch looks great! Reviews applied: [40211] All tests passed. -

Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Reposit

Re: Review Request 39991: fetcher should extract from .tar archive

> On Nov. 6, 2015, 4:49 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, lines 553-554 > > > > > > This is from way before (pre-2014 as I recall), found in and copied > > from pre-existing the code above

Re: Review Request 39991: fetcher should extract from .tar archive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39991/ --- (Updated Nov. 12, 2015, 1:47 a.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 10, 2015, 4:11 a.m., Kapil Arya wrote: > > support/apply-reviews.py, lines 196-197 > > > > > > Can we enhance it as following: > > ``` > > amend=options['no_amend'] ? '' : '-e' > > cmd = 'git c

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/#review106192 --- Patch looks great! Reviews applied: [40214] All tests passed. -

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/#review106193 --- Patch looks great! Reviews applied: [40214] All tests passed. -

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/ --- (Updated 十一月 12, 2015, 2:33 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 39991: fetcher should extract from .tar archive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39991/#review106194 --- Patch looks great! Reviews applied: [39991] All tests passed. -

Re: Review Request 39991: fetcher should extract from .tar archive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39991/#review106195 --- Patch looks great! Reviews applied: [39991] All tests passed. -

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/#review106196 --- Patch looks great! Reviews applied: [40005] All tests passed. -

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40005/#review106197 --- Patch looks great! Reviews applied: [40005] All tests passed. -

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 12, 2015, 5:41 a.m.) Review request for mesos, Kapil Arya and Vin

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106199 --- Patch looks great! Reviews applied: [40177] All tests passed. -

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106200 --- Patch looks great! Reviews applied: [40177] All tests passed. -