Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43827/#review120175 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490,

Re: Review Request 43777: Removed unnecessary parameter from validation function.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/ --- (Updated Feb. 22, 2016, 7:54 p.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 43848: Used `size_t` to track number of frameworks per role.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

2016-02-22 Thread Benjamin Bannier
> On Feb. 22, 2016, 8:30 p.m., Neil Conway wrote: > > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 286 > > > > > > "Remembering all of these rules is simply too complicated, so we opt to >

Review Request 43849: Fixed typos in subprocess.cpp comments.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43849/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43826/#review120166 --- site/source/blog/2016-02-16-synchronized-statements-in-mesos.md

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120156 ---

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 22, 2016, 1:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43838: Added note about not implemented requestResources call.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/#review120188 --- Patch looks great! Reviews applied: [43819, 43838] Passed

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120195 --- Patch looks great! Reviews applied: [43792, 43798] Passed

Review Request 43850: Added a wait for killed tast to prevent misscount of events.

2016-02-22 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/ --- Review request for mesos, Bernd Mathiske and Joseph Wu. Repository: mesos

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- (Updated Feb. 22, 2016, 7:59 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

2016-02-22 Thread Neil Conway
> On Feb. 22, 2016, 7:30 p.m., Neil Conway wrote: > > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md, line 286 > > > > > > "Remembering all of these rules is simply too complicated, so we opt to >

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-22 Thread Greg Mann
> On Feb. 20, 2016, 8:19 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 238-240 > > > > > > I think that we need to clarify that the `role` checking except "*" > > will be checked in

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/ --- (Updated Feb. 22, 2016, 7:58 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39372: Introduced a callback interface for testing the scheduler library.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39372/ --- (Updated Feb. 22, 2016, 8:19 p.m.) Review request for mesos and Vinod Kone.

Review Request 43847: Added master/scheduler failover tests for scheduler library.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4686

Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/ --- (Updated Feb. 22, 2016, 8:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- (Updated Feb. 22, 2016, 7:55 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 22, 2016, 7:58 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-02-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated Feb. 22, 2016, 12:22 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- (Updated Feb. 22, 2016, 7:47 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- (Updated Feb. 22, 2016, 8:19 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120133 --- Patch looks great! Reviews applied: [43552] Passed command:

Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43827/ --- Review request for mesos. Repository: mesos Description --- Introducing

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43821/#review120135 --- Patch looks great! Reviews applied: [43821] Passed command:

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43827/ --- (Updated Feb. 22, 2016, 10:18 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43827/ --- (Updated Feb. 22, 2016, 10:17 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

2016-02-22 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review120272 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:11 p.m.,

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/#review120273 --- Some doc may also need to be changed by removing the ssl related

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120137 --- Patch looks great! Reviews applied: [43032] Passed command:

Re: Review Request 43817: Removed no-longer-used model functions.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/#review120140 --- Patch looks great! Reviews applied: [43816, 43822, 43823, 43817]

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43854/ --- (Updated Feb. 22, 2016, 2:52 p.m.) Review request for mesos, Artem

Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43854/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120208 --- Ship it! Ship It! - Gilbert Song On Feb. 19, 2016, 10:09

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/#review120211 --- Ship it! Ship It! - Neil Conway On Feb. 22, 2016, 6:44

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review120199 --- Ship it! Ship It! - Greg Mann On Feb. 19, 2016, 7:38 p.m.,

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-22 Thread Joerg Schad
> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? I wanted to keep the Scheduler API

Review Request 43838: Added note about not implemented requestResources call.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/ --- Review request for mesos, Adam B and Guangya Liu. Repository: mesos

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 22, 2016, 3:48 p.m.) Review request for mesos, Alexander

Re: Review Request 43824: Addressed comments of 41672.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review120150 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-22 Thread Bernd Mathiske
> On Feb. 19, 2016, 1:02 a.m., Alexander Rukletsov wrote: > > src/tests/fetcher_cache_tests.cpp, lines 189-191 > > > > > > Will it be more clear to explicitly advance clock in those tests? I > > think keeping

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review120143 --- Fix it, then Ship it! src/tests/fetcher_cache_tests.cpp (line

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 23, 2016, 12:16 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43858: Updated the website for 0.27.1 release.

2016-02-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43858/#review120221 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 23, 2016,

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-22 Thread Kevin Klues
> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote: > > In general, I prefer scripts with a bunch of helper functions and a compact > > main() that steps through each of them. I'm not sure what the general > > concensus for the Mesos code base is, but I generally find this easier to > > walk

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120223 --- support/push-reviews.py (lines 14 - 15)

Review Request 43859: Fix invalid usage of ATOMIC_FLAG_INIT (MESOS-4602).

2016-02-22 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43859/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-4602

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/#review120214 --- Ship it! Ship It! - Vinod Kone On Feb. 22, 2016, 6:44 p.m.,

Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43657/#review120217 --- Ship it! Ship It! - Vinod Kone On Feb. 18, 2016, 4:54 a.m.,

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/#review120231 --- Ship it! Ship It! - Michael Park On Feb. 22, 2016, 6:44

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120233 --- Ship it! Ship It! - Michael Park On Feb. 23, 2016, 12:16

Re: Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43641/#review120232 --- Ship it! Ship It! - Michael Park On Feb. 22, 2016, 6:43

Re: Review Request 37168: Added example for dynamic reservation features.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review120212 --- src/examples/dynamic_reservation_framework.cpp (line 94)

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/#review120215 --- Patch looks great! Reviews applied: [43639, 43641, 43642]

Review Request 43855: Added Appc fetcher support to store.

2016-02-22 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 43858: Updated the website for 0.27.1 release.

2016-02-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43858/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

2016-02-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43860/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120207 --- src/tests/reservation_endpoints_tests.cpp (line 1269)

Re: Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43641/#review120213 --- Ship it! Ship It! - Vinod Kone On Feb. 22, 2016, 6:43 p.m.,

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/ --- (Updated Feb. 22, 2016, 11:51 p.m.) Review request for mesos, Alexander

Re: Review Request 43658: Modified the received callback argument to be ref.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43658/#review120218 --- Ship it! Ship It! - Vinod Kone On Feb. 17, 2016, 7:23 p.m.,

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/ --- (Updated Feb. 22, 2016, 11:55 p.m.) Review request for mesos, Alexander

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120201 --- Patch looks great! Reviews applied: [43796] Passed command:

Re: Review Request 43850: Added a wait for killed tast to prevent misscount of events.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/#review120196 --- src/tests/containerizer/memory_pressure_tests.cpp (line 231)

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120209 --- Fix it, then Ship it! src/tests/reservation_tests.cpp (line

Re: Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43641/#review120210 --- Ship it! Ship It! - Neil Conway On Feb. 22, 2016, 6:43

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/#review120244 --- Patch looks great! Reviews applied: [43657, 43658, 43659, 43660,

Re: Review Request 43838: Added note about not implemented requestResources call.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/#review120251 --- Seems you are losing python interface. - Guangya Liu On 二月 22,

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-22 Thread Guangya Liu
> On 二月 22, 2016, 3:20 a.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? > > Joerg Schad wrote: > I wanted

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Guangya Liu
> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > > > > > Can you please add some test cases to cover those scenarios? > > > > 1) authentication is enabled and

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-02-22 Thread Yongqiao Wang
> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120238 --- Fix it, then Ship it! src/tests/reservation_tests.cpp (line

Review Request 43863: Move the implementation of updateWeights out of header.

2016-02-22 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-4214

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/ --- (Updated Feb. 22, 2016, 5:18 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-22 Thread Joerg Schad
> On Feb. 22, 2016, 8:16 a.m., Michael Park wrote: > > docs/persistent-volume.md, line 56 > > > > > > Do you know if we actually have a good reason for the 8 space indent > > here as opposed to 4? I noticed that

Re: Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43826/#review120162 --- Patch looks great! Reviews applied: [43826] Passed command:

Review Request 43868: Add a getter for master::Flags.

2016-02-22 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/ --- Review request for mesos. Repository: mesos Description --- MESOS-3481

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-22 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/ --- (Updated Feb. 23, 2016, 5:13 a.m.) Review request for mesos. Bugs:

Re: Review Request 43868: Add a getter for master::Flags.

2016-02-22 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/ --- (Updated Feb. 23, 2016, 5:16 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/#review120260 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43854/#review120268 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line

Re: Review Request 43854: Fixed chdir to an empty directory error.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43854/#review120261 --- Patch looks great! Reviews applied: [43854] Passed command:

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43792/ --- (Updated Feb. 22, 2016, 6 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43798: Added overview section to upgrades.md.

2016-02-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated Feb. 22, 2016, 6:20 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43716: Endpoint documents with title.

2016-02-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/#review120170 --- Looks like you need to title each page as "Apache Mesos" instead

Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-22 Thread Joerg Schad
> On Feb. 22, 2016, 8:43 a.m., Michael Park wrote: > > Upon looking through the pattern, it seems like the evolution of this has > > been: > > > > ``` > > In order to upgrade a running cluster: > > > > * ... > > * ... > > ``` > > > > then came some `NOTE`s: > > > > ``` > > __NOTE__: ... > >

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-02-22 Thread Joerg Schad
> On Feb. 16, 2016, 3:28 a.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2417 > > > > > > No allocation because there is no slaves. We have trigger allocation by > >

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

2016-02-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/ --- (Updated Feb. 22, 2016, 6:26 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 43838: Added note about not implemented requestResources call.

2016-02-22 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/#review120253 --- docs/app-framework-development-guide.md (line 172)

Re: Review Request 43838: Added note about not implemented requestResources call.

2016-02-22 Thread Joerg Schad
> On Feb. 23, 2016, 3 a.m., Klaus Ma wrote: > > docs/app-framework-development-guide.md, line 172 > > > > > > It seems scheduler did not send `ResourceRequestMessage` to the master; > > so other allocator also can

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120256 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Review Request 43864: Fix typo of roles doc.

2016-02-22 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 43849: Fixed typos in subprocess.cpp comments.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43849/#review120255 --- Patch looks great! Reviews applied: [43849] Passed command:

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
> On Feb. 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > > > > > Can you please add some test cases to cover those scenarios? > > > > 1) authentication is enabled

Re: Review Request 43641: Removed unnecessary parameter from validation function.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43641/ --- (Updated Feb. 22, 2016, 6:43 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43642/ --- (Updated Feb. 22, 2016, 6:44 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-22 Thread Guangya Liu
> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 288 > > > > > > What about using a uuid like dir here? There might be duplicate > > "XX" under

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/#review120270 --- Patch looks great! Reviews applied: [43588] Passed command:

  1   2   >