Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/ --- (Updated March 3, 2016, 8:12 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121642 --- Thanks for the follow-up! Let's move this test before all becnhmar

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2423-2433 > > > > > > Will it be cleaner to put resources from the allocation into a hashmap > > by f

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 3, 2016, 12:24 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 81-84 > > > > > > Lets do this in a separate patch once the implementation for the > > isolator is c

Review Request 44326: Added missing includes in metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44326/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Repository: mesos

Review Request 44327: Updated a comment around metrics snapshot request timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44327/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Repository: mesos

Review Request 44325: Removed superfluous periods in failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44325/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Repository: mesos

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 3, 2016, 5:58 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 43824: Addressed comments of 41672.

> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2759-2770 > > > > > > Let me clarify what I meant in r/41672/. I would like to avoid the > > `if-else`

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review121833 --- Bad patch! Reviews applied: [44186, 44286] Failed command: ./sup

Re: Review Request 43105: Ensured the allocator does not double account resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ --- (Updated March 3, 2016, 1 p.m.) Review request for mesos and Ben Mahler. Chan

Review Request 44332: Fixed a typo in the HierarchicalAllocatorTest.CoarseGrained test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44332/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository: meso

Review Request 44331: Added a test to ensure the allocator does not double account resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44331/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/ --- (Updated March 3, 2016, 1 p.m.) Review request for mesos and Ben Mahler. Chan

Review Request 44334: Cleaned up empty hashmaps from allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos De

Review Request 44335: Moved variable declarations closer to where they are used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos De

Review Request 44333: Corrected a typo in the allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44333/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos De

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 1:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking proc

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 11:37 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 43 > > > > > > Is it what clnag-format suggest? I doubt it : ) > > Benjamin Bannier wrote: > Yes, that's

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 11:37 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 23 > > > > > > s/ > s/>/" > > > > We use <> only for "library" or public includes: libprocess, s

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review121835 --- src/tests/cluster.hpp (line 168)

Re: Review Request 43824: Addressed comments of 41672.

> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609 > > > > > > I'm an ESL, but having both "per weight" and "by weight" sounds a bit > > strang

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 3, 2016, 1:28 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 3, 2016, 2:32 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43806: Add comments for rebalance.

> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. Do you mean we should upd

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking proc

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 23 > > > > > > s/ > s/>/" > > > > We use <> only for "library" or public includes: libprocess, s

Re: Review Request 43806: Add comments for rebalance.

> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. > > Yongqiao Wang wrote:

Re: Review Request 43824: Addressed comments of 41672.

> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2635-2640 > > > > > > Does it fit one line? I know we are a bit inconsistent about it, but > > let's p

Re: Review Request 43806: Add comments for rebalance.

> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. > > Yongqiao Wang wrote:

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121855 --- LGTM, pending dependencies. - Bernd Mathiske On March 2, 2016,

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review121854 --- src/tests/slave_recovery_tests.cpp (line 3342)

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 3, 2016, 9:57 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121856 --- docs/monitoring.md (line 872)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121840 --- src/Makefile.am (line 632)

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 3, 2016, 2:05 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 44326: Added missing includes in metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44326/ --- (Updated March 3, 2016, 2:42 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2406 > > > > > > I believe the actual value in JSON is double, right? > > Benjamin Bannier wrote: >

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121861 --- src/master/allocator/mesos/metrics.hpp (line 29)

Review Request 44337: Updated utils for URI constructor streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4851 https://issues.apache

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121860 --- docs/monitoring.md (line 879)

Review Request 44338: Added URI test for HDFS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44338/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/ --- (Updated March 3, 2016, 3:39 p.m.) Review request for mesos and Joris Van Remoo

Review Request 44339: Disabled Appc simple fetch test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44339/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- D

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, line 872 > > > > > > s/the allocator was triggered/allocation was performed. > > > > Technically, we trigger allocator when

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 3, 2016, 3:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 29 > > > > > > Maybe make it a struct? I am not sure why that would be useful; also, it is defined as a class

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 3, 2016, 4:04 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1711-1712 > > > > > > My intuition is that using `allocationScalarQuantities` will be more > > effic

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, lines 28-30 > > > > > > I actually don't think we should wright this obvious comment here, but > > maybe there are

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking proc

Re: Review Request 44339: Disabled Appc simple fetch test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44339/#review121871 --- Isn't there already a CurlFilter for tests? - Joerg Schad On Ma

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into containe

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into containe

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

> On March 2, 2016, 4:07 p.m., Avinash sridharan wrote: > > docs/endpoints/slave/state.json.md, line 91 > > > > > > Do we need to change some install scripts to create these paths? I > > think we should leave the pat

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 4:53 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 3, 2016, 4:40 p.m.) Review request for mesos, Klaus Ma and Timot

Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828 https:/

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

> On March 1, 2016, 5:03 p.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 698-705 > > > > > > While users can config the CNI network form a JSON file, is it possible > > to provide an option to define the CN

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121878 --- Can you rebase? Looks like the diff is not correct. - Jie Yu On

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 4:58 p.m., Jie Yu wrote: > > Can you rebase? Looks like the diff is not correct. Bleh. Sorry I didn't notice that :-/ - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 3, 2016, 5 p.m.) Review request for mesos, Jie Yu and Jiang Yan

Review Request 44343: Used single space in license check error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44343/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 44339: Disabled Appc simple fetch test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44339/#review121883 --- I commited a fix using the CURL test filter. - Jie Yu On March

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 3, 2016, 5:13 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121884 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (line 24)

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44290/ --- (Updated March 3, 2016, 5:15 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44279/ --- (Updated March 3, 2016, 5:16 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121885 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 26

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 3, 2016, 5:29 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 3, 2016, 5:29 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 3, 2016, 5:30 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121888 --- src/Makefile.am (line 869)

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121889 --- src/slave/containerizer/mesos/containerizer.cpp (line 216)

Review Request 44345: Removing references to ShutdownFramework acl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44345/ --- Review request for mesos. Repository: mesos Description --- Removing ref

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121890 --- Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:38 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 216 > > > > > > Does your isolator only work in linux? Yes. - James

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:30 p.m., haosdent huang wrote: > > src/Makefile.am, line 869 > > > > > > Do you forgot to update CMake? Nope, I just didn't want to block on learning how to do this in Cmake. Can we split that

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:30 p.m., haosdent huang wrote: > > src/Makefile.am, line 869 > > > > > > Do you forgot to update CMake? > > James Peach wrote: > Nope, I just didn't want to block on learning how to do this

Re: Review Request 44342: XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 3, 2016, 6:06 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:51 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 597 > > > > > > Why we don't move assign logic to `isolate()`? You want to do the project ID assign

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:51 p.m., haosdent huang wrote: > > Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC` only > > happen when call `write` and we could not register any singal handler in > > this isolator to receive a exceed quote singal, right? The write fails with ``EDQUO

Re: Review Request 44342: XFS disk resource isolator.

> On March 3, 2016, 5:51 p.m., haosdent huang wrote: > > Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC` only > > happen when call `write` and we could not register any singal handler in > > this isolator to receive a exceed quote singal, right? > > James Peach wrote: >

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121902 --- Ship it! Ship It! - Vinod Kone On March 3, 2016, 5:13 p.m.,

Re: Review Request 44332: Fixed a typo in the HierarchicalAllocatorTest.CoarseGrained test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44332/#review121907 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? In this case, it's because all inje

  1   2   3   >