Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121953 --- Patch looks great! Reviews applied: [44200, 44269] Passed

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 3, 2016, 3:11 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-03 Thread Anurag Singh
> On March 3, 2016, 10:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Review Request 44362: Prevents early container destruction in MemoryPressureTests.

2016-03-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44362/ --- Review request for mesos, Joseph Wu and Vinod Kone. Bugs: MESOS-4047

Re: Review Request 44345: Removing references to ShutdownFramework acl.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44345/#review121956 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44362: Prevents early container destruction in MemoryPressureTests.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44362/#review121957 --- Fix it, then Ship it!

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

2016-03-03 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/#review121892 --- I've left a bunch of comments here, because I'd like us to nudge

Re: Review Request 44370: Fixed incorrect http authenticator module type.

2016-03-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44370/#review121965 --- Ship it! Ship It! - Alexander Rojas On March 4, 2016, 1:05

Re: Review Request 44273: Modified scheduler tests to use the callback interface.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44273/#review121964 --- Ship it! Ship It! - Vinod Kone On March 3, 2016, 1:29 a.m.,

Review Request 44370: Fixed incorrect http authenticator module type.

2016-03-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44370/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 44370: Fixed incorrect http authenticator module type.

2016-03-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44370/ --- (Updated March 4, 2016, 12:14 a.m.) Review request for mesos and Alexander

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review121985 --- Ship it! Ship It! - haosdent huang On March 4, 2016, 1:38

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
> On March 3, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 694 > > > > > > s/directory/location > > > > remove this line: > > This flag is used for\n" > > "the

Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/ --- Review request for mesos, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs:

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 4, 2016, 9:33 a.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 4, 2016, 9:37 a.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 4, 2016, 10:33 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44362: Prevents early container destruction in MemoryPressureTests.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44362/#review121961 --- Fix it, then Ship it! +1 for Vinod's comments

Re: Review Request 44362: Prevents early container destruction in MemoryPressureTests.

2016-03-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44362/ --- (Updated March 4, 2016, 12:57 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/#review121966 --- Ship it! Ship It! - Vinod Kone On March 4, 2016, 12:03

Review Request 44371: Added CHANGELOG description for reservation labels.

2016-03-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44371/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/#review121983 --- Is this patch in upstream glog? - Neil Conway On March 4,

Re: Review Request 44343: Used single space in license check error message.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44343/#review121992 --- Patch looks great! Reviews applied: [44343] Passed command:

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Neil Conway
> On March 4, 2016, 1:40 a.m., Neil Conway wrote: > > Is this patch in upstream glog? > > Zhiwei Chen wrote: > No, this is PowerPC LE porting patch, and this patch can also work on > other platforms. > > As you can see the diff of this patch, it will not break other platforms. I

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- (Updated March 4, 2016, 10:36 a.m.) Review request for mesos, Avinash

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122000 --- src/slave/containerizer/docker.cpp (lines 133 - 135)

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- (Updated March 3, 2016, 11:37 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-03 Thread Joseph Wu
> On March 3, 2016, 2:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Re: Review Request 44371: Added CHANGELOG description for reservation labels.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44371/#review121975 --- Fix it, then Ship it! CHANGELOG (line 23)

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

2016-03-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/ --- (Updated March 4, 2016, 12:03 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

2016-03-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- (Updated March 4, 2016, 12:03 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-03 Thread Anurag Singh
> On March 3, 2016, 10:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Re: Review Request 44371: Added CHANGELOG description for reservation labels.

2016-03-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44371/ --- (Updated March 4, 2016, 12:55 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44342: XFS disk resource isolator.

2016-03-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/#review121952 --- Current comments while going through the code. Will do a more

Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4864

Review Request 44364: Added infrastructure for Nvidia GPU specific tests.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4863

Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4860

Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- Review request for mesos, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs:

Review Request 44366: Added GPUs as an explicit resource.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4865

Review Request 44361: Added configure flags to build with Nvidia GPU support.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4861

Review Request 44363: Added stubs for the Nvidia GPU device isolator.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4623

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
> On March 2, 2016, 1:03 a.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 698-705 > > > > > > While users can config the CNI network form a JSON file, is it possible > > to provide an option to define the

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review121978 --- CHANGELOG (line 12)

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- (Updated March 4, 2016, 1:21 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Klaus Ma
> On Feb. 22, 2016, 12:41 p.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 4, 2016, 2:10 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
> On March 4, 2016, 9:40 a.m., Neil Conway wrote: > > Is this patch in upstream glog? > > Zhiwei Chen wrote: > No, this is PowerPC LE porting patch, and this patch can also work on > other platforms. > > As you can see the diff of this patch, it will not break other platforms. >

Re: Review Request 44337: Updated utils for URI constructor streaming.

2016-03-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/ --- (Updated 三月 4, 2016, 3 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 44337: Updated utils for URI constructor streaming.

2016-03-03 Thread Guangya Liu
> On 三月 3, 2016, 7:16 p.m., Jie Yu wrote: > > src/uri/utils.cpp, lines 57-61 > > > > > > OK, this effectively disallowed URI's like: > > ``` > > mailto:john@example.com > > ``` > > > > I

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/#review121967 --- Ship it! Ship It! - Vinod Kone On March 4, 2016, 12:03

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
> On March 4, 2016, 9:40 a.m., Neil Conway wrote: > > Is this patch in upstream glog? No, this is PowerPC LE porting patch, and this patch can also work on other platforms. As you can see the diff of this patch, it will not break other platforms. - Zhiwei

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 2:23 a.m.) Review request for mesos, Klaus Ma and

Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review121999 --- Ship it! Ship It! - haosdent huang On March 4, 2016, 2:33

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122003 --- src/slave/containerizer/docker.cpp (line 134)

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122011 --- src/slave/containerizer/docker.cpp (lines 136 - 137)

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122018 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:41 a.m.) Review request for mesos, Klaus Ma and

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Guangya Liu
> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` will

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Klaus Ma
> On March 4, 2016, 11:02 a.m., Klaus Ma wrote: > > src/slave/containerizer/docker.cpp, lines 136-138 > > > > > > Two comments here: > > > > 1. Error message; I'd like to say: "Failed to create docker

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create`

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review122016 --- Bad patch! Reviews applied: [44289, 44288, 44287] Failed

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Guangya Liu
> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` will

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122012 --- Ship it! Ship It! - Klaus Ma On March 4, 2016, 11:54 a.m.,

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 6:10 a.m.) Review request for mesos, Klaus Ma and

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:13 a.m.) Review request for mesos, Klaus Ma and

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:54 a.m.) Review request for mesos, Klaus Ma and

Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

2016-03-03 Thread fan du
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- Review request for mesos. Bugs: MESOS-4705

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
> On March 4, 2016, 3:02 a.m., Klaus Ma wrote: > > src/slave/containerizer/docker.cpp, lines 136-138 > > > > > > Two comments here: > > > > 1. Error message; I'd like to say: "Failed to create docker

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create`

Re: Review Request 39939: Make docker_socket option support different protocols.

2016-03-03 Thread haosdent huang
> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create`

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review122013 --- Patch looks great! Reviews applied: [44286, 44186] Passed

Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway.

Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-4807

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122030 --- I think using a `TemporaryDirectoryTest` fixture is the right

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122029 --- 3rdparty/libprocess/3rdparty/Makefile.am (line 44)

Re: Review Request 44337: Updated utils for URI constructor streaming.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/#review122031 --- src/uri/utils.cpp (line 58)

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/#review122024 --- Patch looks great! Reviews applied: [44239, 44298, 43969, 44299]

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-03 Thread Qian Zhang
> On March 4, 2016, 1:15 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 24 > > > > > > We try to avoid using this now. Let's use 'using process::XXX' > > explicitly here.

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-03 Thread Qian Zhang
> On March 4, 2016, 1:19 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 26-27 > > > > > > Depending on the comment above, please move `using std::XX` above > > `using

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

2016-03-03 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 4, 2016, 3:24 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44343: Used single space in license check error message.

2016-03-03 Thread Benjamin Bannier
> On March 3, 2016, 9:12 p.m., Till Toenshoff wrote: > > support/mesos-style.py, line 90 > > > > > > Are the two leading spaces intentional? Yes, this is intentional to be consistent with `cpplint`'s output format,

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122027 --- Ship it! Ship It! - haosdent huang On March 4, 2016, 7:27

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review121944 --- Partial review to check for non-namespace-changes:

Re: Review Request 44186: Added authentication to master endpoints.

2016-03-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 10:21 p.m.) Review request for mesos, Adam B and

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review121946 --- include/mesos/master/contender.hpp (line 43)

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review121947 --- See comments in the first review in the chain. src/Makefile.am

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121948 --- Ship it! The ReviewBot failure is unrelated (see

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 3, 2016, 5:58 p.m.) Review request for mesos, Avinash

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Alexander Rukletsov
> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2759-2770 > > > > > > Let me clarify what I meant in r/41672/. I would like to avoid the > >

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

2016-03-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/ --- (Updated March 3, 2016, 8:12 a.m.) Review request for mesos and Joris Van

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

2016-03-03 Thread Alexander Rukletsov
> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2423-2433 > > > > > > Will it be cleaner to put resources from the allocation into a hashmap > > by

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-03 Thread Qian Zhang
> On March 3, 2016, 12:24 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 81-84 > > > > > > Lets do this in a separate patch once the implementation for the > > isolator is

Review Request 44339: Disabled Appc simple fetch test.

2016-03-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44339/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

2016-03-03 Thread Benjamin Bannier
> On March 3, 2016, 4:04 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1711-1712 > > > > > > My intuition is that using `allocationScalarQuantities` will be more > >

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

2016-03-03 Thread Benjamin Bannier
> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, lines 28-30 > > > > > > I actually don't think we should wright this obvious comment here, but > > maybe there

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

2016-03-03 Thread Benjamin Bannier
> On March 3, 2016, 3:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 29 > > > > > > Maybe make it a struct? I am not sure why that would be useful; also, it is defined as a

Re: Review Request 43879: Added allocator metrics for number of allocations made.

2016-03-03 Thread Benjamin Bannier
> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, line 872 > > > > > > s/the allocator was triggered/allocation was performed. > > > > Technically, we trigger allocator when

Review Request 44326: Added missing includes in metrics.

2016-03-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44326/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Repository: mesos

  1   2   3   >