Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/ --- Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.

Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/ --- Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/ --- (Updated April 10, 2016, 6:43 a.m.) Review request for mesos, Joerg Schad,

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

> On April 10, 2016, 12:31 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43477, 43475, 43474, 43473, 43472, 43471] > > > > Failed command: ./support/apply-review.sh -n -r 43471 > > > > Error: > > 2016-04-10 12:31:44 URL:https://reviews.apache.org/r/43471/diff/raw/ > >

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

> On April 9, 2016, 12:11 a.m., Jie Yu wrote: > > Does this patch compile on its own? I'd like each patch to be 'atomic' so > > that we can commit some of them if they look good. Thanks for your review! Current patch chain are not atomic, let me change the dependencies. - haosdent

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated April 10, 2016, 2:43 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

> On April 8, 2016, 9:26 p.m., Jie Yu wrote: > > Does mesos compile after applying this patch? If not, I would rather not > > split the patch. Yes, we prefer smaller patches, but each of them should be > > an atomic change, instead of just splitting a large patch into smaller > > pieces.

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 四月 10, 2016, 1:18 p.m.) Review request for mesos, Alexander

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated April 10, 2016, 2:42 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128041 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128033 --- docs/container-image.md (lines 290 - 291)

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128036 --- Patch looks great! Reviews applied: [45898, 44090, 45888, 45940,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128043 --- Fix it, then Ship it!

Re: Review Request 45944: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45944/#review128022 --- Patch looks great! Reviews applied: [45898, 44090, 45888, 45940,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

> On April 7, 2016, 11:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 296 > > > > > > since scatch space is specific to overlay backend. I would simply pass > >

Re: Review Request 44512: Support to get weights info by /weights.

> On April 10, 2016, 12:53 a.m., Adam B wrote: > > src/master/weights_handler.cpp, line 71 > > > > > > I wonder if `jsonify(weightInfos)` would work here Nope. Nevermind. - Adam

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128027 --- src/cli/execute.cpp (line 94)

Re: Review Request 43472: Speed up ZooKeeperTest.LeaderContender by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43472/ --- (Updated April 10, 2016, 10:16 a.m.) Review request for mesos, Alexander

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/ --- (Updated April 10, 2016, 10:24 a.m.) Review request for mesos, Alexander

Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 10, 2016, 1:12 p.m.) Review request for mesos, Alexander

Re: Review Request 45203: Add authentication test for /weights GET request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45203/#review128021 --- This test looks fine, but what about testing the positive case?

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/#review128028 --- Patch looks great! Reviews applied: [45984, 45985] Passed

Review Request 45988: Fixed a typo in container-image.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45988/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated April 10, 2016, 8:09 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128026 --- Patch looks great! Reviews applied: [45953, 45954, 45955, 45956,

Re: Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43473/ --- (Updated April 10, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 43474: Speed up MasterDetectorExpireSlaveZKSession by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43474/ --- (Updated April 10, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/ --- (Updated April 10, 2016, 10:19 a.m.) Review request for mesos, Alexander

Re: Review Request 43475: Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43475/ --- (Updated April 10, 2016, 10:18 a.m.) Review request for mesos, Alexander

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review128031 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 44512: Support to get weights info by /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review128020 --- Fix it, then Ship it! Looks great! I'm testing a build now

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/#review128032 --- Bad patch! Reviews applied: [43477, 43475, 43474, 43473, 43472,

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/ --- (Updated April 10, 2016, 10:52 a.m.) Review request for mesos, Alexander

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/ --- (Updated April 10, 2016, 10:53 a.m.) Review request for mesos, Alexander

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

> On April 7, 2016, 2:13 a.m., haosdent huang wrote: > > docs/attributes-resources.md, line 40 > > > > > > `whole number values` means `natural number` here? > > Kevin Klues wrote: > Whole numbers are *almost*

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128044 --- Patch looks great! Reviews applied: [39628, 42342] Passed

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/#review128058 --- Patch looks great! Reviews applied: [45900, 45901] Passed

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 2:27 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45917/ --- (Updated April 11, 2016, 10:49 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

> On April 9, 2016, 1:59 a.m., Vinod Kone wrote: > > I think to test this you need to revert the changes made to SSL tests? > > > > Also for CMake, you can add the -D flag by adding a "add_definitions(-D > > HTTP_PARSER_STRICT=0)" to > >

Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5144

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/ --- (Updated 四月 11, 2016, 1:33 a.m.) Review request for mesos, Alexander Rukletsov

Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5144

Review Request 45996: Fixed memory leak of `gc` in `finalize()` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45996/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5144

Re: Review Request 45991: Fixed memory leak in Route::Route() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45991/ --- (Updated April 11, 2016, 1:38 a.m.) Review request for mesos and Joris Van

Re: Review Request 45863: Updated error messages in weights handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45863/#review128057 --- Fix it, then Ship it! src/master/weights_handler.cpp (line

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

> On April 9, 2016, 1:02 a.m., Jie Yu wrote: > > Intead of adding a new flag, I think we should just rely on `--isolation` > > flag. For instance, if the operator specify > > `--isolation=cgroups/cpu,cgroups/memory`, we will use the cgroup isolator > > with cgroups_subsystems: cpu and memory.

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review128061 --- 3rdparty/libprocess/src/process.cpp (lines 2167 - 2188)

Re: Review Request 45900: Removed stale contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45900/ --- (Updated April 10, 2016, 8:50 p.m.) Review request for mesos, Anurag Singh and

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 10, 2016, 8:50 p.m.) Review request for mesos and Anurag Singh.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 2:32 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45991: Fixed a memory leak in Route::Route() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45991/#review128050 --- Patch looks great! Reviews applied: [45991] Passed command:

Review Request 45991: Fixed a memory leak in Route::Route() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45991/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5144

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 11, 2016, 4:21 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/ --- (Updated April 11, 2016, 4:20 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45950: Added test for docker spec get credential helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45950/#review128042 --- src/tests/containerizer/docker_spec_tests.cpp (lines 196 - 197)

Re: Review Request 45949: Implemented docker config get credential helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review128039 --- include/mesos/docker/spec.hpp (lines 77 - 79)

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128070 --- Patch looks great! Reviews applied: [45014] Passed command:

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review128065 --- Patch looks great! Reviews applied: [41787] Passed command: