Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

> On 九月 1, 2016, 8:50 p.m., Jiang Yan Xu wrote: > > The rationale isn't clear to me: for the same test if we always parse the > > resources at the same place, isn't the measurement still accurate when you > > compare the benchmark results with vs. without certain patches or between > >

Re: Review Request 51566: Changed Master::_accept() to not pass invalid tasks to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51566/#review147604 --- Ship it! Ship It! - Anindya Sinha On Aug. 31, 2016, 10:42

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/#review147603 --- The rationale isn't clear to me: for the same test if we always

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/#review147500 --- Moved over some tests to their corresponding changes:

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review147218 --- Updated the review with the following changes. I have already

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 1, 2016, 6:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 1, 2016, 6:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/#review147594 --- Patch looks great! Reviews applied: [51566, 51553] Passed

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review147591 --- src/health-check/health_checker.cpp (lines 178 - 186)

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 26, 2016, 6:24 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 275 > > > > > > I think we should use `insert(...)` instead of `=`; if the following > > event in the queue, are

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

> On Sept. 1, 2016, 2:05 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/posix/subprocess.hpp, lines 55-68 > > > > > > Any reason you need to expose this internal method? Why not just write > > your own

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/ --- (Updated Sept. 1, 2016, 12:30 p.m.) Review request for mesos and Michael Park.

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/ --- (Updated Sept. 1, 2016, 12:49 p.m.) Review request for mesos and Michael Park.

Review Request 51571: Updated Mesos version in getting started guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51571/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51571: Updated Mesos version in getting started guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51571/#review147552 --- Patch looks great! Reviews applied: [51571] Passed command:

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147553 --- support/mesos-tidy.sh (line 22)

Review Request 51592: Added a debug logging for a CHECK failure in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51592/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6118

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

> On 九月 1, 2016, 8:50 p.m., Jiang Yan Xu wrote: > > The rationale isn't clear to me: for the same test if we always parse the > > resources at the same place, isn't the measurement still accurate when you > > compare the benchmark results with vs. without certain patches or between > >

Re: Review Request 51592: Added a debug logging for a CHECK failure in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51592/#review147623 --- Patch looks great! Reviews applied: [51592] Passed command:

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/#review147615 --- src/tests/hierarchical_allocator_tests.cpp (line 239)

Re: Review Request 51096: Added the `mesos-cni-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review147618 --- Ship it! Ship It! - Jie Yu On Aug. 30, 2016, 3:54 a.m.,

Re: Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/ --- (Updated 九月 2, 2016, 2:33 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147554 --- Patch looks great! Reviews applied: [51525] Passed command:

Re: Review Request 51571: Updated Mesos version in getting started guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51571/#review147573 --- Ship it! Ship It! - haosdent huang On Sept. 1, 2016, 9:06

Re: Review Request 51553: Changed the way `HAP::updateAllocation()` calls `Resources.apply()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51553/ --- (Updated Sept. 1, 2016, 9:35 a.m.) Review request for mesos and Anindya Sinha.

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147574 --- Ship it! Ship It! - Michael Park On Sept. 1, 2016, 3:28

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147577 --- Patch looks great! Reviews applied: [51525] Passed command:

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

> On Sept. 1, 2016, 11:29 a.m., Michael Park wrote: > > support/mesos-tidy/Dockerfile, lines 35-37 > > > > > > Can we try to get rid of this `sslVerify` stuff? It looks like we can get rid of this by installing the

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/ --- (Updated Sept. 1, 2016, 5:28 p.m.) Review request for mesos and Michael Park.

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

> On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > > support/mesos-tidy/Dockerfile, line 29 > > > > > > Can this go right after `MAINTAINER`? Sure, done. > On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > >

Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.

> On Sept. 1, 2016, 11:29 a.m., Michael Park wrote: > > support/mesos-tidy/entrypoint.sh, line 29 > > > > > > This is my bad. > > > > ``` > > - bear make tests -j $(nproc) || exit 1 > > + bear make