Re: Review Request 54133: Fixed includes in default_executor_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54133/#review158025 --- Ship it! Ship It! - Anand Mazumdar On Nov. 28, 2016, 6:32

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/#review158058 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2016, 8:44 p.m.,

Review Request 54389: Fixed typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54389/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 54177: Slightly simplified two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54177/ --- (Updated Dec. 5, 2016, 8:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/#review158056 --- Patch looks great! Reviews applied: [54381] Passed command:

Review Request 54387: Removed an inaccurate comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54387/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/ --- (Updated Dec. 5, 2016, 8:44 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 53688: Implement a namespaces/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/ --- (Updated Dec. 5, 2016, 8:44 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158050 --- src/slave/flags.cpp (lines 213 - 231)

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158038 --- src/slave/containerizer/mesos/io/switchboard.cpp (line 153)

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 9:40 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

> On Dec. 5, 2016, 6:39 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 539 > > > > > > We should not capture 'this' without a defer. Either use a 'defer' > > here, or capture

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/ --- (Updated Dec. 5, 2016, 8:44 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54311: Fixed whitespace, code style in Network::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54311/ --- (Updated Dec. 5, 2016, 5:23 p.m.) Review request for mesos and Alexander

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/#review158028 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2016, 5:29 p.m.,

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/ --- (Updated Dec. 5, 2016, 5:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/ --- (Updated Dec. 5, 2016, 5:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/ --- (Updated Dec. 5, 2016, 5:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54311: Fixed whitespace, code style in Network::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54311/#review158017 --- Ship it! 3rdparty/libprocess/include/process/address.hpp

Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- Review request for mesos. Bugs: MESOS-6677

Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- Review request for mesos and Alex Clemmer. Bugs: MESOS-6677

Re: Review Request 54134: Removed test assumptions about arrival order of status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54134/#review158024 --- Ship it! Can you also do a sweep in

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use

Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54347/#review158018 --- Ship it! src/tests/containerizer/io_switchboard_tests.cpp

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158030 --- Flying by. I am checking

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/#review158027 --- Aha, just saw this. I still suggest that we inline those methods

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/#review158022 --- Fix it, then Ship it!

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review158033 --- Fix it, then Ship it!

Re: Review Request 54015: Added V1 API protos to python bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54015/#review158014 --- Fix it, then Ship it! Sorry for the delay on this! I would fix

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158032 --- 3rdparty/stout/include/stout/posix/os.hpp (line 463)

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/#review158076 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2016, 10:14 a.m.,

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 167-171 > > > > > > I think this flag should apply to containers that are about to be > > launched next. > >

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 537-547 > > > > > > It's likely that the io switchboard server has been forked, but the > > agent crashes

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:10 a.m.) Review request for mesos and Alex Clemmer.

Review Request 54391: Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54391/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Repository: mesos

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 7:30 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 463 > > > > > > We probably want this function to return `Try`, because we > > want to be able to use `os::var`

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 537-547 > > > > > > It's likely that the io switchboard server has been forked, but the > > agent crashes

Re: Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/ --- (Updated Dec. 5, 2016, 10:06 p.m.) Review request for mesos, Andrew

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 5, 2016, 11:38 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 7:56 p.m., Alex Clemmer wrote: > > src/slave/flags.cpp, lines 213-231 > > > > > > In general, I do question whether this should be in the CLI code. It > > seems like this lambda should be wrapped

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 5, 2016, 7:56 p.m., Alex Clemmer wrote: > > src/slave/flags.cpp, lines 213-231 > > > > > > In general, I do question whether this should be in the CLI code. It > > seems like this lambda should be wrapped

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 10:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54077: Made sure parser settings member is properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54077/#review158068 --- Ship it! Ship It! - Anand Mazumdar On Nov. 25, 2016, 4:07

Re: Review Request 54391: Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54391/ --- (Updated Dec. 5, 2016, 10:18 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/#review158078 --- Patch looks great! Reviews applied: [53853] Passed command:

Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.

Re: Review Request 54359: Removed redundant empty statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54359/#review158088 --- Ship it! I think that you can removing redundant colon? -

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:39 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158097 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 147 -

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/flags.cpp, lines 214-216 > > > > > > Seems like the problem on Windows is `os::user()` rather than the value > > of the `--runtime_dir` flag. As long as

Re: Review Request 54401: Reorganized location of checkpointed files for the 'IOSwitchboard'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54401/#review158096 --- Ship it! Ship It! - Jie Yu On Dec. 6, 2016, 12:17 a.m.,

Re: Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/ --- (Updated Dec. 6, 2016, 2:01 a.m.) Review request for mesos, Andrew

Review Request 54408: Replace Master::Framework::active with a new `state` enum value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6719

Review Request 54407: Refactored Master::removeFramework to use Master::deactivate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54407/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6719

Re: Review Request 53896: Refactored representation of framework connectedness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53896/#review158105 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2016, 5:06 p.m.,

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

> On Dec. 6, 2016, 2:33 a.m., Joseph Wu wrote: > > src/slave/constants.hpp, lines 141-144 > > > > > > There isn't any need to get rid of this constant, but we could update > > the comment. > > > > i.e.

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 6, 2016, 12:27 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158089 --- src/tests/master_tests.cpp (line 4917)

Re: Review Request 54389: Fixed typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54389/#review158092 --- Ship it! Ship It! - Benjamin Mahler On Dec. 5, 2016, 9:23

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158094 --- Ship it! It is debatable that you would want to put

Re: Review Request 54389: Fixed typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54389/#review158093 --- Patch looks great! Reviews applied: [54389] Passed command:

Re: Review Request 54359: Removed redundant semicolons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54359/ --- (Updated Dec. 6, 2016, 3:05 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/ --- (Updated Dec. 6, 2016, 3:05 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54391: Added ability for client to signal EOF on ATTACH_CONTAINER_INPUT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54391/#review158118 --- Patch looks great! Reviews applied: [54391] Passed command:

Re: Review Request 54395: Enabled build of Agent test harness on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54395/ --- (Updated Dec. 6, 2016, 3:36 a.m.) Review request for mesos, Andrew

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/#review158090 --- src/tests/api_tests.cpp (lines 3728 - 3785)

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

> On Dec. 6, 2016, 2:12 a.m., Benjamin Mahler wrote: > > Is it possible to split the optional pid change from the discard logic > > change? If so that would be great! > > > > Looks like a chunk from the next patch slipped into this one? Also, would be great to update the description to say

Re: Review Request 53895: Changed the allocator API to allow adding inactive frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53895/#review158100 --- Ship it! Ship It! - Vinod Kone On Dec. 2, 2016, 9:50 p.m.,

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158103 --- src/slave/constants.hpp

Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.

> On Dec. 6, 2016, 12:52 a.m., Guangya Liu wrote: > > src/tests/master_tests.cpp, line 4957 > > > > > > When this role was added? https://github.com/apache/mesos/blob/master/src/master/http.cpp#L3254-L3268 Default

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 12:21 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:21 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 12:31 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/ --- (Updated Dec. 6, 2016, 1:06 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review158095 --- Fix it, then Ship it! Is it possible to split the optional pid

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 7124 > > > > > > CHECK_NOTNULL(framework); > > Neil Conway wrote: > Is there a general rule for when to add `CHECK_NOTNULL` for

Re: Review Request 54381: Adds authorization support when attaching containers input/output.

> On Dec. 6, 2016, 1:55 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 3728-3793 > > > > > > why did you change these tests? the idea with the tests was to verify > > that `Containerizer::attach()` was

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 4:55 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158121 --- Fix it, then Ship it!

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158122 --- Patch looks great! Reviews applied: [54335] Passed command:

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/#review158127 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 599 -

Re: Review Request 53853: Expanded the comment around `ContainerInfo` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53853/#review158120 --- Ship it! Ship It! - Gilbert Song On Dec. 5, 2016, 9:08

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/#review157977 --- Patch looks great! Reviews applied: [54359, 54360, 54361, 54362,

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/ --- (Updated Dec. 5, 2016, 11:14 a.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54367/#review157983 --- Patch looks great! Reviews applied: [54344, 54347, 54297, 54348,

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/ --- (Updated Dec. 5, 2016, 8:48 a.m.) Review request for mesos, Benjamin Mahler

Review Request 54365: Fixed indentation of a function argument in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54365/ --- Review request for mesos, Benjamin Mahler and Guangya Liu. Repository: mesos

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

> On Nov. 29, 2016, 4:08 p.m., Neil Conway wrote: > > I'd still like to see more discussion of how someone might actually use > > this feature. For example, when you say "With these constraints operators > > can use a > > global hard limit to contain resource limits set by users" -- how would

Re: Review Request 54291: Added os::ptsname to stout.

> On Dec. 2, 2016, 10:16 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 480 > > > > > > We should be able to use a simple function-local static here and avoid > > the global leak

Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54356/ --- (Updated Dec. 5, 2016, 8:54 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/ --- (Updated Dec. 5, 2016, 10:37 a.m.) Review request for mesos, Jie Yu and Neil

Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54367/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6718

Re: Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54367/ --- (Updated Dec. 5, 2016, 9:44 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 9:46 a.m.) Review request for mesos and Jie Yu.

Review Request 54368: Added helpers to checkpoint a 'destroy-on-recovery' file for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54368/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6718

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/#review157991 --- Patch looks great! Reviews applied: [53982] Passed command:

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

> On Nov. 29, 2016, 3:08 p.m., Neil Conway wrote: > > I'd still like to see more discussion of how someone might actually use > > this feature. For example, when you say "With these constraints operators > > can use a > > global hard limit to contain resource limits set by users" -- how would

Review Request 54380: Don't send PIDs of disconnected frameworks to re-registering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54380/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 54177: Slightly simplified two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54177/ --- (Updated Dec. 5, 2016, 4:12 p.m.) Review request for mesos and Vinod Kone.

  1   2   >