Re: Review Request 57425: Added pull method to Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57425/ --- (Updated March 15, 2017, 10:41 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56213: Added check tests for command executor.

> On March 14, 2017, 6:24 p.m., Andrew Schwartzmeyer wrote: > > src/tests/check_tests.cpp > > Lines 74 (patched) > > > > > > As the resident PowerShell "expert" (heh!), I tested this (and the > > second one) and

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review168974 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:05

Re: Review Request 57594: Added a helper for building a task status from scratch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57594/#review168973 --- Fix it, then Ship it! src/common/protobuf_utils.hpp Lines

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review168982 --- Per design doc, we always associate framework to a virtual role.

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/#review168976 --- src/launcher/executor.cpp Line 383 (original), 383 (patched)

Re: Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/#review168986 --- src/webui/master/static/roles.html Lines 30-31 (patched)

Re: Review Request 56212: Added support for general checks to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/#review168977 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:09

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/#review168978 --- src/checks/checker.cpp Lines 436-438 (patched)

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review168984 --- src/master/allocator/sorter/drf/sorter.cpp Line 72 (original),

Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57427/ --- (Updated March 15, 2017, 10:42 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57426/ --- (Updated March 15, 2017, 10:41 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 57150: Simplified task id procurement in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57150/ --- (Updated March 15, 2017, 12:49 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/#review169000 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 12:51

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review169006 --- Fix it, then Ship it! src/tests/http_authentication_tests.cpp

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 15, 2017, 12:46 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56211: Renamed health checker in command executor for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56211/ --- (Updated March 15, 2017, 12:47 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57149: Added a warning if command executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57149/ --- (Updated March 15, 2017, 12:46 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56210: Reused previous task status for health updates in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56210/ --- (Updated March 15, 2017, 12:47 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56017: Added a helper for building a task status from an existing one.

> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/ --- (Updated March 15, 2017, 12:48 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/#review168997 --- Ship it! Ship It! - Gastón Kleiman On March 15, 2017, 12:44

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/ --- (Updated March 15, 2017, 12:44 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57394: Overloaded `<<` for `CheckInfo::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57394/#review168998 --- Ship it! Ship It! - Gastón Kleiman On March 15, 2017, 12:44

Re: Review Request 56017: Added a helper for building a task status from an existing one.

> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/#review169003 --- Fix it, then Ship it! src/launcher/executor.cpp Line 361

Re: Review Request 56017: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated March 15, 2017, 12:44 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57394: Overloaded `<<` for `CheckInfo::Type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57394/ --- (Updated March 15, 2017, 12:44 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57594: Added a helper for building a task status from scratch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57594/ --- (Updated March 15, 2017, 12:45 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56017: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review168999 --- src/common/protobuf_utils.hpp Lines 96 (patched)

Re: Review Request 56212: Added support for general checks to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/ --- (Updated March 15, 2017, 12:51 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/ --- (Updated March 15, 2017, 12:51 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57598/ --- (Updated March 15, 2017, 12:51 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review168905 --- src/authentication/http/combined_authenticator.cpp Lines 146

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/#review169005 --- Fix it, then Ship it! src/common/http.cpp Line 964

Review Request 57663: Updated documentation for multiple HTTP authenticators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57663/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-7004

Re: Review Request 57666: Added agent flag to enable executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/ --- (Updated March 15, 2017, 11:35 p.m.) Review request for mesos, Jan Schlicht

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/ --- (Updated March 16, 2017, 3:02 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated March 16, 2017, 5:24 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 56016: Added a note about task status updates in scheduler and internal API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/#review168972 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:05

Re: Review Request 57149: Added a warning if command executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57149/#review168975 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:06

Re: Review Request 57598: Added comment regarding exit status on Windows vs. Posix in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57598/#review168979 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:09

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

> On March 15, 2017, 9:51 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp > > Lines 886 (patched) > > > > > > Add a comment to signify what this boolean captures. Hmmm, I thought I could spare a comment since

Re: Review Request 57597: Added comments regarding exit status on Windows vs. Posix.

> On March 15, 2017, 10:04 a.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Lines 436-438 (patched) > > > > > > Why is this comment here and not in the CheckInfo proto like you did > > with Executor Failure?

Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/ --- (Updated March 15, 2017, 2:58 p.m.) Review request for mesos, Alexander

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp > > Lines 617 (patched) > > > > > > do you want to add a TODO here to not re-use the ContainerID? > > Gastón Kleiman wrote: >

Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-7248

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated March 15, 2017, 3:05 p.m.) Review request for mesos, Alexander

Re: Review Request 57624: Modified an erroneous comment in the Master API proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57624/#review169021 --- Ship it! Ship It! - Zhitao Li On March 14, 2017, 10:27

Re: Review Request 57631: Augmented a test to check protobuf::stripAllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57631/#review169014 --- Patch looks great! Reviews applied: [57340, 57630, 57631]

Review Request 57664: Added the '--executor_secret_key' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57664/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-7011

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review169089 --- Fix it, then Ship it!

Re: Review Request 57358: Implemented discard behavior in process::Queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review169065 --- Can you split the change to add discard semantics to queue? That

Review Request 57671: Allowed the agent to require executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57671/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6998

Re: Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/ --- (Updated March 15, 2017, 11:39 p.m.) Review request for mesos, Jan Schlicht

Review Request 57665: Renamed a constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57665/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6998

Re: Review Request 57666: Added the '--authenticate_http_executors' agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/ --- (Updated March 15, 2017, 11:40 p.m.) Review request for mesos, Jan Schlicht

Review Request 57670: Enabled authentication on the V1 executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57670/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6998

Review Request 57666: Added agent flag to enable executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6998

Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6998

Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57427/#review169074 --- Patch looks great! Reviews applied: [57425, 57426, 57427]

Re: Review Request 57666: Added agent flag to enable executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/ --- (Updated March 15, 2017, 11:25 p.m.) Review request for mesos, Jan Schlicht

Re: Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57648/#review169025 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 4:22

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/#review169026 --- src/slave/containerizer/composing.cpp Lines 499-502 (original),

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/#review169023 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/ --- (Updated March 15, 2017, 4:18 p.m.) Review request for mesos, Alexander

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169029 --- Ship it! Ship It! - Anindya Sinha On March 15, 2017, 12:40

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review169030 --- Ship it! Ship It! - Anindya Sinha On March 15, 2017, 1:09

Re: Review Request 57647: Made CMD health checks not reuse the check `ContainerID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57647/#review169032 --- Patch looks great! Reviews applied: [57644, 56288, 55901, 57645,

Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/ --- (Updated March 15, 2017, 4:22 p.m.) Review request for mesos, Alexander

Review Request 57651: Update http authenticator tests to work with any http response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57651/ --- Review request for mesos. Repository: mesos Description --- Update http

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/ --- (Updated March 15, 2017, 4:54 p.m.) Review request for mesos, Alexander

Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57648/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-7248

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

> On March 15, 2017, 10:16 a.m., Jay Guo wrote: > > Per design doc, we always associate framework to a virtual role. In this > > implementation, however, virtual role is created ONLY when the leaf node is > > turned into internal node. Could you clarify a bit? Nothing has changed conceptually

Review Request 57652: Allow authenticators to return any http Response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57652/ --- Review request for mesos. Bugs: MESOS-7247

Re: Review Request 57651: Update http authenticator tests to work with any http response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57651/ --- (Updated March 15, 2017, 4:47 p.m.) Review request for mesos. Bugs:

Re: Review Request 57615: Added support for auth tokens to the V1 executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/ --- (Updated March 15, 2017, 10:09 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56681: Use glog to log EXIT() messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56681/#review169061 --- LGTM. So in a couple of main.cpp files, this is used prior to

Review Request 57645: Added support for pausing health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57645/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang,

Review Request 57647: Made CMD health checks not reuse the check `ContainerID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57647/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang,

Review Request 57646: Made COMMAND health checks resilient to agent failovers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57646/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang,

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review169040 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 6:20

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 15, 2017, 6:17 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

> On March 15, 2017, 1:50 p.m., Vinod Kone wrote: > > include/mesos/authentication/http/combined_authenticator.hpp > > Lines 123-130 (patched) > > > > > > why do we need the `overrides`? do we expect devs to

Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56476/ --- (Updated March 15, 2017, 6:18 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/ --- (Updated March 15, 2017, 6:20 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 57358: Implemented discard behavior in process::Queue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/ --- (Updated March 15, 2017, 11:01 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 57652: Allow authenticators to return any http Response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57652/#review169036 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 15, 2017, 6:49 p.m.) Review request for mesos, Benjamin

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

> On March 15, 2017, 10:16 a.m., Jay Guo wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 101 (patched) > > > > > > It would be nice to add some comments here to help reader understand > > that we

Re: Review Request 56474: Added the 'CombinedAuthenticator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review169039 --- Ship it! Ship It! - Vinod Kone On March 15, 2017, 6:17

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55896/#review169038 --- Fix it, then Ship it!

Re: Review Request 57648: Improved failure message in `MesosContainerizer::remove()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57648/ --- (Updated March 15, 2017, 8:15 p.m.) Review request for mesos, Alexander

Re: Review Request 57644: Implemented 'ComposingContainerizer::remove(const ContainerID&)'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57644/#review169053 --- Ship it! Ship It! - Alexander Rukletsov On March 15, 2017,

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review169049 --- Ship it! Ship It! - Jiang Yan Xu On March 2, 2017, 10:07

Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/ --- (Updated March 15, 2017, 8:48 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56212: Added support for general checks to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/ --- (Updated March 15, 2017, 8:49 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57622: Introduced a Roles tab in the webui.

> On March 15, 2017, 10:44 a.m., Jay Guo wrote: > > src/webui/master/static/roles.html > > Lines 30-31 (patched) > > > > > > ``` > > {{role.resources.mem * (1024 * 1024) | dataSize}} > >

Re: Review Request 57622: Introduced a Roles tab in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57622/ --- (Updated March 15, 2017, 9:03 p.m.) Review request for mesos, Jay Guo, Michael

Re: Review Request 56017: Added a helper for building a task status from an existing one.

> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by

  1   2   >