Re: Review Request 63058: Changed failure response of LAUNCH containers API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63058/ --- (Updated Nov. 2, 2017, 9:01 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60888: Added recovery logic for standalone containers.

> On Oct. 17, 2017, 10:39 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Line 757 (original), 758 (patched) > > > > > > not yours, can you add a comment here saying that parent

Re: Review Request 60889: Added basic tests for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60889/ --- (Updated Nov. 2, 2017, 8:45 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60888: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/ --- (Updated Nov. 2, 2017, 8:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60890: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/ --- (Updated Nov. 2, 2017, 8:50 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60890: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review189922 --- include/mesos/agent/agent.proto Lines 253-255 (patched)

Re: Review Request 63063: Modified Containerizer::launch interface to allow repeated launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63063/ --- (Updated Nov. 2, 2017, 9:02 a.m.) Review request for mesos, Gilbert Song and

Review Request 63514: Updated tests with Containerizer::launch interface change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63514/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305

Re: Review Request 62145: Implemented Standalone Container API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62145/ --- (Updated Nov. 2, 2017, 8:57 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63056: Parameterized test for nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63056/ --- (Updated Nov. 2, 2017, 9 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 63057: Moved and refactored some nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63057/ --- (Updated Nov. 2, 2017, 9 a.m.) Review request for mesos, Gilbert Song and Jie

Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63515/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/ --- (Updated Nov. 2, 2017, 6:48 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/ --- (Updated Nov. 2, 2017, 6:48 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63493: Transmitted agent resource versions in (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63493/ --- (Updated Nov. 2, 2017, 6:48 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189939 --- src/tests/default_executor_tests.cpp Lines 1413-1414 (patched)

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189946 --- include/mesos/mesos.proto Lines 512-516 (patched)

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update

Re: Review Request 63023: WIP: Added a test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63023/#review189943 --- src/examples/test_csi_plugin.cpp Lines 664 (patched)

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 512-516 (patched) > > > > > > When I see this enum, I have several questions, for example, "how this > > fits into

Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63522/ --- Review request for mesos. Repository: mesos Description --- Removed

Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63520/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 2, 2017, 6:47 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63515/#review189938 --- FAIL: Mesos tests failed to build. Reviews applied: `['60888',

Re: Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63511/#review189949 --- Bad patch! Reviews applied: [63511, 63485, 63484, 63483, 63482,

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63476/#review189885 --- Patch looks great! Reviews applied: [63476] Passed command:

Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman,

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63522/ --- (Updated Nov. 2, 2017, 12:36 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review189952 --- FAIL: Mesos tests failed to build. Reviews applied: `['63519',

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/ --- (Updated Nov. 2, 2017, 12:51 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63422: Updated os::unsetenv to clear the old environment value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63422/#review189954 --- 3rdparty/stout/include/stout/posix/os.hpp Lines 175 (patched)

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189962 --- 3rdparty/stout/include/stout/windows/os.hpp Line 669 (original),

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189963 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:39 p.m.,

Re: Review Request 63422: Updated os::unsetenv to clear the old environment value.

> On Nov. 2, 2017, 8:23 p.m., Greg Mann wrote: > > 3rdparty/stout/include/stout/posix/os.hpp > > Lines 175 (patched) > > > > > > I'm curious: is there a reason you use `memset()` instead of `setenv()` > > here?

Re: Review Request 63273: Windows: Added `os::get_job_processes` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/#review189966 --- 3rdparty/stout/include/stout/windows/os.hpp Lines 793 (patched)

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63520/#review189968 --- FAIL: Mesos tests failed to build. Reviews applied: `['62844',

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/#review189969 --- FAIL: Failed to apply the dependent review: 59988. Failed

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review189971 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:40 p.m.,

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189972 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:40 p.m.,

Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8165

Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63526/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8165

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- (Updated Nov. 2, 2017, 12:52 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 63529: Added missing lock free event queue and LIFO CMake options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63529/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189982 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 2, 2017,

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63522/#review189986 --- FAIL: Mesos tests failed to build. Reviews applied: `['63522']`

Re: Review Request 63279: Increased check tests task resources for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review189987 --- FAIL: Failed to apply the dependent review: 63275. Failed

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

> On Nov. 2, 2017, 4:48 p.m., Benjamin Mahler wrote: > > docs/isolators/windows.md > > Lines 8 (patched) > > > > > > Hm.. why is it called cpuset? That word comes from the cgroup subsystem > > that lets you restrict

Re: Review Request 63499: Fixed the unit test that broke Windows build.

> On Nov. 3, 2017, 1:57 a.m., Andrew Schwartzmeyer wrote: > > src/tests/default_executor_tests.cpp > > Lines 1413-1414 (patched) > > > > > > Re: Alex's comment above: > > > > > MESOS-6698 is resolved. We

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/ --- (Updated Nov. 3, 2017, 12:38 a.m.) Review request for mesos, Alexander

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63520/#review189976 --- Fix it, then Ship it! support/mesos-tidy/entrypoint.sh Lines

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189978 --- Ship it! Are you able to also upload some flame graphs to

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review189992 --- docs/isolators/windows.md Lines 8 (patched)

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/ --- (Updated Nov. 3, 2017, 7:54 a.m.) Review request for mesos, Alexander

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

> On Nov. 2, 2017, 1:51 p.m., Aaron Wood wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Line 669 (original), 670 (patched) > > > > > > How about doing `if (job_handle.get_handle()) {` instead? Loosely,

Re: Review Request 63353: Don't clear the executor ID of executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189974 --- Ship it! How about the following? ``` Fixed an issue where

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189980 --- Patch looks great! Reviews applied: [63499] Passed command:

Re: Review Request 63529: Added missing lock free event queue and LIFO CMake options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63529/#review189981 --- Ship it! Ship It! - Michael Park On Nov. 2, 2017, 3:54

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63520/ --- (Updated Nov. 2, 2017, 4:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189997 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 2, 2017,

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/#review189975 --- Fix it, then Ship it! Would be great to have some better

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review189977 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63497/#review189888 --- FAIL: Mesos tests failed to build. Reviews applied: `['63497']`

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63497/ --- (Updated Nov. 2, 2017, 4:12 p.m.) Review request for mesos, Alexander

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189892 --- Patch looks great! Reviews applied: [63174] Passed command:

Re: Review Request 63501: Initial `3rdparty/README.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63501/#review189898 --- FAIL: Mesos tests failed to build. Reviews applied: `['63501']`

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/ --- (Updated Nov. 2, 2017, 4:21 p.m.) Review request for mesos, Andrew

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/ --- (Updated Nov. 2, 2017, 12:44 a.m.) Review request for mesos and Benjamin

Review Request 63501: Initial `3rdparty/README.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63501/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/#review190003 --- Bad patch! Reviews applied: [63523, 63511, 63485, 63484, 63483,

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/#review190002 --- FAIL: Failed to apply the dependent review: 63353. Failed

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/#review190001 --- FAIL: Mesos tests failed to build. Reviews applied: `['63526',

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/ --- (Updated Nov. 2, 2017, 12:45 a.m.) Review request for mesos and Benjamin

Re: Review Request 63499: Fixed the unit test that broke Windows build.

> On Nov. 2, 2017, 1:51 p.m., Andrew Schwartzmeyer wrote: > > Who is hausdorff and why is this their TODO? hausdorff is Alex Clemmer's Github account, I think he was working on Windows porting. Actually I found this comment

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 11 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update

Re: Review Request 63463: Added support for credential secret to test-http-framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63463/#review189899 --- Ship it! Ship It! - Armand Grillet On Nov. 1, 2017, 2:39

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63497/#review189901 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 2, 2017,

Re: Review Request 63499: Fixed the unit test that broke Windows build.

> On Nov. 2, 2017, 5:51 a.m., Andrew Schwartzmeyer wrote: > > Who is hausdorff and why is this their TODO? > > Qian Zhang wrote: > hausdorff is Alex Clemmer's Github account, I think he was working on > Windows porting. Actually I found this comment >

Re: Review Request 63499: Fixed the unit test that broke Windows build.

> On Nov. 2, 2017, 11:23 a.m., Alexander Rukletsov wrote: > > src/tests/default_executor_tests.cpp > > Lines 1413-1416 (original), 1413-1419 (patched) > > > > > > Pease use `TEST_P_TEMP_DISABLED_ON_WINDOWS` instead

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189904 --- PASS: Mesos patch 63499 was successfully built and tested.

Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189900 --- src/tests/default_executor_tests.cpp Lines 1413-1416 (original),

Re: Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63511/#review189914 --- FAIL: Failed to apply the dependent review: 59988. Failed

Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63511/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman,

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

> On Nov. 2, 2017, 6:14 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos tests failed to build. > > > > Reviews applied: `['63526', '63527']` > > > > Failed command: `cmake.exe --build . --target mesos-tests --config Debug` > > > > All the build artifacts available at: > >

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/#review190007 --- Bad patch! Reviews applied: [63474, 63353] Failed command:

Re: Review Request 63389: WIP: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/ --- (Updated Nov. 3, 2017, 3:28 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63522/#review190005 --- Patch looks great! Reviews applied: [63522] Passed command:

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190004 --- PASS: Mesos patch 63434 was successfully built and tested.