Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/#review190019 --- Patch looks great! Reviews applied: [63526, 63527] Passed

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 63540: Added flag protobuf message for agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63540/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 63538: Moved expectation for scheduler subscription events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8093

Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63493: Transmitted agent resource versions in (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63493/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 63538: Moved expectation for scheduler subscription events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/#review190037 --- PASS: Mesos patch 63538 was successfully built and tested.

Re: Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63526/ --- (Updated Nov. 3, 2017, 10:09 a.m.) Review request for mesos and Vinod Kone.

Review Request 63543: Added bintray publishing scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/ --- Review request for mesos, James Peach and Till Toenshoff. Bugs: MESOS-7985

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/ --- (Updated Nov. 3, 2017, 5:06 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review190046 --- PASS: Mesos patch 63496 was successfully built and tested.

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Nov. 3, 2017, 6:29 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 56-57 (patched) > > > > > > The general pattern is to just include the reason for an error, and

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Nov. 3, 2017, 11:29 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 56-57 (patched) > > > > > > The general pattern is to just include the reason for an error, and

Re: Review Request 63540: Added flag protobuf message for agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63540/#review190042 --- Ship it! Ship It! - Jie Yu On Nov. 3, 2017, 3:21 p.m.,

Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63519/#review190044 --- src/slave/slave.hpp Lines 574 (patched)

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- (Updated Nov. 3, 2017, 11:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

> On Nov. 3, 2017, 11:29 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > > Lines 56-57 (patched) > > > > > > The general pattern is to just include the reason for an error, and

Re: Review Request 63538: Moved expectation for scheduler subscription events in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63538/#review190054 --- Patch looks great! Reviews applied: [63538] Passed command:

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review190043 --- 3rdparty/stout/include/stout/os/windows/copyfile.hpp Lines 56-57

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ --- (Updated Nov. 3, 2017, 10:39 a.m.) Review request for mesos, Jeff Coffler,

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review190047 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1386

Re: Review Request 63400: Fix bad links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review190075 --- Ship it! Ship It! - Vinod Kone On Oct. 30, 2017, 2:48 p.m.,

Re: Review Request 63400: Fix bad links.

> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > site/source/blog/2014-03-28-mesos-community-update-1.md > > Line 31 (original), 31 (patched) > > > > > > The `[lacking a while]` link is missing the

Re: Review Request 63423: Cleared the executor auth token after using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/#review190076 --- src/launcher/default_executor.cpp Lines 1604 (patched)

Review Request 63550: Included commit message in `push-commits.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63550/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 4, 2017, 12:51 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Nov. 4, 2017, 12:52 a.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63023: Added a test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63023/ --- (Updated Nov. 4, 2017, 1:09 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/ --- (Updated Nov. 4, 2017, 1:23 a.m.) Review request for mesos, James DeFelice,

Review Request 63554: WIP: Added a publish function in resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63554/ --- Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht. Bugs:

Review Request 63555: Publish resource provider resources before container launch or update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/ --- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.

Review Request 63556: Added a test to check volume publish before running tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63556/ --- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.

Re: Review Request 63543: Added bintray publishing scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190085 --- Patch looks great! Reviews applied: [63543] Passed command:

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/#review190081 --- PASS: Mesos patch 63527 was successfully built and tested.

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/ --- (Updated Nov. 4, 2017, 12:49 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 63377: Added filesystem layout for storage resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/ --- (Updated Nov. 4, 2017, 12:58 a.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63021: Added functions to launch CSI plugin in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63021/ --- (Updated Nov. 4, 2017, 1:06 a.m.) Review request for mesos, James DeFelice,

Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63498/ --- Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht.

Re: Review Request 63550: Included commit message in `push-commits.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63550/ --- (Updated Nov. 4, 2017, 12:40 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Nov. 4, 2017, 1:17 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63390: Create/destroy volume test for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- (Updated Nov. 4, 2017, 1:40 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 63550: Included commit message in `push-commits.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63550/#review190083 --- Fix it, then Ship it! support/push-commits.py Lines 48-55

Re: Review Request 63543: Added bintray publishing scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190062 --- PASS: Mesos patch 63543 was successfully built and tested.

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/#review190072 --- Fix it, then Ship it! CHANGELOG Lines 13 (patched)

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/#review190074 --- src/slave/slave.cpp Lines 4996-5001 (patched)

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review190064 --- src/resource_provider/message.hpp Lines 42 (patched)

Re: Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63526/#review190070 --- Ship it! Ship It! - Vinod Kone On Nov. 3, 2017, 5:09 p.m.,

Re: Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/#review190071 --- Patch looks great! Reviews applied: [63340, 63341, 63342]

Re: Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/#review190066 --- FAIL: Mesos tests failed to build. Reviews applied: `['63340',

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63527/ --- (Updated Nov. 3, 2017, 3:09 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 63550: Included commit message in `push-commits.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63550/#review190086 --- PASS: Mesos patch 63550 was successfully built and tested.

Re: Review Request 63556: Added a test to check volume publish before running tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63556/#review190087 --- FAIL: Failed to apply the dependent review: 63021. Failed

Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/#review190079 --- src/slave/slave.cpp Lines 6743-6747 (patched)

Re: Review Request 63493: Transmitted agent resource versions in (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63493/#review190088 --- Ship it! Ship It! - Greg Mann On Nov. 3, 2017, 3:21 p.m.,

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/#review190090 --- Patch looks great! Reviews applied: [61128] Passed command:

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190011 --- Patch looks great! Reviews applied: [63434] Passed command: