Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62444/ --- (Updated Jan. 17, 2018, 4:07 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65190: Updated comments in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65190/#review195607 --- PASS: Mesos patch 65190 was successfully built and tested.

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65122/#review195606 --- Follow up review: https://reviews.apache.org/r/65190/ -

Re: Review Request 65190: Updated comments in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65190/#review195610 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 17, 2018,

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65122/#review195611 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 17, 2018,

Re: Review Request 65190: Updated comments in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65190/#review195612 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 17, 2018,

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65122/ --- (Updated Jan. 17, 2018, 2:14 p.m.) Review request for mesos, Alexander

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65122/#review195579 --- PASS: Mesos patch 65122 was successfully built and tested.

Re: Review Request 65179: Fixed flaky EOFBeforeRecv test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65179/#review195614 --- Ship it! Many thanks for this fix, Andrei!! - Greg Mann On

Re: Review Request 65126: Added a resource provider test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/#review195581 --- PASS: Mesos patch 65126 was successfully built and tested.

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/#review195592 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 2144-2145

Re: Review Request 62447: Reverted usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review195613 --- FAIL: Failed to apply the dependent review: 62161. Failed

Re: Review Request 62447: Reverted usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62447/ --- (Updated Jan. 17, 2018, 4:10 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65122: Fixed race condition in io switchboard for ATTACH_CONTAINER_INPUT call.

> On Jan. 16, 2018, 7:21 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 1223 (patched) > > > > > > If I understand this correctly, this is solving for the case where we > >

Review Request 65190: Updated comments in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65190/ --- Review request for mesos, Alexander Rukletsov and Kevin Klues. Bugs:

Re: Review Request 62445: Removed duplicate block in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62445/ --- (Updated Jan. 17, 2018, 4:10 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review195562 --- PASS: Mesos patch 65189 was successfully built and tested.

Re: Review Request 62161: Updated boost version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62161/ --- (Updated Jan. 17, 2018, 4:09 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65190: Updated comments in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65190/ --- (Updated Jan. 17, 2018, 4:11 p.m.) Review request for mesos, Alexander

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/ --- (Updated Jan. 17, 2018, 4:29 p.m.) Review request for mesos and Alexander

Re: Review Request 63661: Updated tests to use `createCallSubscribe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63661/#review195626 --- PASS: Mesos patch 63661 was successfully built and tested.

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review195636 --- Fix it, then Ship it! src/docker/docker.cpp Lines 752

Re: Review Request 65059: Speeded up SLRP unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65059/#review195639 --- src/tests/storage_local_resource_provider_tests.cpp Line 604

Re: Review Request 63829: Modified Containerizer::remove to allow top-level containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63829/ --- (Updated Jan. 17, 2018, 11:24 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review195637 --- Ship it! Ship It! - Joseph Wu On Jan. 16, 2018, 8:54 a.m.,

Re: Review Request 65090: Added specific flag loader for zookeeper urls preventing password leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/#review195629 --- include/mesos/zookeeper/url.hpp Lines 32-36 (patched)

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195631 --- Fix it, then Ship it!

Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63848/ --- (Updated Jan. 17, 2018, 11:21 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63828: Added authorization tests for standalone container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/ --- (Updated Jan. 17, 2018, 11:21 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review195638 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 12, 2018,

Re: Review Request 64848: Updated example frameworks to make use of added flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64848/ --- (Updated Jan. 17, 2018, 6:59 p.m.) Review request for mesos, Alexander

Re: Review Request 64848: Updated example frameworks to make use of added flags.

> On Jan. 16, 2018, 11:19 p.m., Vinod Kone wrote: > > src/examples/test_http_framework.cpp > > Lines 399-401 (original), 401-403 (patched) > > > > > > hmm. this seems incorrect? how did this compile!? Dang - that

Re: Review Request 64849: Added authentication to some example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/ --- (Updated Jan. 17, 2018, 7:01 p.m.) Review request for mesos, Alexander

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 139-153 (patched) > > > > > > Again, this is something we should likely do in a broader scope. > >

Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65000/#review195635 --- src/tests/storage_local_resource_provider_tests.cpp Lines 981

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/ --- (Updated Jan. 17, 2018, 9:42 p.m.) Review request for mesos, Andrew

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

> On Jan. 17, 2018, 7:58 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91-93 (patched) > > > > > > We don't want to build this executable by default, so drop a > >

Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63848/#review195644 --- PASS: Mesos patch 63848 was successfully built and tested.

Re: Review Request 63828: Added authorization tests for standalone container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/#review195645 --- PASS: Mesos patch 63828 was successfully built and tested.

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 17, 2018, 8:44 p.m.) Review request for mesos, Alexander

Re: Review Request 63829: Modified Containerizer::remove to allow top-level containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63829/#review195648 --- PASS: Mesos patch 63829 was successfully built and tested.

Re: Review Request 65044: Added the list of operations to the 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195544 --- It seems to make sense to add this information to the agent API

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review195539 --- src/tests/storage_local_resource_provider_tests.cpp Lines

Re: Review Request 64857: Updated example frameworks for mesos-local.

> On Jan. 16, 2018, 11:52 p.m., Vinod Kone wrote: > > src/examples/dynamic_reservation_framework.cpp > > Lines 389 (patched) > > > > > > don't you need to set roles in other example frameworks too for the > > local

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/ --- (Updated Jan. 17, 2018, 4:16 p.m.) Review request for mesos, Andrei Budnik,

Review Request 65195: Windows: Fixed `fs::list` to return full paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65195/ --- Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu. Bugs:

Review Request 65196: Removed workaround in ZooKeeper test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65196/ --- Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu. Bugs:

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Jan. 17, 2018, 10:05 p.m.) Review request for mesos, Benjamin

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

> On Jan. 17, 2018, 2:12 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 98-101 (patched) > > > > > > Would you rather it be part of the `tests` target explicitly? You

Review Request 65197: Updated Gaston Kleiman's entry in contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 65196: Removed workaround in ZooKeeper test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65196/#review195661 --- PASS: Mesos patch 65196 was successfully built and tested.

Re: Review Request 64857: Updated example frameworks for mesos-local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/ --- (Updated Jan. 17, 2018, 11:37 p.m.) Review request for mesos, Alexander

Re: Review Request 64849: Added authentication to some example frameworks.

> On Jan. 16, 2018, 11:48 p.m., Vinod Kone wrote: > > src/examples/dynamic_reservation_framework.cpp > > Line 41 (original) > > > > > > Any particular reason you deleted these? Improving consistency as that is the

Re: Review Request 65200: Added a default move constructor for Result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65200/#review195663 --- Ship it! Ship It! - Michael Park On Jan. 17, 2018, 3:30

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195669 --- PASS: Mesos patch 65182 was successfully built and tested.

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195654 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 17, 2018,

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195653 --- PASS: Mesos patch 65166 was successfully built and tested.

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

> On Jan. 17, 2018, 8:44 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1652 (patched) > > > > > > Did you make sure that the ordering `updateSlave2` will always be

Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Bugs:

Review Request 65201: Added a global DEFAULT_TEST_TIMEOUT variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Bugs:

Re: Review Request 65197: Updated Gaston Kleiman's entry in contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195667 --- PASS: Mesos patch 65197 was successfully built and tested.

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195651 --- 3rdparty/libprocess/src/tests/CMakeLists.txt Lines 98-101

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review195658 --- PASS: Mesos patch 65039 was successfully built and tested.

Review Request 65200: Added a default move constructor for Result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65200/ --- Review request for mesos and Michael Park. Bugs: MESOS-2921

Re: Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/#review195558 --- PASS: Mesos patch 65180 was successfully built and tested.

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review195559 --- FAIL: Some Mesos tests failed. Reviews applied: `['63859',

Re: Review Request 65125: Added a helper function for resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65125/ --- (Updated Jan. 17, 2018, 2:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 62900: Enabled protobuf arenas code generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62900/#review195693 --- Do we need corresponding changes on v1/***.proto? - Gilbert Song

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195670 --- Ship it! Hum... so of those email addresses are unfortunate...

Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/ --- Review request for mesos, Adam B, Anand Mazumdar, Andrew Schwartzmeyer,

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195672 --- Fix it, then Ship it! LGTM CHANGELOG Line 21 (original), 21

Re: Review Request 65197: Added some missing email addresses to the contributors list.

> On Jan. 17, 2018, 4:23 p.m., Joseph Wu wrote: > > Hum... so of those email addresses are unfortunate... I suppose it's up to > > Andrei and Armand if they want to have those listed. > > > > Everything else looks good though. Yeah, I am not very sure about those temporary email addreses. I

Review Request 65204: Eliminated some unnecessary copying in the agent's HTTP operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65204/ --- Review request for mesos, Michael Park and Meng Zhu. Bugs: MESOS-8455

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Jan. 18, 2018, 4:25 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On Jan. 5, 2018, 3:23 p.m., Armand Grillet wrote: > > src/python/cli_new/bootstrap > > Lines 72 (patched) > > > > > > This file does not exist, is that normal? it should... ``` ~/mesos/src/python/lib$ git blame

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195690 --- PASS: Mesos patch 61172 was successfully built and tested.

Re: Review Request 65179: Fixed flaky EOFBeforeRecv test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65179/#review195618 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 16, 2018,

Re: Review Request 65197: Added some missing email addresses to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65197/#review195679 --- PASS: Mesos patch 65197 was successfully built and tested.

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Jan. 18, 2018, 1:57 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

> On Jan. 17, 2018, 8:44 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1656 (patched) > > > > > > Would it make sense to have the whole test run with paused clock?

Re: Review Request 64857: Updated example frameworks for mesos-local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/#review195681 --- PASS: Mesos patch 64857 was successfully built and tested.

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

> On Jan. 17, 2018, 2:34 a.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1552-1559 (patched) > > > > > > Could this be racy? Since we're not awaiting on the

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195684 --- PASS: Mesos patch 65203 was successfully built and tested.

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195673 --- lgtm CHANGELOG Lines 134 (patched)

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195671 --- Fix it, then Ship it! CHANGELOG Line 14 (original), 14

Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review195675 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

> On Jan. 17, 2018, 8:44 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1652 (patched) > > > > > > Did you make sure that the ordering `updateSlave2` will always be

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review195683 --- PASS: Mesos patch 65039 was successfully built and tested.

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/#review195676 --- Fix it, then Ship it! CHANGELOG Line 17 (original), 17

Re: Review Request 65204: Eliminated some unnecessary copying in the agent's HTTP operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65204/#review195678 --- Ship it! Ship It! - Michael Park On Jan. 17, 2018, 5:19

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/ --- (Updated Jan. 18, 2018, 2:53 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65126: Added a resource provider test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/#review195548 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 8641

Re: Review Request 64386: Refactored health checks to take in executor information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/ --- (Updated Jan. 17, 2018, 12:10 p.m.) Review request for mesos, Alexander

Re: Review Request 64823: Documented the change in the Protobuf requirement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64823/#review195556 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65126: Added a resource provider test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/ --- (Updated Jan. 17, 2018, 2:05 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65180: Removed a comment in io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65180/ --- (Updated Jan. 17, 2018, 11:36 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 17, 2018, 12:12 p.m.) Review request for mesos, Alexander

Re: Review Request 64823: Documented the change in the Protobuf requirement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64823/#review195552 --- Fix it, then Ship it! Let's make sure to land this in

Re: Review Request 65180: Removed a comment in io switchboard.

> On Jan. 16, 2018, 7:24 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 666-669 (original) > > > > > > Does 4069e1c424 address making sure the IO-Switchboard allows > >

Re: Review Request 65162: Removed some redundant `get` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65162/#review19 --- PASS: Mesos patch 65162 was successfully built and tested.

  1   2   >