Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- (Updated Feb. 21, 2018, 9:58 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

> On Feb. 20, 2018, 3:25 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 2449-2453 (patched) > > > > > > This is not really useful (e.g., displays `yes` even if we fail in > > cli-related checks below).

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote: > > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ? > > Akash Gupta wrote: > Yeah, I think it will fix that issue, but I have to confirm it. > > Alexander Rukletsov wrote: > Please do! And if it does fix it,

Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197865 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197866 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197863 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197869 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65719/#review197845 --- Ship it! Ship It! - Benjamin Bannier On Feb. 20, 2018, 8:31

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197855 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197857 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/#review197850 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 16, 2018,

Review Request 65727: Moved `*DOCKER*` tests to `DockerContainerizerHealthCheckTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65727/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston

Re: Review Request 65727: Moved `*DOCKER*` tests to `DockerContainerizerHealthCheckTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65727/#review197851 --- Diff makes it look worse than it actually is. Basically I moved

Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197854 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197856 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review197871 --- Bad patch! Reviews applied: [65728, 64604, 64387, 65615, 65127,

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197870 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197872 --- Fix it, then Ship it! src/checks/checks_types.hpp Lines 52-56

Review Request 65621: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65621/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197853 --- In case you want more details, the bug was introduced in

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197859 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197861 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197860 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197862 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197980 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197983 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 22, 2018, 12:30 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/ --- (Updated Feb. 22, 2018, 1:39 a.m.) Review request for mesos, Alexander

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- (Updated Feb. 22, 2018, 1:47 a.m.) Review request for mesos, Alexander

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/ --- (Updated Feb. 22, 2018, 1:45 a.m.) Review request for mesos, Alexander

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Feb. 22, 2018, 1:44 a.m.) Review request for mesos, Alexander

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197990 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198084 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 22, 2018, 1:41 a.m.) Review request for mesos, Alexander

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/ --- (Updated Feb. 22, 2018, 1:50 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 22, 2018, 1:48 a.m.) Review request for mesos, Alexander

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 22, 2018, 12:36 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198085 --- Bad patch! Reviews applied: [65743, 65683] Failed command:

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198083 --- FAIL: Failed to apply the current review. Failed command:

Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/ --- (Updated Feb. 22, 2018, 1:51 a.m.) Review request for mesos, Alexander

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198095 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 21, 2018,

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198093 --- PASS: Mesos patch 65728 was successfully built and tested.

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198094 --- Patch looks great! Reviews applied: [65393, 65394, 65395, 65396,

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197877 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197879 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197878 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197880 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197881 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197884 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197883 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197887 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197889 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197888 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197890 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197903 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197905 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197904 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197906 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197911 --- FAIL: Failed to apply the dependent review: 65615. Failed

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review197910 --- FAIL: Failed to apply the dependent review: 65615. Failed

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197922 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197921 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197923 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197919 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197928 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197933 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197932 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197875 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197876 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197874 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197894 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197892 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197893 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197891 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197902 --- FAIL: Failed to get dependent review IDs for the current patch.

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review197907 --- FAIL: Failed to get dependent review IDs for the current patch.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197916 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197918 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197917 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197915 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197852 --- Fix it, then Ship it! src/checks/checker.cpp Lines 41

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197939 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197937 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/#review197941 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 8, 2018,

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197940 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197925 --- src/checks/checks_types.hpp Lines 57-58 (patched)

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197901 --- FAIL: Failed to apply the dependent review: 65615. Failed

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197900 --- Bad patch! Reviews applied: [65733, 65727, 64387, 65615, 65127,

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review197899 --- FAIL: Failed to apply the dependent review: 65615. Failed

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197882 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197897 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197896 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197895 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197898 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197930 --- Bad review! Error: Circular dependency detected for review

  1   2   3   >