Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 10:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on

Re: Review Request 66165: Re-fixed many master allocator tests.

> On March 21, 2018, 11:52 a.m., Benjamin Bannier wrote: > > src/tests/master_allocator_tests.cpp > > Line 759 (original), 748 (patched) > > > > > > This test seems to get flaky for me with this patch, could you

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On April 2, 2018, 8:42 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > > > > > If I understood the above discussion correctly, I think the

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- (Updated April 3, 2018, 2:11 p.m.) Review request for mesos and Andrew

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

> On April 2, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Line 1051 (original), 1051 (patched) > > > > > > Don't think you mean to have this here. Ah sorry, will remove. > On

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200363 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200370 --- 3rdparty/CMakeLists.txt Lines 267 (patched)

Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66385/#review200372 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 2, 2018,

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/ --- (Updated April 3, 2018, 4:27 p.m.) Review request for mesos, Alexander

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On April 2, 2018, 11:42 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > > > > > If I understood the above discussion correctly, I think the

Re: Review Request 63366: Add jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated April 3, 2018, 4:28 p.m.) Review request for mesos, Alexander

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 3, 2018, 4:29 p.m.) Review request for mesos, Alexander

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

> On April 2, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > > > > > Also, if this change should go upstream to ZooKeeper (looks to me

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200375 --- Patch looks great! Reviews applied: [66384, 66385, 66387, 66392]

Re: Review Request 66144: Enforced task launch order on the agent.

> On April 2, 2018, 4:57 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2233 (original), 2274 (patched) > > > > > > We should defer this callback. > > Meng Zhu wrote: > That would change the old

Re: Review Request 66396: Bugfix for MESOS-8308.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66396/#review200368 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review200376 --- src/tests/slave_tests.cpp Lines 4930 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

> On April 2, 2018, 4:21 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2396-2398 (patched) > > > > > > Looks like we don't need this local variable? You mean passing the whole error message directly to

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review200380 --- FAIL: Failed to apply the dependent review: 63366. Failed

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

> On April 3, 2018, 10:40 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 4969 (patched) > > > > > > Is this necessary? To avoid uninteresting mock call. > On April 3, 2018, 10:40 a.m., Greg Mann

Review Request 66408: Updated CSI helpers for v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66408/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Review Request 66409: Used `csi::v0::VolumeCapability` in disk profile adaptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66409/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 66410: Adapted storage local resource provider to use CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66410/#review200394 --- FAIL: Failed to apply the dependent review: 66398. Failed

Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66411/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Review Request 66398: Bumped the CSI spec bundle to 0.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66398/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8650

Re: Review Request 66398: Bumped the CSI spec bundle to 0.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66398/#review200388 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200389 --- Patch looks great! Reviews applied: [66404] Passed command:

Review Request 66407: Updated CSI client to support v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66407/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8653

Review Request 66410: Adapted storage local resource provider to use CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66410/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review200396 --- Bad patch! Reviews applied: [63372, 63371, 63370, 63368, 63366,

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

> On April 2, 2018, 3:38 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2166 (original), 2221-2227 (patched) > > > > > > Ah whoops, we should defer this continuation to `self()`. I think it's > > probably

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200378 --- PASS: Mesos patch 66404 was successfully built and tested.

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated April 3, 2018, 10:38 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review200382 --- src/tests/slave_tests.cpp Lines 4927 (patched)

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review200381 --- src/tests/slave_tests.cpp Lines 5070 (patched)

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

> On April 3, 2018, 10:51 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5114 (patched) > > > > > > Is this necessary? To avoid uninteresing mock call. > On April 3, 2018, 10:51 a.m., Greg Mann

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66404/#review200392 --- Ship it! LGTM, before landing this patch, could we verify the

Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66411/#review200395 --- FAIL: Failed to apply the dependent review: 66398. Failed

Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66411/#review200400 --- Bad patch! Reviews applied: [66411, 66410, 66409, 66408, 66407,

Re: Review Request 66346: Added two matchers for TaskInfo and TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66346/#review200403 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 3604

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200398 --- src/tests/slave_tests.cpp Lines 5208 (patched)

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200407 --- src/tests/slave_tests.cpp Lines 9093-9094 (patched)

Re: Review Request 66347: Added a test for killing executor during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66347/#review200404 --- src/tests/slave_tests.cpp Lines 5563 (patched)

Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200410 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200402 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/ --- (Updated April 3, 2018, 3:08 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/ --- (Updated April 3, 2018, 8:32 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

Re: Review Request 66323: Added tests for failed task launch on agent.

> On April 3, 2018, 5:17 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5249 (patched) > > > > > > Is this necessary? To avoid uninteresting mock calls. > On April 3, 2018, 5:17 p.m., Greg Mann

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 3:33 a.m.) Review request for mesos, Andrew

Re: Review Request 66347: Added a test for killing executor during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66347/ --- (Updated April 3, 2018, 8:38 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66347: Added a test for killing executor during task launch.

> On April 3, 2018, 5:58 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5592 (patched) > > > > > > Is this needed? To avoid uninteresting mock call. > On April 3, 2018, 5:58 p.m., Greg Mann

Re: Review Request 66412: Fixed flaky agent test.

> On April 3, 2018, 5:59 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 9093-9094 (patched) > > > > > > Why this change? Removed. And changed await_ready to await. - Meng

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

> On April 3, 2018, 4:36 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 267 (patched) > > > > > > This looks good; except I think in generaly it's going to find a shared > > version of

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- (Updated April 4, 2018, 3:46 a.m.) Review request for mesos and Andrew

Re: Review Request 66408: Updated CSI helpers for v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66408/ --- (Updated April 4, 2018, 3:59 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66411/ --- (Updated April 4, 2018, 4 a.m.) Review request for mesos, Benjamin Bannier and

Review Request 66418: Handled failed publish and unpublish CSI calls properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66418/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8717

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > > > > > Also, if this change should go upstream to ZooKeeper (looks to me like

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200417 --- PASS: Mesos patch 66323 was successfully built and tested.

Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66418/#review200418 --- FAIL: Failed to apply the dependent review: 66398. Failed

Re: Review Request 66323: Added tests for failed task launch on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66323/#review200419 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 66346: Added three matchers for agent tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66346/ --- (Updated April 3, 2018, 8:21 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/ --- (Updated April 3, 2018, 8:24 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200424 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66421/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66422/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66426: Windows: More constness in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Re: Review Request 66038: Add usageWithInode to check both disk and inode usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/#review200427 --- 3rdparty/stout/include/stout/posix/fs.hpp Lines 55 (patched)

Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66427/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66039/#review200429 --- src/slave/slave.cpp Lines 6743 (patched)

Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66440/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66442/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66439/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66441: Fixed mismatched types in `process.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66441/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66444: Windows: Made `signals.hpp` compile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66443/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and