Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

> On May 8, 2018, 9:33 a.m., Benjamin Bannier wrote: > > 3rdparty/Makefile.am > > Lines 326 (patched) > > > > > > This variable name makes sense only 50% of the time, how about e.g., > > `GRPC_LIB_SUFFIX`? I'll

Review Request 67012: Resolve container target paths within their rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67012/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and

Re: Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/#review202675 --- include/mesos/allocator/allocator.hpp Lines 372 (patched)

Re: Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/#review202702 --- Patch looks great! Reviews applied: [67009] Passed command:

Review Request 67018: Removed unnecessary gRPC build flags in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67018/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 67017: Removed unnecessary gRPC build flags in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67017/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 65900: Defer creation of volume target paths to container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65900/ --- (Updated May 8, 2018, 7:07 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 66993: Removed unnecessary expectation on termination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/ --- (Updated May 8, 2018, 1:36 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 66993: Removed unnecessary expectation on termination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/#review202691 --- Ship it! Ship It! - Andrei Budnik On May 8, 2018, 8:36

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/#review202680 --- src/master/metrics.cpp Lines 556-557 (patched)

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

> On May 1, 2018, 12:39 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1766 (patched) > > > > > > Do we need the typedef up here? or should we put it down to the foreach > >

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66861/ --- (Updated May 8, 2018, 10:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66841: Added a hash function for 'Duration'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66841/ --- (Updated May 8, 2018, 11:18 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67013: Sort container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67013/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and

Re: Review Request 66984: Added the ability to exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/#review202673 --- The description could use some more explanation around allocating

Re: Review Request 66841: Added a hash function for 'Duration'.

> On April 30, 2018, 11:57 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/duration.hpp > > Lines 28 (patched) > > > > > > Instead of pulling in boost here, can we just leverage the built-in > > hash

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202701 --- Fix it, then Ship it! LGTM!

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202722 --- Ship it! Ship It! - Qian Zhang On May 8, 2018, 11:33 p.m.,

Re: Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66997/ --- (Updated May 9, 2018, 12:52 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

> On May 8, 2018, 9:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am > > Line 182 (original), 185 (patched) > > > > > > It is not clear to me that this would always find the correct > > libraries. I see e.g.,

Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67022/ --- Review request for mesos, Benno Evers, Jason Lai, and Vinod Kone. Repository:

Review Request 67025: Fixed the link order for gRPC in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67025/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.

Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67024/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.

Re: Review Request 67013: Sort container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67013/#review202726 --- Bad patch! Reviews applied: [67013, 67012, 65900, 65899, 65898,

Re: Review Request 64384: Added new 'any' setting for reconfiguration_policy flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64384/#review202713 --- src/slave/slave.cpp Lines 6373-6375 (original), 6377-6379

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/ --- (Updated May 9, 2018, 12:50 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 67021: Windows: Enabled `ProtobufTest` suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67021/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Re: Review Request 66882: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66882/ --- (Updated May 8, 2018, 5:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67022/ --- (Updated May 8, 2018, 5:40 p.m.) Review request for mesos, Eric Chung and

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67022/#review202723 --- Ship it! Ship It! - Jason Lai On May 9, 2018, 12:40 a.m.,

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/ --- (Updated May 8, 2018, 11:38 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66997/#review202620 --- 3rdparty/libprocess/3rdparty/Makefile.am Lines 208 (patched)

Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66996/#review202621 --- 3rdparty/Makefile.am Lines 326 (patched)

Re: Review Request 66987: Renamed cgroups subsystem processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66987/#review202618 --- Ship it! Ship It! - Qian Zhang On May 7, 2018, 11:56 p.m.,

Re: Review Request 66933: Added a realm for resource provider authentication.

> On May 8, 2018, 12:35 p.m., Benjamin Bannier wrote: > > src/slave/constants.hpp > > Lines 171 (patched) > > > > > > I don't believe it makes sense to treat resource providers separately > > from other internal

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

> On May 3, 2018, 9:35 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/strings.hpp > > Lines 390 (patched) > > > > > > Can you mention the max length optimization you're doing? I will add a comment if

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/ --- (Updated May 8, 2018, 12:30 p.m.) Review request for mesos, Alexander

Re: Review Request 66933: Added a realm for resource provider authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66933/#review202623 --- src/slave/constants.hpp Lines 171 (patched)

Re: Review Request 66932: Adden token based authentication for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66932/#review202622 --- Fix it, then Ship it! include/mesos/v1/resource_provider.hpp

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202624 --- Fix it, then Ship it! Could you verify that after rebase no

Re: Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67004/#review202630 --- Ship it! Ship It! - Armand Grillet On May 8, 2018, 12:54

Re: Review Request 66932: Adden token based authentication for resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66932/ --- (Updated May 8, 2018, 3:08 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66997/#review202627 --- Patch looks great! Reviews applied: [66996, 66997] Passed

Review Request 67003: Fixed flakiness in a `MasterSlaveReconciliationTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67003/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8892

Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67004/ --- Review request for mesos. Repository: mesos Description --- By default,

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/ --- (Updated May 8, 2018, 3:09 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

> On May 8, 2018, 5 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > > Line 174 (original), 236 (patched) > > > > > > It seems `subsystemName` is only used in

Review Request 67008: Added documentation to website for Python components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67008/ --- Review request for mesos, Andrew Schwartzmeyer, Eric Chung, and Kevin Klues.

Re: Review Request 67003: Fixed flakiness in a `MasterSlaveReconciliationTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67003/#review202650 --- Ship it! Ship It! - Greg Mann On May 8, 2018, 11:59 a.m.,

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/ --- (Updated May 8, 2018, 5:33 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 66635: Introduced wrapper for access to cgroups system access.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66635/#review202619 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-8837

Re: Review Request 66993: Removed unnecessary expectation on termination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66993/#review202635 --- src/tests/containerizer/docker_containerizer_tests.cpp Line 644

Re: Review Request 66984: Added the ability to exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- (Updated May 8, 2018, 9:36 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67003: Fixed flakiness in a `MasterSlaveReconciliationTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67003/#review202661 --- Patch looks great! Reviews applied: [67003] Passed command:

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review202662 --- src/master/metrics.hpp Lines 219-221 (patched)

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66799/#review202660 --- Ship it! Ship It! - Alexander Rukletsov On April 25, 2018,

Re: Review Request 67004: Added an option to keep downloaded patches to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67004/#review202659 --- Ship it! Ship It! - Alexander Rukletsov On May 8, 2018,

Re: Review Request 66984: Added the ability to exhaustively allocate declined resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- (Updated May 8, 2018, 9:55 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202633 --- Patch looks great! Reviews applied: [66932, 66933, 66934]

Re: Review Request 66634: Explicitly marked functions `override` in cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66634/#review202636 --- Ship it! Ship It! - Qian Zhang On April 16, 2018, 11:03

Re: Review Request 66821: Added framwork metrics helper normalize() and getPrefix().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66821/#review202663 --- There's a typo in the RR description: s/framwork/framework/

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated May 8, 2018, 6:41 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated May 8, 2018, 6:43 p.m.) Review request for mesos, Anish Gupta, Eric