Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2633

Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Review Request 68146: Added actions and ACLs to authorize removal of resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68146/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Review Request 68143: Made resource provider manager emit an event when provider subscribed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68143/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Review Request 68144: Added methods to remove resource providers from provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-8403

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/ --- (Updated Aug. 1, 2018, 10:18 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68114: Fixed a gRPC compilation issue for Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/#review206736 --- Fix it, then Ship it! LGTM. Two things: * let's commit this

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

> On July 31, 2018, 5:38 a.m., Chun-Hung Hsiao wrote: > > src/tests/api_tests.cpp > > Lines 7002-7004 (original), 7002-7021 (patched) > > > > > > How about the following: > > ``` > > slave::Flags slaveFlags

Re: Review Request 68104: Implemented authorization for agent `GET_RESOURCE_PROVIDER` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68104/#review206738 --- PASS: Mesos patch 68104 was successfully built and tested.

Re: Review Request 68093: Add XFS disk isolator files to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68093/#review206734 --- Ship it! Ship It! - Benjamin Bannier On July 27, 2018, 9:11

Re: Review Request 67751: Add missing files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/#review206735 --- Ship it! Ship It! - Benjamin Bannier On July 28, 2018,

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review206753 --- PASS: Mesos patch 68147 was successfully built and tested.

Re: Review Request 68092: CMake: Always build gRPC in Mesos.

> On July 30, 2018, 10:16 a.m., Benjamin Bannier wrote: > > src/cmake/MesosProtobuf.cmake > > Line 145 (original), 145 (patched) > > > > > > I couldn't find out how `PROTOC_GRPC` is set and wheter it can ever be >

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206748 --- PASS: Mesos patch 68141 was successfully built and tested.

Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers.

> On July 6, 2018, 6:58 p.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 2879 (patched) > > > > > > Nit: I'd make this method take a const ref for consistency. But given > > that `State` is an enum,

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/#review206755 --- Fix it, then Ship it! I don't have a good sense of whether

Re: Review Request 67933: Replaced `` with `` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67933/#review206761 --- This was trivial and Windows only so I shipped it. - Andrew

Review Request 68152: Added missing iptables argument in CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68152/ --- Review request for mesos and Jie Yu. Bugs: MESOS-9125

Re: Review Request 68152: Added missing iptables argument in CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68152/ --- (Updated Aug. 2, 2018, 12:46 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206765 --- Bad review! Reviews applied: [68134, 68048, 67823, 67187]

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206768 --- Bad patch! Reviews applied: [68132, 68131] Failed command:

Re: Review Request 68152: Added missing iptables argument in CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68152/#review206771 --- PASS: Mesos patch 68152 was successfully built and tested.

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206773 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68151: Avoided some expensive copies in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68151/#review206766 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68152: Added missing iptables argument in CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68152/#review206767 --- Ship it! I'd be a bit verbose on the commit message: ```

Re: Review Request 68092: TESTING: Windows CI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68092/#review206778 --- FAIL: Mesos binaries failed to build. Reviews applied:

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206757 --- Bad patch! Reviews applied: [67932, 67984, 67930, 67931] Failed

Review Request 68151: Avoided some expensive copies in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68151/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 68154: Fixed gRPC compilation for standalone libprocess build with Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68154/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8395

Re: Review Request 68114: Fixed gRPC compilation with Clang when building Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68114/ --- (Updated Aug. 1, 2018, 9:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 68151: Avoided some expensive copies in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68151/#review206759 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Line

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68149/#review206760 --- PASS: Mesos patch 68149 was successfully built and tested.

Re: Review Request 68151: Avoided some expensive copies in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68151/ --- (Updated Aug. 1, 2018, 2:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 68151: Avoided some expensive copies in the allocator.

> On Aug. 1, 2018, 1:51 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1732 (original), 1731 (patched) > > > > > > Maybe a CHECK_NOTNULL around the de-reference? Done. -

Re: Review Request 68091: Always build gRPC in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68091/ --- (Updated Aug. 1, 2018, 9:54 p.m.) Review request for mesos and Benjamin

Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/ --- Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, and Greg Mann.