some additional tests.
Thanks,
Anand Mazumdar
generated e-mail. To reply, visit:
https://reviews.apache.org/r/35179/#review87140
---
On June 9, 2015, 3:56 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail
(line 413)
https://reviews.apache.org/r/35743/#comment141444
boost::size(...) would suffice here too albeit minus the small trivial
run-time cost.
- Anand Mazumdar
On June 22, 2015, 9:27 p.m., Jojy Varghese wrote
://reviews.apache.org/r/35858/#comment141950
I had a general query regarding pre-pending the function arguments with _
in our style guide. Here we do the opposite i.e. use a trailing underscore. Are
both allowed or is it preferred to use the one from the style guide ?
- Anand Mazumdar
On June 25, 2015, 12
)
https://reviews.apache.org/r/35934/#comment142159
Minor : the response code is 406 for a not acceptable response.
- Anand Mazumdar
On June 26, 2015, 6:03 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/35815/#comment141723
We are leaking here ? Using Group group(...); should suffice here.
src/tests/master_contender_detector_tests.cpp (line 865)
https://reviews.apache.org/r/35815/#comment141724
Leaking here too. This can be wrapped in Owned
- Anand Mazumdar
)
https://reviews.apache.org/r/35743/#comment141675
Then can we change these to std::array and just invoke the size() function
?
- Anand Mazumdar
On June 23, 2015, 9:51 p.m., Jojy Varghese wrote:
---
This is an automatically
On June 22, 2015, 10:02 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 418
https://reviews.apache.org/r/35743/diff/1/?file=989917#file989917line418
boost::size(...) would suffice here too albeit minus the small trivial
run-time cost
: https://reviews.apache.org/r/35179/diff/
Testing
---
make check + added some additional tests.
Thanks,
Anand Mazumdar
af18c6bb8bcbe0912246cdf9e84ee183924ea298
Diff: https://reviews.apache.org/r/35538/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
cf354125687e0f60b6d5b105f19d75e4436f21bf
Diff: https://reviews.apache.org/r/35179/diff/
Testing
---
make check + added some additional tests.
Thanks,
Anand Mazumdar
cf354125687e0f60b6d5b105f19d75e4436f21bf
Diff: https://reviews.apache.org/r/35179/diff/
Testing
---
make check + added some additional tests.
Thanks,
Anand Mazumdar
---
On June 12, 2015, 5:17 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35179/
---
(Updated June 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90098
---
Ship it!
Looks good, just one minor comment.
- Anand Mazumdar
/36079/#comment143066
Minor nit-pick:
const FrameworkInfo frameworkInfo ?
- Anand Mazumdar
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
, so this test is not valid.
In essence , we need to test for an accept type which the server can't
support that we already seem to be doing in CallEndpointWrongHeaderAccept, so
we can delete this test.
- Anand Mazumdar
On July 1, 2015, 6:52 p.m., Isabel Jimenez wrote
On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 777
https://reviews.apache.org/r/36040/diff/1/?file=995839#file995839line777
What is this change intending to solve ? If it's the ability to not
close the connection for streamed responses
23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
Diff: https://reviews.apache.org/r/37192/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/protobuf responses.
Diffs (updated)
-
src/master/master.hpp bb7c8e9e05be829a6b9aa3100a714b2359854d96
src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
)
-
src/common/http.hpp 98a12709ae5fcbf4ce3e37d164bff43818096838
src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316
Diff: https://reviews.apache.org/r/37303/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
---
make check
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37512/#review95684
---
Ship it!
LGTM
- Anand Mazumdar
On Aug. 18, 2015, 3:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/#review95590
---
Ship it!
Ship It!
- Anand Mazumdar
On Aug. 16, 2015, 11:41 p.m
/#comment150680
s/of a cluster/for a cluster
- Anand Mazumdar
On Aug. 17, 2015, 6:26 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37512
Description
---
We were not logging the API requests for the HTTP scheduler API.
Diffs
-
src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e
Diff: https://reviews.apache.org/r/37509/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/
Testing
---
make check
Thanks,
Anand Mazumdar
---
Trivial change involving adding more logging to the scheduler library while
sending/receiving events.
Diffs
-
src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a
Diff: https://reviews.apache.org/r/37510/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
as a reviewer to confirm this ?
- Anand Mazumdar
On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040
://reviews.apache.org/r/36720/#review93499
---
On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
)
https://reviews.apache.org/r/36807/#comment147751
Nit:
s/Protect from flaky failures on those hosts/Protect from failures on hosts
- Anand Mazumdar
On July 29, 2015, 1:01 a.m., Marco Massenzio wrote
/string/const string
- Anand Mazumdar
On July 29, 2015, 1:58 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36900
54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
src/common/recordio_response.hpp PRE-CREATION
src/tests/common/recordio_response_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37080/diff/
Testing
---
make check + added tests.
Thanks,
Anand Mazumdar
introduced ?
- Anand Mazumdar
On Aug. 4, 2015, 10:43 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097
json/protobuf responses.
Diffs (updated)
-
src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6
src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/37192/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Diffs
-
src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
)
-
src/master/master.hpp 6bd05b1f364affeb4f23baa7cdf3a0d00c45a2c6
src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
.
Diffs
-
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37335/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95015
---
Ship it!
LGTM
- Anand Mazumdar
On Aug. 11, 2015, 10:13 p.m
Diff: https://reviews.apache.org/r/37303/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
:25 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
---
(Updated Aug. 6, 2015, 4:25 p.m
patch.
Thanks,
Anand Mazumdar
(updated)
-
src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
, 4:26 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 6, 2015, 4:26 p.m
Diff: https://reviews.apache.org/r/37192/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
responses.
Diffs (updated)
-
src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
type and hence test
both json/protobuf responses.
Diffs (updated)
-
src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/master.hpp cd0a5c863d4f74c3bcfd61d8e3046b3ab249be67
src/master/master.cpp 87e11d512f68e2b7285ee1901d422991208baf15
Diff: https://reviews.apache.org/r/36720/diff/
Testing
---
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
/master/master.hpp e44174976aa64176916827bec4c911333c9a91db
src/master/master.cpp 5aa0a5410804fe16abd50b6953f1ffe46a019ecf
Diff: https://reviews.apache.org/r/36720/diff/
Testing
---
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
e44174976aa64176916827bec4c911333c9a91db
src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43
Diff: https://reviews.apache.org/r/36720/diff/
Testing
---
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
yesterday. Fixed :)
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review94292
---
On Aug. 5, 2015, midnight, Anand Mazumdar
/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac
Diff: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
: https://reviews.apache.org/r/37082/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/validate/authorize/ and pull out an
`isAuthenticated` that we can call synchronously as well.
Anand Mazumdar wrote:
Primarily due to the reasons you had mentioned earlier. There was a lot
of pid specific code in validate. Also , call validation in general were
supposed to be handled
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc
src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544
Diff: https://reviews.apache.org/r/36720/diff/
Testing (updated)
---
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
,
Anand Mazumdar
) , the handler on the server side should
check the host header to be TEST_URL in the http::Request ?
- Anand Mazumdar
On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/37449/#comment150260
micro nit : let's just do Event::HEARTBEAT
- Anand Mazumdar
On Aug. 13, 2015, 11:23 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
committing this in just to be sure
since the last time review bot did seem to show a false positive on r37328 ?
src/scheduler/scheduler.cpp (line 382)
https://reviews.apache.org/r/37467/#comment150319
Micro nit : How about just CHECK(!calls.empty()) ?
- Anand Mazumdar
On Aug. 14, 2015, 1:59 a.m
---
See summary and related CR
Diffs
-
src/examples/event_call_framework.cpp
019e5c1f19a9e455b73ea9916b4f4270dad6d3da
Diff: https://reviews.apache.org/r/37471/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
://reviews.apache.org/r/37301/diff/
Testing
---
Thanks,
Anand Mazumdar
https://issues.apache.org/jira/browse/MESOS-2552
Repository: mesos
Description
---
Disabled auth from tests
Diffs
-
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37301/diff/
Testing
---
Thanks,
Anand Mazumdar
Description
---
Delete receive handlers ,install call back setups
Diffs
-
src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
---
Thanks,
Anand Mazumdar
/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50
src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37303/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/
Testing
---
Thanks,
Anand Mazumdar
02c24c2cd45b3dcb97def605aa735c6efd951943
src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633
Diff: https://reviews.apache.org/r/37300/diff/
Testing
---
Thanks,
Anand Mazumdar
a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37298/diff/
Testing
---
Thanks,
Anand Mazumdar
manually though.
Diffs
-
src/examples/event_call_framework.cpp
02c24c2cd45b3dcb97def605aa735c6efd951943
src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633
Diff: https://reviews.apache.org/r/37300/diff/
Testing
---
Thanks,
Anand Mazumdar
,
Anand Mazumdar
:
https://reviews.apache.org/r/37301/#review94769
---
On Aug. 10, 2015, 4:44 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
Thanks,
Anand Mazumdar
and Vinod Kone.
Repository: mesos
Description
---
Delete receive handlers ,install call back setups
Diffs
-
src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
53420ca7d503296fbe11b1ea0795afe2ebf86255
src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/36720/diff/
Testing
---
make check + adding tests in a different patch.
Thanks,
Anand Mazumdar
check
Thanks,
Anand Mazumdar
/diff/
Testing
---
make check + would add tests in separate patch
Thanks,
Anand Mazumdar
://reviews.apache.org/r/37302/diff/
Testing
---
Thanks,
Anand Mazumdar
and Vinod Kone.
Repository: mesos
Description
---
Remove namespace ambiguity. Needed for r37303
Diffs
-
src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
Diff: https://reviews.apache.org/r/37328/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
-
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37335/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
a8699a7514892a548eb03f9dcb6a1198ce518830
Diff: https://reviews.apache.org/r/37298/diff/
Testing
---
Thanks,
Anand Mazumdar
(updated)
-
src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f
Diff: https://reviews.apache.org/r/37301/diff/
Testing (updated)
---
make check
Thanks,
Anand Mazumdar
.
Diffs (updated)
-
src/examples/event_call_framework.cpp
02c24c2cd45b3dcb97def605aa735c6efd951943
src/tests/event_call_framework_test.sh
e42c4e8364076a408b33c894f1f3c6a21e12d1dc
Diff: https://reviews.apache.org/r/37300/diff/
Testing
---
Thanks,
Anand Mazumdar
to
oversubscribe?
Added.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review94777
---
On Aug. 11, 2015, 12:17 a.m., Anand Mazumdar
/r/37489/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/tests/protobuf_tests.cpp
018ff51d10f4ba076609704d6e3b2c704c82b016
Diff: https://reviews.apache.org/r/37491/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd
Diff: https://reviews.apache.org/r/37489/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
- Anand Mazumdar
On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/
---
(Updated
://reviews.apache.org/r/37489/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
---
On Aug. 12, 2015, 6:51 a.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review94959
---
On Aug. 11, 2015, 10:18 p.m., Anand Mazumdar wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95029
---
Ship it!
LGTM !
- Anand Mazumdar
On Aug. 11, 2015, 11:52 p.m
/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf
Diff: https://reviews.apache.org/r/37378/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
-mail. To reply, visit:
https://reviews.apache.org/r/37303/#review95036
---
On Aug. 11, 2015, 10:18 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply
://reviews.apache.org/r/37405/#comment149978
Nit: new line here
- Anand Mazumdar
On Aug. 12, 2015, 6:07 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405
/#comment149965
use the serialize function already defined earlier in the text fixture.
- Anand Mazumdar
On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Description
---
Disallow copy construction/assignment for the Mesos scheduler library.
Diffs
-
include/mesos/v1/scheduler.hpp b3f4484b06dfd6b967d934fd39be373cbff445c4
Diff: https://reviews.apache.org/r/37410/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
1 - 100 of 1530 matches
Mail list logo
