Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Anand Mazumdar
some additional tests. Thanks, Anand Mazumdar

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Anand Mazumdar
generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/#review87140 --- On June 9, 2015, 3:56 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail

Re: Review Request 35743: flags: fixed const'ness of load

2015-06-22 Thread Anand Mazumdar
(line 413) https://reviews.apache.org/r/35743/#comment141444 boost::size(...) would suffice here too albeit minus the small trivial run-time cost. - Anand Mazumdar On June 22, 2015, 9:27 p.m., Jojy Varghese wrote

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

2015-06-25 Thread Anand Mazumdar
://reviews.apache.org/r/35858/#comment141950 I had a general query regarding pre-pending the function arguments with _ in our style guide. Here we do the opposite i.e. use a trailing underscore. Are both allowed or is it preferred to use the one from the style guide ? - Anand Mazumdar On June 25, 2015, 12

Re: Review Request 35934: New Not Acceptable HTTP response type

2015-06-26 Thread Anand Mazumdar
) https://reviews.apache.org/r/35934/#comment142159 Minor : the response code is 406 for a not acceptable response. - Anand Mazumdar On June 26, 2015, 6:03 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

2015-06-23 Thread Anand Mazumdar
://reviews.apache.org/r/35815/#comment141723 We are leaking here ? Using Group group(...); should suffice here. src/tests/master_contender_detector_tests.cpp (line 865) https://reviews.apache.org/r/35815/#comment141724 Leaking here too. This can be wrapped in Owned - Anand Mazumdar

Re: Review Request 35743: flags: fixed const'ness of load

2015-06-23 Thread Anand Mazumdar
) https://reviews.apache.org/r/35743/#comment141675 Then can we change these to std::array and just invoke the size() function ? - Anand Mazumdar On June 23, 2015, 9:51 p.m., Jojy Varghese wrote: --- This is an automatically

Re: Review Request 35743: flags: fixed const'ness of load

2015-06-23 Thread Anand Mazumdar
On June 22, 2015, 10:02 p.m., Anand Mazumdar wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 418 https://reviews.apache.org/r/35743/diff/1/?file=989917#file989917line418 boost::size(...) would suffice here too albeit minus the small trivial run-time cost

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-15 Thread Anand Mazumdar
: https://reviews.apache.org/r/35179/diff/ Testing --- make check + added some additional tests. Thanks, Anand Mazumdar

Review Request 35538: [MESOS-1988] Remove unused drop(...) overload

2015-06-16 Thread Anand Mazumdar
af18c6bb8bcbe0912246cdf9e84ee183924ea298 Diff: https://reviews.apache.org/r/35538/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-12 Thread Anand Mazumdar
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp cf354125687e0f60b6d5b105f19d75e4436f21bf Diff: https://reviews.apache.org/r/35179/diff/ Testing --- make check + added some additional tests. Thanks, Anand Mazumdar

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-12 Thread Anand Mazumdar
cf354125687e0f60b6d5b105f19d75e4436f21bf Diff: https://reviews.apache.org/r/35179/diff/ Testing --- make check + added some additional tests. Thanks, Anand Mazumdar

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-12 Thread Anand Mazumdar
--- On June 12, 2015, 5:17 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35179/ --- (Updated June 12

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

2015-07-01 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90098 --- Ship it! Looks good, just one minor comment. - Anand Mazumdar

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

2015-07-01 Thread Anand Mazumdar
/36079/#comment143066 Minor nit-pick: const FrameworkInfo frameworkInfo ? - Anand Mazumdar On July 1, 2015, 5:28 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36073: New Method Not Allowed HTTP response type

2015-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36073/#review89994 --- Ship it! Ship It! - Anand Mazumdar On July 1, 2015, 1:52 a.m

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-05 Thread Anand Mazumdar
to break this into smaller chunks. - Anand Mazumdar On July 2, 2015, 8:16 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Anand Mazumdar
, so this test is not valid. In essence , we need to test for an accept type which the server can't support that we already seem to be doing in CallEndpointWrongHeaderAccept, so we can delete this test. - Anand Mazumdar On July 1, 2015, 6:52 p.m., Isabel Jimenez wrote

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Anand Mazumdar
the request. This Keep-Alive has nothing to do with your stream being kept alive by the server for an infinite time as is being made out by looking at the code. Hence , this along with the test that tests this validation behavior needs to be deleted. - Anand Mazumdar On July

Re: Review Request 36040: Change Server closing connections for every request

2015-07-02 Thread Anand Mazumdar
On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote: 3rdparty/libprocess/src/http.cpp, line 777 https://reviews.apache.org/r/36040/diff/1/?file=995839#file995839line777 What is this change intending to solve ? If it's the ability to not close the connection for streamed responses

Re: Review Request 37192: More basic call validation tests for http api

2015-08-11 Thread Anand Mazumdar
23214dfc770d9b18c85ddbdaf35b85e59eeb8acf Diff: https://reviews.apache.org/r/37192/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
/protobuf responses. Diffs (updated) - src/master/master.hpp bb7c8e9e05be829a6b9aa3100a714b2359854d96 src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
) - src/common/http.hpp 98a12709ae5fcbf4ce3e37d164bff43818096838 src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316 Diff: https://reviews.apache.org/r/37303/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37328: Remove namespace ambiguity

2015-08-12 Thread Anand Mazumdar
--- make check Thanks, Anand Mazumdar

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

2015-08-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95684 --- Ship it! LGTM - Anand Mazumdar On Aug. 18, 2015, 3:08 a.m

Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

2015-08-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95590 --- Ship it! Ship It! - Anand Mazumdar On Aug. 16, 2015, 11:41 p.m

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

2015-08-17 Thread Anand Mazumdar
/#comment150680 s/of a cluster/for a cluster - Anand Mazumdar On Aug. 17, 2015, 6:26 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512

Review Request 37509: Log Scheduler HTTP API Requests

2015-08-16 Thread Anand Mazumdar
Description --- We were not logging the API requests for the HTTP scheduler API. Diffs - src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e Diff: https://reviews.apache.org/r/37509/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37410: Disallow copy construction/assignment

2015-08-16 Thread Anand Mazumdar
/ Testing --- make check Thanks, Anand Mazumdar

Review Request 37510: Add more logging to the scheduler library

2015-08-16 Thread Anand Mazumdar
--- Trivial change involving adding more logging to the scheduler library while sending/receiving events. Diffs - src/scheduler/scheduler.cpp 0aef68e3a43eaee830880fb31543c7ed7c67769a Diff: https://reviews.apache.org/r/37510/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Anand Mazumdar
as a reviewer to confirm this ? - Anand Mazumdar On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-07-29 Thread Anand Mazumdar
://reviews.apache.org/r/36720/#review93499 --- On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 36807: Adding a test for MasterInfo

2015-07-28 Thread Anand Mazumdar
) https://reviews.apache.org/r/36807/#comment147751 Nit: s/Protect from flaky failures on those hosts/Protect from failures on hosts - Anand Mazumdar On July 29, 2015, 1:01 a.m., Marco Massenzio wrote

Re: Review Request 36900: Publish MasterInfo to ZK in JSON format

2015-07-28 Thread Anand Mazumdar
/string/const string - Anand Mazumdar On July 29, 2015, 1:58 a.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36900

Re: Review Request 37080: Introduced RecordIO response reader

2015-08-05 Thread Anand Mazumdar
54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/common/recordio_response.hpp PRE-CREATION src/tests/common/recordio_response_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37080/diff/ Testing --- make check + added tests. Thanks, Anand Mazumdar

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-04 Thread Anand Mazumdar
introduced ? - Anand Mazumdar On Aug. 4, 2015, 10:43 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
json/protobuf responses. Diffs (updated) - src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37192: More basic call validation tests for http api

2015-08-11 Thread Anand Mazumdar
://reviews.apache.org/r/37192/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37302: Deleted old style message handling from the scheduler library.

2015-08-11 Thread Anand Mazumdar
Diffs - src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
) - src/master/master.hpp 6bd05b1f364affeb4f23baa7cdf3a0d00c45a2c6 src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
. Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37335/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37374: Only accept v1 protobufs for HTTP API.

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37374/#review95015 --- Ship it! LGTM - Anand Mazumdar On Aug. 11, 2015, 10:13 p.m

Re: Review Request 37303: Moved scheduler library to http

2015-08-11 Thread Anand Mazumdar
Diff: https://reviews.apache.org/r/37303/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
:25 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 6, 2015, 4:25 p.m

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
patch. Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
(updated) - src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
, 4:26 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 6, 2015, 4:26 p.m

Re: Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Anand Mazumdar
Diff: https://reviews.apache.org/r/37192/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
responses. Diffs (updated) - src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
type and hence test both json/protobuf responses. Diffs (updated) - src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-04 Thread Anand Mazumdar
/master.hpp cd0a5c863d4f74c3bcfd61d8e3046b3ab249be67 src/master/master.cpp 87e11d512f68e2b7285ee1901d422991208baf15 Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + adding tests in a different patch. Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-04 Thread Anand Mazumdar
/master/master.hpp e44174976aa64176916827bec4c911333c9a91db src/master/master.cpp 5aa0a5410804fe16abd50b6953f1ffe46a019ecf Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + adding tests in a different patch. Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-05 Thread Anand Mazumdar
e44174976aa64176916827bec4c911333c9a91db src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + adding tests in a different patch. Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-05 Thread Anand Mazumdar
on content type and hence test both json/protobuf responses. Diffs (updated) - src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-05 Thread Anand Mazumdar
yesterday. Fixed :) - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94292 --- On Aug. 5, 2015, midnight, Anand Mazumdar

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
: https://reviews.apache.org/r/37082/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-04 Thread Anand Mazumdar
/validate/authorize/ and pull out an `isAuthenticated` that we can call synchronously as well. Anand Mazumdar wrote: Primarily due to the reasons you had mentioned earlier. There was a lot of pid specific code in validate. Also , call validation in general were supposed to be handled

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-04 Thread Anand Mazumdar
src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 Diff: https://reviews.apache.org/r/36720/diff/ Testing (updated) --- make check + adding tests in a different patch. Thanks, Anand Mazumdar

Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Anand Mazumdar
, Anand Mazumdar

Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-13 Thread Anand Mazumdar
) , the handler on the server side should check the host header to be TEST_URL in the http::Request ? - Anand Mazumdar On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37449: Fixed scheduler tests to work with heartbeats.

2015-08-13 Thread Anand Mazumdar
://reviews.apache.org/r/37449/#comment150260 micro nit : let's just do Event::HEARTBEAT - Anand Mazumdar On Aug. 13, 2015, 11:23 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37467: Fixed scheduler library to send calls in order.

2015-08-13 Thread Anand Mazumdar
committing this in just to be sure since the last time review bot did seem to show a false positive on r37328 ? src/scheduler/scheduler.cpp (line 382) https://reviews.apache.org/r/37467/#comment150319 Micro nit : How about just CHECK(!calls.empty()) ? - Anand Mazumdar On Aug. 14, 2015, 1:59 a.m

Review Request 37471: Fix EventCallFramework test to not ignore heartbeat events

2015-08-13 Thread Anand Mazumdar
--- See summary and related CR Diffs - src/examples/event_call_framework.cpp 019e5c1f19a9e455b73ea9916b4f4270dad6d3da Diff: https://reviews.apache.org/r/37471/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar

Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
https://issues.apache.org/jira/browse/MESOS-2552 Repository: mesos Description --- Disabled auth from tests Diffs - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing --- Thanks, Anand Mazumdar

Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
Description --- Delete receive handlers ,install call back setups Diffs - src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- Thanks, Anand Mazumdar

Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37303/diff/ Testing --- make check Thanks, Anand Mazumdar

Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
/ Testing --- Thanks, Anand Mazumdar

Review Request 37300: Disabled EventCallFramework test for now

2015-08-10 Thread Anand Mazumdar
02c24c2cd45b3dcb97def605aa735c6efd951943 src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633 Diff: https://reviews.apache.org/r/37300/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37298/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37300: Disabled EventCallFramework test for now

2015-08-10 Thread Anand Mazumdar
manually though. Diffs - src/examples/event_call_framework.cpp 02c24c2cd45b3dcb97def605aa735c6efd951943 src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633 Diff: https://reviews.apache.org/r/37300/diff/ Testing --- Thanks, Anand Mazumdar

Review Request 37304: Add authorization for http based schedulers

2015-08-10 Thread Anand Mazumdar
, Anand Mazumdar

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
: https://reviews.apache.org/r/37301/#review94769 --- On Aug. 10, 2015, 4:44 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- Thanks, Anand Mazumdar

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
and Vinod Kone. Repository: mesos Description --- Delete receive handlers ,install call back setups Diffs - src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Review Request 37328: Remove namespace ambiguity

2015-08-10 Thread Anand Mazumdar
Description --- Remove namespace ambiguity. Needed for r37303 Diffs - src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e Diff: https://reviews.apache.org/r/37328/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
Thanks, Anand Mazumdar

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-10 Thread Anand Mazumdar
53420ca7d503296fbe11b1ea0795afe2ebf86255 src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + adding tests in a different patch. Thanks, Anand Mazumdar

Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
check Thanks, Anand Mazumdar

Re: Review Request 37304: Add authorization for http based schedulers

2015-08-10 Thread Anand Mazumdar
/diff/ Testing --- make check + would add tests in separate patch Thanks, Anand Mazumdar

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
://reviews.apache.org/r/37302/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37328: Remove namespace ambiguity

2015-08-10 Thread Anand Mazumdar
and Vinod Kone. Repository: mesos Description --- Remove namespace ambiguity. Needed for r37303 Diffs - src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e Diff: https://reviews.apache.org/r/37328/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
- src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37335/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
a8699a7514892a548eb03f9dcb6a1198ce518830 Diff: https://reviews.apache.org/r/37298/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
(updated) - src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f Diff: https://reviews.apache.org/r/37301/diff/ Testing (updated) --- make check Thanks, Anand Mazumdar

Re: Review Request 37300: Removed auth from example event call framework

2015-08-10 Thread Anand Mazumdar
. Diffs (updated) - src/examples/event_call_framework.cpp 02c24c2cd45b3dcb97def605aa735c6efd951943 src/tests/event_call_framework_test.sh e42c4e8364076a408b33c894f1f3c6a21e12d1dc Diff: https://reviews.apache.org/r/37300/diff/ Testing --- Thanks, Anand Mazumdar

Re: Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
to oversubscribe? Added. - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94777 --- On Aug. 11, 2015, 12:17 a.m., Anand Mazumdar

Re: Review Request 37489: Make scheduler tests parameterized

2015-08-14 Thread Anand Mazumdar
/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar

Review Request 37491: Added a trivial test on how the protobuf-json string don't match due to incorrect escaping of bytes

2015-08-14 Thread Anand Mazumdar
/tests/protobuf_tests.cpp 018ff51d10f4ba076609704d6e3b2c704c82b016 Diff: https://reviews.apache.org/r/37491/diff/ Testing --- make check Thanks, Anand Mazumdar

Review Request 37489: Make scheduler tests parameterized

2015-08-14 Thread Anand Mazumdar
src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd Diff: https://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

2015-08-14 Thread Anand Mazumdar
- Anand Mazumdar On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/ --- (Updated

Re: Review Request 37489: Make scheduler tests parameterized

2015-08-14 Thread Anand Mazumdar
://reviews.apache.org/r/37489/diff/ Testing --- make check Thanks, Anand Mazumdar

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
Thanks, Anand Mazumdar

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
--- On Aug. 12, 2015, 6:51 a.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303

Re: Review Request 37303: Moved scheduler library to http

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94959 --- On Aug. 11, 2015, 10:18 p.m., Anand Mazumdar wrote

Re: Review Request 37377: Disallow HTTP schedulers when authentication is required.

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37377/#review95029 --- Ship it! LGTM ! - Anand Mazumdar On Aug. 11, 2015, 11:52 p.m

  1   2   3   4   5   6   7   8   9   10   >