Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82745 --- Ship it! LGTM! - Isabel Jimenez On May 6, 2015, 9:32 p.m

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
the framework.), ``` - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
On May 6, 2015, 8:41 p.m., Isabel Jimenez wrote: Besides this, LGTM! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82725 --- Ship it! LGTM! - Isabel Jimenez On May 6, 2015, 5:15 p.m

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
/#comment133530 same as above - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-06-09 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review87264 --- Ship it! Ship It! - Isabel Jimenez On June 1, 2015, 9:02 a.m

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
with new HTTP API endpoints tests. Thanks, Isabel Jimenez

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
and distcheck. Tests will be added with new HTTP API endpoints tests. Thanks, Isabel Jimenez

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

2015-06-25 Thread Isabel Jimenez
/r/35858/#comment141964 Now that we're sending calls in every case (besides SUBSCRIBE) of this switch, I suppose it'll be better to move this to the end and maybe test just for SUBSCRIBE outside the switch? - Isabel Jimenez On June 25, 2015, 12:31 a.m., Vinod Kone wrote

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-25 Thread Isabel Jimenez
/35857/#comment141992 Is the purpose of moving this here to order Call handling methods? if yes, should we move revive too? - Isabel Jimenez On June 25, 2015, 1:11 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail

Review Request 35934: New Not Acceptable HTTP response type

2015-06-26 Thread Isabel Jimenez
, and Vinod Kone. Repository: mesos-incubating Description --- Needed for HTTP API Call validation patches Diffs - 3rdparty/libprocess/include/process/http.hpp 16f0a01 Diff: https://reviews.apache.org/r/35934/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 35934: New Not Acceptable HTTP response type

2015-06-26 Thread Isabel Jimenez
check Thanks, Isabel Jimenez

Re: Review Request 35770: Consistent 'Test' suffix in mesos test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35770/#review89087 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 1:21 p.m

Re: Review Request 35769: Consistent 'Test' suffix in libprocess test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35769/#review89088 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 7:06 a.m

Re: Review Request 35768: Consistent 'Test' suffix in stout test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35768/#review89089 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 7:05 a.m

Re: Review Request 35752: Added stub Event protobuf handler to scheduler driver.

2015-06-23 Thread Isabel Jimenez
/#comment141687 Aren't we using braces on switch cases syntax? like: ``` switch (type) { case ENUM: { break } } ``` - Isabel Jimenez On June 23, 2015, 7:26 p.m., Ben Mahler wrote

Review Request 35939: New Conflict HTTP response type

2015-06-26 Thread Isabel Jimenez
, and Vinod Kone. Repository: mesos-incubating Description --- Needed for HTTP API Call validation patches Diffs - 3rdparty/libprocess/include/process/http.hpp 16f0a01 Diff: https://reviews.apache.org/r/35939/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 35538: [MESOS-1988] Remove unused drop(...) overload

2015-06-16 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35538/#review88137 --- Ship it! Ship It! - Isabel Jimenez On June 16, 2015, 9:44 p.m

Re: Review Request 35506: Excluding MarkDown files from the style hook

2015-06-16 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35506/#review88176 --- Ship it! Ship It! - Isabel Jimenez On June 16, 2015, 11:24 a.m

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Isabel Jimenez
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/ingress.cpp, lines 44-51 https://reviews.apache.org/r/34830/diff/2/?file=975053#file975053line44 Two blank lines between the functions. here and other places. Since the functions are inside a

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-05-30 Thread Isabel Jimenez
reinterpret_cast here? am I missing something that needs changing the bit interpretation of this in the machine? src/linux/routing/queueing/internal.hpp https://reviews.apache.org/r/34830/#comment137666 same as above - Isabel Jimenez On May 29, 2015, 9:57 p.m., Paul Brett wrote

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-06-02 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review86232 --- Ship it! Ship It! - Isabel Jimenez On June 2, 2015, 12:12 p.m

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-29 Thread Isabel Jimenez
be consistent here, either test both cases for all examples or just one. Also test an all upper-case example too? - Isabel Jimenez On May 20, 2015, 7:09 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 35934: New Not Acceptable HTTP response type

2015-07-01 Thread Isabel Jimenez
, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Isabel Jimenez
/master/master.hpp af83d3e src/master/master.cpp 0782b54 src/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36073: New Method Not Allowed HTTP response type

2015-07-01 Thread Isabel Jimenez
, Isabel Jimenez

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89876 --- Ship it! Ship It! - Isabel Jimenez On June 30, 2015, 6:28 a.m

Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Isabel Jimenez
. Repository: mesos-incubating Description --- Adding the possibility to 'keep-alive' the connection Diffs - 3rdparty/libprocess/src/http.cpp 0898335 Diff: https://reviews.apache.org/r/36040/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
/master/master.hpp af83d3e src/master/master.cpp 0782b54 src/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 36072: New Unsupported HTTP response type

2015-06-30 Thread Isabel Jimenez
, and Vinod Kone. Repository: mesos-incubating Description --- Needed for HTTP API Call validation patches Diffs - 3rdparty/libprocess/include/process/http.hpp 16f0a01 Diff: https://reviews.apache.org/r/36072/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
/master/master.hpp af83d3e src/master/master.cpp 0782b54 src/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 36073: New Method Not Allowed HTTP response type

2015-06-30 Thread Isabel Jimenez
, and Vinod Kone. Repository: mesos-incubating Description --- Needed for HTTP API Call validation patches Diffs - 3rdparty/libprocess/include/process/http.hpp 16f0a01 Diff: https://reviews.apache.org/r/36073/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
/master/master.hpp af83d3e src/master/master.cpp 0782b54 src/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90102 --- On July 1, 2015, 7:30 p.m., Isabel Jimenez wrote

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Isabel Jimenez
src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Isabel Jimenez
/tests/call_tests.cpp PRE-CREATION src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 32384: Adding perf check to configure

2015-07-02 Thread Isabel Jimenez
://reviews.apache.org/r/32384/diff/ Testing --- Thanks, Isabel Jimenez

Review Request 36125: Removing '.json' extension in master endpoints url

2015-07-02 Thread Isabel Jimenez
: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez

Review Request 36127: Removing '.json' extension in files endpoints url

2015-07-02 Thread Isabel Jimenez
check Thanks, Isabel Jimenez

Review Request 36126: Removing '.json' extension in slave endpoints url

2015-07-02 Thread Isabel Jimenez
src/webui/master/static/js/controllers.js 3445028 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-02 Thread Isabel Jimenez
src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-02 Thread Isabel Jimenez
src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-02 Thread Isabel Jimenez
src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 36128: Change docker version parsing

2015-07-02 Thread Isabel Jimenez
, Isabel Jimenez

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

2015-07-01 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90110 --- Ship it! Ship It! - Isabel Jimenez On July 1, 2015, 5:28 a.m

Re: Review Request 36072: New Unsupported HTTP response type

2015-07-01 Thread Isabel Jimenez
/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Isabel Jimenez
src/tests/mesos.hpp 9157ac0 Diff: https://reviews.apache.org/r/36037/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36128: Change docker version parsing

2015-07-02 Thread Isabel Jimenez
--- On July 2, 2015, 8:58 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36128

Review Request 36215: Dummy /call endpoint for master

2015-07-06 Thread Isabel Jimenez
/master.cpp c5a4875 src/tests/call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36215/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36205/#review90616 --- Ship it! Ship It! - Isabel Jimenez On July 6, 2015, 3:44 p.m

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
PRE-CREATION src/common/http_validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36217/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
PRE-CREATION src/common/http_validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36217/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

2015-07-06 Thread Isabel Jimenez
/tests/thread_tests.cpp 93339eb 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 Diff: https://reviews.apache.org/r/23784/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-06 Thread Isabel Jimenez
7608455 3rdparty/libprocess/src/tests/time_tests.cpp be31418 3rdparty/libprocess/src/tests/timeseries_tests.cpp 5394d60 3rdparty/libprocess/src/timeseries.cpp 89af8ec Diff: https://reviews.apache.org/r/23783/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

2015-07-06 Thread Isabel Jimenez
/tests/thread_tests.cpp 93339eb 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 Diff: https://reviews.apache.org/r/23784/diff/ Testing --- Thanks, Isabel Jimenez

Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-06 Thread Isabel Jimenez
Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-06 Thread Isabel Jimenez
/watcher.hpp 1e347ed Diff: https://reviews.apache.org/r/23749/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-06 Thread Isabel Jimenez
/watcher.hpp 1e347ed Diff: https://reviews.apache.org/r/23749/diff/ Testing --- Thanks, Isabel Jimenez

Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
PRE-CREATION Diff: https://reviews.apache.org/r/36217/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

2015-06-28 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review89695 --- Ship it! Ship It! - Isabel Jimenez On June 28, 2015, 1:49 p.m

Re: Review Request 36040: Change Server closing connections for every request

2015-07-02 Thread Isabel Jimenez
} In all other cases, we don't want to use the same connection again, and it's fine to send the close header like we are doing. Can you also add @bmahler as a reviewer to confirm this ? Isabel Jimenez wrote: I mostly add this for tests on 36037, this overrides

Re: Review Request 36040: Change Server closing connections for every request

2015-07-02 Thread Isabel Jimenez
--- make check Thanks, Isabel Jimenez

Re: Review Request 36040: Change Server closing connections for every request

2015-07-02 Thread Isabel Jimenez
, Isabel Jimenez

Re: Review Request 37405: Adding HTTP Method check to the scheduler endpoint

2015-08-12 Thread Isabel Jimenez
: https://reviews.apache.org/r/37405/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
aef3c4b Diff: https://reviews.apache.org/r/37403/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
/http_api_tests.cpp aef3c4b Diff: https://reviews.apache.org/r/37403/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-08-22 Thread Isabel Jimenez
Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-08-22 Thread Isabel Jimenez
3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-08-22 Thread Isabel Jimenez
/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make checl Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-08-22 Thread Isabel Jimenez
3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-08-22 Thread Isabel Jimenez
/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing (updated) --- make check Thanks, Isabel Jimenez

Re: Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Isabel Jimenez
otherwise. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/#review89909 --- On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-05 Thread Isabel Jimenez
/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-03 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-04 Thread Isabel Jimenez
/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
://reviews.apache.org/r/36402/#review93970 --- On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-06 Thread Isabel Jimenez
/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
/strings_tests.cpp#L208) - Isabel Jimenez On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94105 --- On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote: --- This is an automatically generated e

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94105 --- On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/http.cpp, line 219 https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219 This will crash the program if tokens is empty! Isabel Jimenez wrote: This will not crash, tokenize will always

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-07 Thread Isabel Jimenez
/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-10 Thread Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94781 --- On Aug. 5, 2015, 7:11 p.m., Isabel Jimenez wrote

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/#review95135 --- On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403

Re: Review Request 37241: Renamed master's /call endpoint to /api/v1/scheduler.

2015-08-07 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37241/#review94595 --- Ship it! Ship It! - Isabel Jimenez On Aug. 7, 2015, 11:44 p.m

Re: Review Request 37240: Added support to handle queries to nested HTTP paths.

2015-08-07 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37240/#review94597 --- Ship it! Ship It! - Isabel Jimenez On Aug. 7, 2015, 11:39 p.m

Re: Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls.

2015-08-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/#review94656 --- Ship it! Ship It! - Isabel Jimenez On Aug. 8, 2015, 3:32 p.m

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-04 Thread Isabel Jimenez
/tests/encoder_tests.cpp 0032137 Diff: https://reviews.apache.org/r/37097/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote: 3rdparty/libprocess/src/http.cpp, line 219 https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219 This will crash the program if tokens is empty! Isabel Jimenez wrote: This will not crash, tokenize will always

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-04 Thread Isabel Jimenez
, 2015, 11:05 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 4, 2015, 11:05 p.m

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-14 Thread Isabel Jimenez
/http.hpp bbd063d src/common/http.cpp 73a4de1 Diff: https://reviews.apache.org/r/36360/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-15 Thread Isabel Jimenez
--- make check Thanks, Isabel Jimenez

Re: Review Request 36402: Adding 'Accept' header in request

2015-07-15 Thread Isabel Jimenez
c5ff761 3rdparty/libprocess/src/http.cpp d168579 3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 3rdparty/libprocess/src/tests/http_tests.cpp 01f243c Diff: https://reviews.apache.org/r/36402/diff/ Testing --- make check Thanks, Isabel Jimenez

  1   2   3   >