the framework.),
```
- Isabel Jimenez
On May 6, 2015, 5:14 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33871
On May 6, 2015, 8:41 p.m., Isabel Jimenez wrote:
Besides this, LGTM!
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33871/#review82727
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33872/#review82725
---
Ship it!
LGTM!
- Isabel Jimenez
On May 6, 2015, 5:15 p.m
/#comment133530
same as above
- Isabel Jimenez
On May 6, 2015, 5:14 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33871
with new HTTP API endpoints tests.
Thanks,
Isabel Jimenez
and distcheck. Tests will be added with new HTTP API endpoints tests.
Thanks,
Isabel Jimenez
/r/35858/#comment141964
Now that we're sending calls in every case (besides SUBSCRIBE) of this
switch, I suppose it'll be better to move this to the end and maybe test just
for SUBSCRIBE outside the switch?
- Isabel Jimenez
On June 25, 2015, 12:31 a.m., Vinod Kone wrote
/35857/#comment141992
Is the purpose of moving this here to order Call handling methods? if yes,
should we move revive too?
- Isabel Jimenez
On June 25, 2015, 1:11 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail
, and
Vinod Kone.
Repository: mesos-incubating
Description
---
Needed for HTTP API Call validation patches
Diffs
-
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/35934/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review89087
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 1:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35769/#review89088
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 7:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/#review89089
---
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 7:05 a.m
/#comment141687
Aren't we using braces on switch cases syntax? like:
```
switch (type) {
case ENUM: {
break
}
}
```
- Isabel Jimenez
On June 23, 2015, 7:26 p.m., Ben Mahler wrote
, and
Vinod Kone.
Repository: mesos-incubating
Description
---
Needed for HTTP API Call validation patches
Diffs
-
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/35939/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35538/#review88137
---
Ship it!
Ship It!
- Isabel Jimenez
On June 16, 2015, 9:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35506/#review88176
---
Ship it!
Ship It!
- Isabel Jimenez
On June 16, 2015, 11:24 a.m
On June 1, 2015, 5:59 p.m., Chi Zhang wrote:
src/linux/routing/queueing/ingress.cpp, lines 44-51
https://reviews.apache.org/r/34830/diff/2/?file=975053#file975053line44
Two blank lines between the functions.
here and other places.
Since the functions are inside a
reinterpret_cast here? am I missing something that needs changing
the bit interpretation of this in the machine?
src/linux/routing/queueing/internal.hpp
https://reviews.apache.org/r/34830/#comment137666
same as above
- Isabel Jimenez
On May 29, 2015, 9:57 p.m., Paul Brett wrote
,
Isabel Jimenez
/master/master.hpp af83d3e
src/master/master.cpp 0782b54
src/tests/call_tests.cpp PRE-CREATION
src/tests/mesos.hpp 9157ac0
Diff: https://reviews.apache.org/r/36037/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36036/#review89876
---
Ship it!
Ship It!
- Isabel Jimenez
On June 30, 2015, 6:28 a.m
.
Repository: mesos-incubating
Description
---
Adding the possibility to 'keep-alive' the connection
Diffs
-
3rdparty/libprocess/src/http.cpp 0898335
Diff: https://reviews.apache.org/r/36040/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/master/master.hpp af83d3e
src/master/master.cpp 0782b54
src/tests/call_tests.cpp PRE-CREATION
src/tests/mesos.hpp 9157ac0
Diff: https://reviews.apache.org/r/36037/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
, and
Vinod Kone.
Repository: mesos-incubating
Description
---
Needed for HTTP API Call validation patches
Diffs
-
3rdparty/libprocess/include/process/http.hpp 16f0a01
Diff: https://reviews.apache.org/r/36072/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/master/master.hpp af83d3e
src/master/master.cpp 0782b54
src/tests/call_tests.cpp PRE-CREATION
src/tests/mesos.hpp 9157ac0
Diff: https://reviews.apache.org/r/36037/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
://reviews.apache.org/r/32384/diff/
Testing
---
Thanks,
Isabel Jimenez
: https://reviews.apache.org/r/36125/diff/
Testing
---
make checl
Thanks,
Isabel Jimenez
check
Thanks,
Isabel Jimenez
src/webui/master/static/js/controllers.js 3445028
src/webui/master/static/js/services.js 2cd9d7d
Diff: https://reviews.apache.org/r/36126/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
src/tests/mesos.hpp 9157ac0
Diff: https://reviews.apache.org/r/36037/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90110
---
Ship it!
Ship It!
- Isabel Jimenez
On July 1, 2015, 5:28 a.m
/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
src/tests/mesos.hpp 9157ac0
Diff: https://reviews.apache.org/r/36037/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/master.cpp c5a4875
src/tests/call_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36215/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36205/#review90616
---
Ship it!
Ship It!
- Isabel Jimenez
On July 6, 2015, 3:44 p.m
PRE-CREATION
src/common/http_validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36217/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
PRE-CREATION
src/common/http_validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36217/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/tests/thread_tests.cpp 93339eb
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0
Diff: https://reviews.apache.org/r/23784/diff/
Testing
---
Thanks,
Isabel Jimenez
7608455
3rdparty/libprocess/src/tests/time_tests.cpp be31418
3rdparty/libprocess/src/tests/timeseries_tests.cpp 5394d60
3rdparty/libprocess/src/timeseries.cpp 89af8ec
Diff: https://reviews.apache.org/r/23783/diff/
Testing
---
Thanks,
Isabel Jimenez
/tests/thread_tests.cpp 93339eb
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0
Diff: https://reviews.apache.org/r/23784/diff/
Testing
---
Thanks,
Isabel Jimenez
Description
---
Adding missing Apache licence header
Diffs
-
3rdparty/libprocess/3rdparty/Makefile.am 519e38c
Diff: https://reviews.apache.org/r/36226/diff/
Testing
---
Thanks,
Isabel Jimenez
/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
---
Thanks,
Isabel Jimenez
/watcher.hpp 1e347ed
Diff: https://reviews.apache.org/r/23749/diff/
Testing
---
Thanks,
Isabel Jimenez
PRE-CREATION
Diff: https://reviews.apache.org/r/36217/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/#review89695
---
Ship it!
Ship It!
- Isabel Jimenez
On June 28, 2015, 1:49 p.m
}
In all other cases, we don't want to use the same connection again, and
it's fine to send the close header like we are doing.
Can you also add @bmahler as a reviewer to confirm this ?
Isabel Jimenez wrote:
I mostly add this for tests on 36037, this overrides
---
make check
Thanks,
Isabel Jimenez
,
Isabel Jimenez
: https://reviews.apache.org/r/37405/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
aef3c4b
Diff: https://reviews.apache.org/r/37403/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/http_api_tests.cpp aef3c4b
Diff: https://reviews.apache.org/r/37403/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
Thanks,
Isabel Jimenez
3445028
Diff: https://reviews.apache.org/r/36127/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/master/static/js/controllers.js 3445028
Diff: https://reviews.apache.org/r/36125/diff/
Testing
---
make checl
Thanks,
Isabel Jimenez
3445028
Diff: https://reviews.apache.org/r/36127/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/js/controllers.js 3445028
Diff: https://reviews.apache.org/r/36125/diff/
Testing (updated)
---
make check
Thanks,
Isabel Jimenez
otherwise.
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36040/#review89909
---
On June 30, 2015, 9:06 a.m., Isabel Jimenez wrote
/encoder_tests.cpp 0032137
Diff: https://reviews.apache.org/r/37097/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/tests/encoder_tests.cpp 0032137
Diff: https://reviews.apache.org/r/37097/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
://reviews.apache.org/r/36402/#review93970
---
On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/tests/encoder_tests.cpp 0032137
Diff: https://reviews.apache.org/r/37097/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
/strings_tests.cpp#L208)
- Isabel Jimenez
On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94105
---
On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94105
---
On Aug. 4, 2015, 5:42 p.m., Isabel Jimenez wrote
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
/tests/encoder_tests.cpp 0032137
Diff: https://reviews.apache.org/r/37097/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37403/#review95135
---
On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote
---
On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37403
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/#review94595
---
Ship it!
Ship It!
- Isabel Jimenez
On Aug. 7, 2015, 11:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37244/#review94656
---
Ship it!
Ship It!
- Isabel Jimenez
On Aug. 8, 2015, 3:32 p.m
/tests/encoder_tests.cpp 0032137
Diff: https://reviews.apache.org/r/37097/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
, 2015, 11:05 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 11:05 p.m
/http.hpp bbd063d
src/common/http.cpp 73a4de1
Diff: https://reviews.apache.org/r/36360/diff/
Testing
---
Thanks,
Isabel Jimenez
---
make check
Thanks,
Isabel Jimenez
c5ff761
3rdparty/libprocess/src/http.cpp d168579
3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137
3rdparty/libprocess/src/tests/http_tests.cpp 01f243c
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
a second one:
2. Given all the accept types mentioned in the Accept header , and
the accept types we support ,is it possible for us to send a response back
? If not send a 415 back.
What do you think ?
Isabel Jimenez wrote:
The AcceptHeader method groups validation that's
3rdparty/libprocess/src/tests/http_tests.cpp 01f243c
Diff: https://reviews.apache.org/r/36402/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
.
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
---
On July 15, 2015, 11:54 p.m., Isabel Jimenez wrote
generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
---
On July 15, 2015, 11:54 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail
Inversed advise here, killed this and made sure above pattern is consistent
everywhere.
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
----
(updated)
-
src/tests/executor_http_api_tests.cpp e429d84
Diff: https://reviews.apache.org/r/38618/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
e6169a0
src/Makefile.am e797dac
src/slave/http.cpp 3f7f71b
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
src/tests/executor_http_api_tests.cpp e429d84
Diff: https://reviews.apache.org/r/38577/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
://reviews.apache.org/r/38844/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
src/Makefile.am e797dac
src/slave/http.cpp 3f7f71b
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
src/tests/executor_http_api_tests.cpp e429d84
Diff: https://reviews.apache.org/r/38577/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
: https://reviews.apache.org/r/38844/diff/
Testing
---
make check
Thanks,
Isabel Jimenez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39708/#review104337
---
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 28, 2015, 4:51 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/#review104339
---
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 28, 2015, 4:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39710/#review104347
---
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 28, 2015, 8:43 p.m
,
Isabel Jimenez
1 - 100 of 215 matches
Mail list logo
