this is merged, just to
double check that it trips properly.
- Jeff Coffler
On March 27, 2017, 5:12 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
b67b512cafd90558abf712a872310ab913fa38ae
Diff: https://reviews.apache.org/r/58014/diff/1/
Testing
---
Testing done at end of chain
Thanks,
Jeff Coffler
on precompiled headers
(the improvement comes regardless of PCH).
Diffs
-
cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143
Diff: https://reviews.apache.org/r/58013/diff/1/
Testing
---
Testing done at end of chain
Thanks,
Jeff Coffler
/windows_ctrlhandler.hpp 25b14a446175cd302d1840b1f542989ef8315018
Diff: https://reviews.apache.org/r/58012/diff/1/
Testing
---
Testing done at end of chain
Thanks,
Jeff Coffler
CMakeLists.txt 0d1e17b863856287b18fd026e1ae71ec35e5ad83
LICENSE f11970cada909e7bbb685f96cb9ef0ff24e01924
Diff: https://reviews.apache.org/r/58011/diff/1/
Testing
---
Testing done at end of chain
Thanks,
Jeff Coffler
)
(Includes speedup to linker flags)
Thanks,
Jeff Coffler
Can you please add a unit test to call this with some basic tests as well
as the specific cases that you found to fail?
- Jeff Coffler
On March 31, 2017, 11:49 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatica
e used?
And, of course, it's in stout, but if stout was better desogmed, it would
be nicer to have a separate implementation rather than inlining code in a bunch
of places.
- Jeff Coffler
On March 31, 2017, 11:45 p.m., Andrew Schwartzmeyer
ran. (77 ms total)
[ PASSED ] 1 test.
Thanks,
Jeff Coffler
> On April 18, 2017, 8:30 p.m., Jeff Coffler wrote:
> > Big change, but important for us.
> >
> > I'd like you to comment on using cmake for zookeeper, specifically in terms
> > of rolling that back to Zookeeper themselves for them to maintain it.
> >
&g
> On April 18, 2017, 8:19 p.m., Jeff Coffler wrote:
> > Ship It!
>
> Andrew Schwartzmeyer wrote:
> Hey, just wondering, why'd you give a "Ship It!" here, but then went back
> to patches earlier in the chain and asked for test results (provided in the
>
rated e-mail. To reply, visit:
https://reviews.apache.org/r/58247/#review171271
-------
On April 6, 2017, 9:25 p.m., Jeff Coffler wrote:
>
> ---
> This is
the review.
What, specifically, did you test on to insure that nothing was broken by this
change?
- Jeff Coffler
On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To rep
for testing, leading
me to believe that no testing was done.
Please clarify the testing that you completed here, so I can understand that.
Thanks.
- Jeff Coffler
On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58449/#review172258
---
Ship it!
Ship It!
- Jeff Coffler
On April 14, 2017, 2:10
specific sources,
etc) if they aren't maintaining it, and I'd rather not own this for life. If
the Zookeeper folks don't want to maintain this, what do they say about VS 2017
support? Even if it's not cmake, but a hand-generated solution for V/S, at
least they maintain it, not us.
- Jeff Coffler
off on upgrading VS
myself to insure that this works properly ...
- Jeff Coffler
On April 13, 2017, 10:03 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58446/#review172813
---
Ship it!
Ship It!
- Jeff Coffler
On April 14, 2017, 2:03
that this change would be problematic on Linux.
Thanks,
Jeff Coffler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58447/#review172812
---
Ship it!
Ship It!
- Jeff Coffler
On April 14, 2017, 2:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58448/#review172809
---
Ship it!
Ship It!
- Jeff Coffler
On April 19, 2017, 6:20
://reviews.apache.org/r/60620/diff/1/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d
Diff: https://reviews.apache.org/r/60622/diff/1/
Testing
---
See upstream
Thanks,
Jeff Coffler
42980f5a4a40b72f754156469e9fe60a952d1d87
src/tests/CMakeLists.txt 9c0acaf43f451dbc9ba5077529a36aa4cef40c34
src/tests/hdfs_tests.cpp e7154c75e663d9a98bec48be42a59b65c96f9515
Diff: https://reviews.apache.org/r/60624/diff/1/
Testing
---
See upstream
Thanks,
Jeff Coffler
m
Thanks,
Jeff Coffler
/60626/diff/1/
Testing
---
See upstream
Thanks,
Jeff Coffler
://reviews.apache.org/r/60625/diff/1/
Testing
---
See upstream
Thanks,
Jeff Coffler
e3c786b36ad16b33ef9d3eed15f722890e80f0bb
src/tests/fetcher_tests.cpp 99149baa1c7abfabf572a0d0f4512a8e84d1e5be
Diff: https://reviews.apache.org/r/60628/diff/1/
Testing
---
See upstream.
Thanks,
Jeff Coffler
and Linux.
Thanks,
Jeff Coffler
one line per test case). I can add
whatever you'd like if Joe wants me to.
- Jeff
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58673/#review173000
---
On April 25, 2017, 6:24 p.m., Jeff Coffler wrote:
nment tear-down
[==] 2 tests from 1 test case ran. (6 ms total)
[ PASSED ] 2 tests.
YOU HAVE 4 DISABLED TESTS
PS C:\mesos>
Thanks,
Jeff Coffler
ing with Jeff. It seems to be the most readable.
> >
> > For what it's worth, we also tried `std::regex`, and profiled it. Even
> > in release mode with explicit optimization, it was 70x slower.
>
> Jeff Coffler wrote:
> Yeah. Before this, the code was essentia
use `path::absolute`, we shouldn't change it.
>
> Instead (in a separate patch, and only if you want to), we should simply
> `#ifndef __WINDOWS__` the entire conditional and the body of the if-statement.
>
> Jeff Coffler wrote:
> I don't qui
-] 2 tests from PathTest (2 ms total)
[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (6 ms total)
[ PASSED ] 2 tests.
YOU HAVE 4 DISABLED TESTS
PS C:\mesos>
Thanks,
Jeff Coffler
ix
[ OK ] FlagsFileTest.FilePrefix (3 ms)
[--] 1 test from FlagsFileTest (3 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (7 ms total)
[ PASSED ] 1 test.
PS C:\mesos\mesos>
Thanks,
Jeff Coffler
)
<https://reviews.apache.org/r/59248/#comment248081>
You need a similar change on line 1893. Other than that, this works fine.
- Jeff Coffler
On May 12, 2017, 10:43 p.m., Alexander Rukletsov wrote:
>
> ---
> This is a
)
<https://reviews.apache.org/r/59200/#comment247942>
Oops, I added this comment at the last minute, neglecting to notice that I
had the comment at line 40-41 on this same issue.
I'll post an update to this commit to get rid of this.
- Jeff Coffler
On May 11, 2017, 8:13 p.m.
3rdparty/stout/include/stout/windows/net.hpp
1bed115cb848332bf9c31e455b2d001c173face9
Diff: https://reviews.apache.org/r/59200/diff/2/
Changes: https://reviews.apache.org/r/59200/diff/1-2/
Testing
---
See final commit for tests performed.
Thanks,
Jeff Coffler
://reviews.apache.org/r/59202/diff/1-2/
Testing
---
See final commit for tests performed.
Thanks,
Jeff Coffler
), and
2. Cmake built successfully (cmake -j6 check).
I'll be careful to check autotools in the future, particularly when adding
files.
Note that a few lines had line continution not lining up. I resolved those for
consistency with the rest of the file.
Thanks,
Jeff Coffler
for
consistency with the rest of the file.
Thanks,
Jeff Coffler
for tests performed.
Thanks,
Jeff Coffler
from NetTest (19 ms total)
Thanks,
Jeff Coffler
)**
[ RUN ] NetTest.ConstructMAC
[ OK ] NetTest.ConstructMAC (1 ms)
[ RUN ] NetTest.ParseMAC
[ OK ] NetTest.ParseMAC (1 ms)
[--] 8 tests from NetTest (19 ms total)
Thanks,
Jeff Coffler
/mac.hpp PRE-CREATION
3rdparty/stout/include/stout/windows/mac.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/59202/diff/1/
Testing
---
See final commit for tests performed.
Thanks,
Jeff Coffler
performed.
Thanks,
Jeff Coffler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59155/#review174555
---
Ship it!
Ship It!
- Jeff Coffler
On May 10, 2017, 8:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59156/#review174556
---
Ship it!
Ship It!
- Jeff Coffler
On May 10, 2017, 8:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59157/#review174558
---
Ship it!
Ship It!
- Jeff Coffler
On May 10, 2017, 8:37 p.m
uld have sworn I looked at the command lines. But I guess not. Or
I did but a last-minute change broke it.
- Jeff Coffler
On May 10, 2017, 8:59 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail.
e
for one or more tests to fail today, it's annoying that windows-build.bat isn't
as good as Linux in this regard.
- Jeff Coffler
On May 10, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59557/#review176022
---
Ship it!
Ship It!
- Jeff Coffler
On May 24, 2017, 11:37 p.m
hes go in?
- Jeff Coffler
On May 24, 2017, 11:38 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59556/#review176085
---
Ship it!
Ship It!
- Jeff Coffler
On May 24, 2017, 11:38 p.m
ent tear-down
[==] 1 test from 1 test case ran. (7 ms total)
[ PASSED ] 1 test.
PS C:\mesos\mesos>
Thanks,
Jeff Coffler
] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (0 ms)
[--] 2 tests from FlagsFileTest (0 ms total)
Thanks,
Jeff Coffler
own
[==] 2 tests from 1 test case ran. (6 ms total)
[ PASSED ] 2 tests.
YOU HAVE 4 DISABLED TESTS
PS C:\mesos>
Thanks,
Jeff Coffler
ase ran. (6 ms total)
[ PASSED ] 2 tests.
YOU HAVE 4 DISABLED TESTS
PS C:\mesos>
Thanks,
Jeff Coffler
2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/2/
Changes: https://reviews.apache.org/r/60626/diff/1-2/
Testing
---
See upstream
Thanks,
Jeff Coffler
a4bf430
src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd
Diff: https://reviews.apache.org/r/60623/diff/2/
Changes: https://reviews.apache.org/r/60623/diff/1-2/
Testing
---
See upstream
Thanks,
Jeff Coffler
://reviews.apache.org/r/60624/diff/1-2/
Testing
---
See upstream
Thanks,
Jeff Coffler
/diff/1-2/
Testing
---
See upstream.
Thanks,
Jeff Coffler
6ee3a44cd6a878fe383aa68df40b82857b93d0b4
Diff: https://reviews.apache.org/r/60625/diff/2/
Changes: https://reviews.apache.org/r/60625/diff/1-2/
Testing
---
See upstream
Thanks,
Jeff Coffler
many places (including other modules), and I'd
like to fix that issue all at once.
- Jeff
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review182972
--
/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60622/diff/2/
Changes: https://reviews.apache.org/r/60622/diff/1-2/
Testing
---
See upstream
Thanks,
Jeff Coffler
and Linux.
Thanks,
Jeff Coffler
taking his changes as is.
Thanks,
Jeff Coffler
and it's already part of the base class:
> > https://github.com/apache/mesos/blob/72752fc6deb8ebcbfbd5448dc599ef3774339d31/3rdparty/stout/include/stout/tests/utils.hpp#L64
>
> Jeff Coffler wrote:
> This is an option in the base class, not the actual string. Simply
> removing the line
it:
https://reviews.apache.org/r/60620/#review188007
---
On Oct. 11, 2017, 11:29 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To rep
That last parameter is the number of errors. It's zero on Windows because
PowerShell doesn't consider CRC errors to be an error.
- Jeff
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review1
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review187345
-------
On Oct. 11, 2017, 11:32 p.m., Jeff Coffler wrote:
>
> ---
> This is an auto
ews.apache.org/r/60626/diff/2/?file=1847164#file1847164line130>
> >
> > `s/f_status/status.get()/g`.
> >
> > We probably don't need to stringify and return the exit status.
>
> Jeff Coffler wrote:
> I actually got the error during testing (d
On Oct. 8, 2017, 3:37 a.m., Jeff Coffler wrote:
> > These changes in spirit are fine, but I don't like how the URI conversion
> > has to be done at all. It should be as simple as `uri::from_path(input)`.
That's exactly what I ultimately d
> > Pre-processor directives should always start at the beginning of the
> > line
> > (https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives).
Hey, I didn't know that. Google's style guide == Mesos style guide?
> On Oct. 8, 2017, 3:27 a.m., Andre
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review187349
---
On Oct. 11, 2017, 11:31 p.m., Jeff Coffler wrote:
>
> -
the base class, not the actual string. Simply removing the
line caused compilation problems.
Note that I got this pattern from other consumers of the base class ...
- Jeff
---
This is an automatically generated e-mail. To reply,
df9d2d9586a6457004506c4e2a972ccfc912c7c5
Diff: https://reviews.apache.org/r/60628/diff/4/
Changes: https://reviews.apache.org/r/60628/diff/3-4/
Testing
---
See upstream.
Thanks,
Jeff Coffler
: https://reviews.apache.org/r/60624/diff/4/
Changes: https://reviews.apache.org/r/60624/diff/3-4/
Testing
---
See upstream
Thanks,
Jeff Coffler
2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/4/
Changes: https://reviews.apache.org/r/60626/diff/3-4/
Testing
---
See upstream
Thanks,
Jeff Coffler
623/diff/4/
Changes: https://reviews.apache.org/r/60623/diff/3-4/
Testing
---
See upstream
Thanks,
Jeff Coffler
-CREATION
Diff: https://reviews.apache.org/r/60621/diff/4/
Changes: https://reviews.apache.org/r/60621/diff/3-4/
Testing
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
://reviews.apache.org/r/60620/diff/5/
Changes: https://reviews.apache.org/r/60620/diff/4-5/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
/tests/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60622/diff/4/
Changes: https://reviews.apache.org/r/60622/diff/3-4/
Testing
---
See upstream
Thanks,
Jeff Coffler
t; URI prefix will not trigger an error.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review188003
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review188002
-------
On Oct. 17, 2017, 1:18 a.m., Jeff Coffler wrote:
>
>
----------
On July 5, 2017, 5:43 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
8d881ab7ac571dea7aace269332a856feb7a6c43
3rdparty/stout/tests/os/copyfile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60621/diff/1/
Testing (updated)
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
y this ran on Windows too, and was #ifdef'ed. Resolved.
- Jeff
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60621/#review182914
--
e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review182967
-------
On July 3, 2017, 7:30 p.m., Jeff Coffler wrote:
>
> ---
> This is an aut
/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76
src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5
Diff: https://reviews.apache.org/r/60628/diff/3/
Changes: https://reviews.apache.org/r/60628/diff/2-3/
Testing
---
See upstream.
Thanks,
Jeff Coffler
Thanks,
Jeff Coffler
a4bf430
src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd
Diff: https://reviews.apache.org/r/60623/diff/3/
Changes: https://reviews.apache.org/r/60623/diff/2-3/
Testing
---
See upstream
Thanks,
Jeff Coffler
from HDFS for Windows compatibility.
Diffs (updated)
-
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/3/
Changes: https://reviews.apache.org/r/60626/diff/2-3/
Testing
---
See upstream
Thanks,
Jeff Coffler
/uri_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60622/diff/3/
Changes: https://reviews.apache.org/r/60622/diff/2-3/
Testing
---
See upstream
Thanks,
Jeff Coffler
and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
://reviews.apache.org/r/60621/diff/2-3/
Testing
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
/60620/diff/7/
Changes: https://reviews.apache.org/r/60620/diff/6-7/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
623/diff/6/
Changes: https://reviews.apache.org/r/60623/diff/5-6/
Testing
---
See upstream
Thanks,
Jeff Coffler
Diff: https://reviews.apache.org/r/60621/diff/6/
Changes: https://reviews.apache.org/r/60621/diff/5-6/
Testing
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
/60620/diff/6/
Changes: https://reviews.apache.org/r/60620/diff/5-6/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
1 - 100 of 190 matches
Mail list logo
