Review Request 37531: MESOS-3070

2015-08-17 Thread Klaus Ma
/r/37531/diff/ Testing --- Draft code diff, will update UT cases later. Thanks, Klaus Ma

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Klaus Ma
/r/37657/#comment151215 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all traffic from docker bridge interface. Example: ``` iptables -A INPUT -s 172.17.0.0/16 -i docker0 -p tcp -j ACCEPT ``` - Klaus Ma

Re: Review Request 37531: MESOS-3070

2015-08-20 Thread Klaus Ma
, will update UT cases later. Thanks, Klaus Ma

Re: Review Request 37531: MESOS-3070

2015-08-20 Thread Klaus Ma
/37531/#comment150763 Yes; the TaskID will send back to framework by statusUpdate, so framework can use the UUID to kill a task which is not included in taskTag logic. - Klaus Ma On 八月 17, 2015, 1:28 p.m., Klaus Ma wrote

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Klaus Ma
On 八月 21, 2015, 1:26 a.m., Klaus Ma wrote: docs/docker-containerizer.md, line 21 https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-30 Thread Klaus Ma
/ --- (Updated July 30, 2015, 4:37 p.m.) Review request for mesos, Bernd Mathiske and Klaus Ma. Bugs: MESOS-3023 https://issues.apache.org/jira/browse/MESOS-3023 Repository: mesos Description --- Factored out

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-04 Thread Klaus Ma
On Aug. 4, 2015, 11:03 p.m., Niklas Nielsen wrote: src/slave/slave.cpp, lines 2720-2721 https://reviews.apache.org/r/37053/diff/2/?file=1028868#file1028868line2720 What do you think about emitting a warning if the executor id is already set? It could be, that users have been

Review Request 37168: MESOS-3063

2015-08-06 Thread Klaus Ma
(0x7f23f610d700):ZOO_INFO@zookeeper_close@2505: Closing zookeeper sessionId=0x34da910aab20058 to [9.111.159.76:2181] Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063

2015-08-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review95227 --- On 八月 6, 2015, 8:03 a.m., Klaus Ma wrote: --- This is an automatically generated e

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
--- On July 18, 2015, 9:47 a.m., Klaus Ma wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
--- On July 18, 2015, 9:47 a.m., Klaus Ma wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
On July 24, 2015, 2:01 p.m., Klaus Ma wrote: If you don't get to them first, I will fix the remaining little style suggestions when committing. OK, please help to fix it. I'll learn it from the final code :). Thanks very much. - Klaus

Re: Review Request 36501: MESOS-3023

2015-07-17 Thread Klaus Ma
. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92033 --- On July 17, 2015, 2:06 p.m., Klaus Ma wrote

Re: Review Request 36501: MESOS-3023

2015-07-16 Thread Klaus Ma
--- On July 16, 2015, 5:47 a.m., Klaus Ma wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501

Re: Review Request 36501: MESOS-3023

2015-07-16 Thread Klaus Ma
/#review91706 --- On July 16, 2015, 5:47 a.m., Klaus Ma wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501

Re: Review Request 36501: MESOS-3023

2015-07-15 Thread Klaus Ma
/diff/ Testing --- 1. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-15 Thread Klaus Ma
/diff/ Testing --- 1. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-15 Thread Klaus Ma
/#review91823 --- On July 16, 2015, 4:41 a.m., Klaus Ma wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501

Re: Review Request 36501: MESOS-3023

2015-07-14 Thread Klaus Ma
f2eed2e6fbc2cc8772c642bba976b25b426784e8 Diff: https://reviews.apache.org/r/36501/diff/ Testing --- 1. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Review Request 36501: MESOS-3023

2015-07-14 Thread Klaus Ma
in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-17 Thread Klaus Ma
. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-17 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92108 --- On 七月 17, 2015, 4:13 p.m., Klaus Ma wrote

Re: Review Request 36501: MESOS-3023

2015-07-18 Thread Klaus Ma
. Build successfully in Linux 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest Thanks, Klaus Ma

Re: Review Request 36501: MESOS-3023

2015-07-15 Thread Klaus Ma
. In C++11, it only introduced extern template to avoid duplicated template instance. src/tests/utils.hpp (line 55) https://reviews.apache.org/r/36501/#comment145335 Do you mean ident of parameters? - Klaus Ma On July 15, 2015, 2:59 a.m., Klaus Ma wrote

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-10-24 Thread Klaus Ma
ster's checking; it's allocator's resposibility to accept or reject it. - Klaus Ma On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103909 --- Ship it! Ship It! - Klaus Ma On Oct. 21, 2015, 8:52 p.m

Re: Review Request 39285: Added Quota Request Validation.

2015-10-24 Thread Klaus Ma
che.org/r/39285/#comment162034> It said the role maybe not set in allocator interface's comments (`setQuota`); so any case that the role passed validation in master but it's still empty to allocator? - Klaus Ma On Oct. 25, 2015, 3:42 a.m.,

Re: Review Request 38580: Added docker registry RemotePuller

2015-10-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review103930 --- Please link this RR to ticket. - Klaus Ma On Oct. 24, 2015, 12

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-26 Thread Klaus Ma
tps://reviews.apache.org/r/39401/#comment162203> Just check the code, dynamically reserved resource are included in allocation. - Klaus Ma On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote: > > --- > This is a

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-26 Thread Klaus Ma
to another `foreach slaveIds` loop, so we did not need to lay aside resources. - Klaus Ma On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-10-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review103888 --- Ship it! Ship It! - Klaus Ma On Oct. 24, 2015, 12:38 a.m

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Klaus Ma
> On Oct. 21, 2015, 3:02 p.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > <https://reviews.apache.org/r/38627/diff/2/?file=1101800#file1101800line94> > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > >

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105668 --- Ship it! Ship It! - Klaus Ma On Nov. 9, 2015, 8:51 p.m., Joerg

Re: Review Request 39285: Added Quota Request Validation.

2015-11-09 Thread Klaus Ma
> On Nov. 7, 2015, 12:19 a.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 140 > > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line140> > > > > Suggest to move it into the loop; if any role is not known by master, > &g

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-08 Thread Klaus Ma
PRE-CREATION src/tests/dynamic_reservation_framework_test.sh PRE-CREATION src/tests/examples_tests.cpp 3f56b30 src/tests/flags.hpp 984cd4a src/tests/script.cpp d2280c2 Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-16 Thread Klaus Ma
/40375/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

2015-11-16 Thread Klaus Ma
/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee Diff: https://reviews.apache.org/r/40379/diff/ Testing --- make (make check is on-going) Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-09 Thread Klaus Ma
t; > <https://reviews.apache.org/r/37168/diff/5/?file=1072550#file1072550line155> > > > > I think we don't need this since we have: > > > > ``` > > os::setenv("MESOS_ROLES", flags.role.get()); > > ```

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-09 Thread Klaus Ma
PRE-CREATION src/tests/dynamic_reservation_framework_test.sh PRE-CREATION src/tests/examples_tests.cpp 3f56b30 Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-07 Thread Klaus Ma
> On Oct. 26, 2015, 10:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1004> > > > > Just check the code, dynamically reserved resource are inclu

Re: Review Request 39400: Quota: Implemented quota API.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105575 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 2:25 a.m

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-11-04 Thread Klaus Ma
6e91 src/tests/script.cpp bcc1fab src/tests/slave_tests.cpp 91dbdba src/usage/main.cpp 86fd796 Diff: https://reviews.apache.org/r/38335/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-11-04 Thread Klaus Ma
/libprocess/3rdparty/stout ./boostrap ./configure make Thanks, Klaus Ma

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-11-06 Thread Klaus Ma
org/r/36913/#comment164016> It seems other feature named file without "_handler"; any consideration for it? - Klaus Ma On Nov. 3, 2015, 9:55 p.m., Joerg Schad wrote: > > --- > This is an automatically generate

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review105427 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 2:23 a.m

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-06 Thread Klaus Ma
> On Oct. 25, 2015, 8:10 a.m., Klaus Ma wrote: > > include/mesos/master/allocator.hpp, line 358 > > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line358> > > > > It said Mesos master will also validate the quota request in design >

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105431 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 3:29 a.m

Re: Review Request 39285: Added Quota Request Validation.

2015-11-06 Thread Klaus Ma
ue to check others. src/master/quota_handler.cpp (line 174) <https://reviews.apache.org/r/39285/#comment164046> Should we move it into `validateQuotaRequest`? If any role is exist in master, we did not need to continue to check others. And in QuotaHandler, we had the pointer to master `Ma

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-11-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39317/#review105420 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 3:28 a.m

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-11-03 Thread Klaus Ma
visit: https://reviews.apache.org/r/38335/#review103655 ------- On Oct. 20, 2015, 1:37 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-11-03 Thread Klaus Ma
src/tests/resources_tests.cpp 6584fc6 src/tests/scheduler_http_api_tests.cpp b6f6e91 src/tests/script.cpp bcc1fab src/tests/slave_tests.cpp 91dbdba src/usage/main.cpp 86fd796 Diff: https://reviews.apache.org/r/38335/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-18 Thread Klaus Ma
indent are in the strings, do you mean we should move it out? - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review103078 ---------

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-16 Thread Klaus Ma
/libprocess/3rdparty/stout ./boostrap ./configure make Thanks, Klaus Ma

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-10-19 Thread Klaus Ma
check Thanks, Klaus Ma

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-19 Thread Klaus Ma
Ma On Oct. 20, 2015, 2:39 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38342/ > --- >

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-10-19 Thread Klaus Ma
ated to test only, so keep it in test module for now. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review100961 ------

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-19 Thread Klaus Ma
/libprocess/3rdparty/stout ./boostrap ./configure make Thanks, Klaus Ma

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-21 Thread Klaus Ma
n` parameter to create instead of a new function. Such as static Try<T*> create(const std::string& moduleName, const Option& params) - Klaus Ma On Oct. 20, 2015, 9:52 p.m., Alexander Rojas wrote: > > --- >

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

2015-10-06 Thread Klaus Ma
} > > ``` > > > > Then the snippet above could be rewritten as: > > ``` > > object.values["network_infos"] = > > std::move(JSON::protobuf(status.network_infos(), [](const NetworkInfo& > > info) { return model(info); }); > >

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

2015-10-06 Thread Klaus Ma
Any comments? - Klaus Ma On Oct. 6, 2015, 10:07 p.m., Mandeep Chadha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-08 Thread Klaus Ma
> s/failed/ failed/ 3rdparty/libprocess/src/poll_socket.cpp (line 218) <https://reviews.apache.org/r/39154/#comment159529> Can we pass `this` as parameter? So all info are there in `socket_send_data`; I'd like to leave this to your shepherd. - Klaus Ma On

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102003 --- BTW, please add your shepherd into pepole field. - Klaus Ma

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

2015-11-17 Thread Klaus Ma
ps://reviews.apache.org/r/40375/#review106898 ------- On Nov. 17, 2015, 11:30 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 37531: MESOS-3070

2015-08-28 Thread Klaus Ma
/master/master.cpp 95207d2 src/tests/master_tests.cpp 8a6b98b Diff: https://reviews.apache.org/r/37531/diff/ Testing (updated) --- make make check Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063

2015-08-26 Thread Klaus Ma
] ExamplesTest.DynamicReservationFramework (0 ms) -- Klaus Ma (马达) | PMP | kl...@cguru.net

Re: Review Request 37168: MESOS-3063

2015-08-26 Thread Klaus Ma
Thanks, Klaus Ma

Re: Review Request 38102: MESOS-3046

2015-09-03 Thread Klaus Ma
e90dabb0c572923a50490ecb17867dc50c6d161d Diff: https://reviews.apache.org/r/38102/diff/ Testing --- make make check Thanks, Klaus Ma

Review Request 38102: MESOS-3046

2015-09-03 Thread Klaus Ma
Thanks, Klaus Ma

Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id)

2015-09-04 Thread Klaus Ma
make make check Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-04 Thread Klaus Ma
6b30 src/tests/flags.hpp 3644956 src/tests/script.cpp bcc1fab Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-05 Thread Klaus Ma
bcc1fab Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-07 Thread Klaus Ma
g/r/38165/#comment154086> Should we provide UT for this fix? please refer to the other test in "src/tests". - Klaus Ma On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote: > > --- > This is an automatically generate

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-08 Thread Klaus Ma
Hi Michael, Do you have more comments about this example? On 2015年09月06日 21:28, Klaus Ma wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote: src/Makefile.am

Review Request 38201: [MESOS-1187] precision errors with allocation calculations

2015-09-08 Thread Klaus Ma
2ae93a9c8235e5e4643539d409df51c39c6d7e56 Diff: https://reviews.apache.org/r/38201/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38003: MESOS-3351

2015-09-01 Thread Klaus Ma
/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 Diff: https://reviews.apache.org/r/38003/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

2015-09-06 Thread Klaus Ma
g/r/37622/#comment153950> Should be LostSlaveMessage? - Klaus Ma On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-06 Thread Klaus Ma
ne 281 > > <https://reviews.apache.org/r/37168/diff/4/?file=1064720#file1064720line281> > > > > s/get/receives OK :). - Klaus --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
che.org/r/38003/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)

2015-09-04 Thread Klaus Ma
tasks are not necessary, both of them are removed. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97785 --- On Sept. 5, 2015, 2:

Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)

2015-09-04 Thread Klaus Ma
tout/include/stout/uuid.hpp e90dabb0c572923a50490ecb17867dc50c6d161d Diff: https://reviews.apache.org/r/38102/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063

2015-09-02 Thread Klaus Ma
On Aug. 28, 2015, 3:31 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > --- &

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-02 Thread Klaus Ma
outSomePings & PingTimeoutNoPings; are those UT cases impacted? If so please help to update accordingly; and please also help to check the other UT cases about PING/PONG message, I'd not go through all slave UT cases. - Klaus Ma On Sept. 2, 2015, 12:11 p.m., Yong

Review Request 38253: [MESOS-2875] Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-10 Thread Klaus Ma
make check Thanks, Klaus Ma

Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
--- make make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-12 Thread Klaus Ma
t's essentialy a copy & paste of the same code above. > > > > so long as it was only a couple of lines of code (maybe) it made sense > > to repeat it - here, it seems redundant. > > > > (and, obviously, same comments apply) > > Klaus Ma w

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-12 Thread Klaus Ma
Diff: https://reviews.apache.org/r/38259/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-12 Thread Klaus Ma
/flags_tests.cpp ebf8cd6 Diff: https://reviews.apache.org/r/38259/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-13 Thread Klaus Ma
general approach, I'd suggest however to stick with current > > behavior, to avoid breaking stuff that is currently working just fine (and > > relying on the executable to error out in case of misconfigurations). > > Klaus Ma wrote: > I used @haosdent's suggestion as fo

Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-09-13 Thread Klaus Ma
9c0d31e src/master/http.cpp 73e8857 src/slave/containerizer/mesos/containerizer.cpp 1b83a87 src/tests/reservation_endpoints_tests.cpp dfab497 Diff: https://reviews.apache.org/r/38335/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-14 Thread Klaus Ma
ramework.cpp (line 184) <https://reviews.apache.org/r/37168/#comment155423> Done src/examples/dynamic_reservation_framework.cpp (line 281) <https://reviews.apache.org/r/37168/#comment155426> Done src/examples/dynamic_reservation_framework.cpp (line 283) <https://reviews.apache.org/r

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-14 Thread Klaus Ma
/dynamic_reservation_framework.cpp PRE-CREATION src/tests/dynamic_reservation_framework_test.sh PRE-CREATION src/tests/examples_tests.cpp 3f56b30 src/tests/flags.hpp 06da36d src/tests/script.cpp bcc1fab Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-09-14 Thread Klaus Ma
5e5522e1254a5ed6084de36782753f9aad2894c4 src/tests/oversubscription_tests.cpp 0c5edafc139d9bfb6806d007a0af85e80893bb1a Diff: https://reviews.apache.org/r/38253/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
> On Sept. 10, 2015, 4:40 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 569 > > <https://reviews.apache.org/r/38259/diff/1/?file=1067198#file1067198line569> > > > > Is it possible to change to

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-10 Thread Klaus Ma
s it. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98410 --- On Sept. 11, 2015, 2:43

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-11 Thread Klaus Ma
ebf8cd6 Diff: https://reviews.apache.org/r/38259/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-11 Thread Klaus Ma
... return Error(strings::format(dup_err_msg, name)); And re-check those two log/function, it seems we can re-use some logic: in `FlagsBase::load(... const char* const* argv ...)`, dump `argv` and call `FlagsBase::load(... char*** argv ...)` to load the flags, the args that are

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-14 Thread Klaus Ma
rated e-mail. To reply, visit: https://reviews.apache.org/r/38259/#review98983 ------- On Sept. 13, 2015, 5:30 a.m., Klaus Ma wrote: > > --- > This is an automatically gen

  1   2   3   4   5   6   7   >