Review Request 60095: Add filtering feature for unversioned /master/slaves endpoint.

st_filter=MasterTest.SlavesEndpointQuerySlave --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Review Request 60107: Add class definition for ObjectFilter.

://reviews.apache.org/r/60107/diff/1/ Testing --- Passed "make check" No specific test case related Thanks, Quinn Leng

Re: Review Request 60107: Add class definition for ObjectFilter.

/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 Diff: https://reviews.apache.org/r/60107/diff/2/ Changes: https://reviews.apache.org/r/60107/diff/1-2/ Testing --- Passed "make check" No specific test case related Thanks, Quinn Leng

Re: Review Request 60107: Add class definition for ObjectFilter.

167dce2b9a2d3b68a1df5b4079f701482d34db28 Diff: https://reviews.apache.org/r/60107/diff/3/ Changes: https://reviews.apache.org/r/60107/diff/2-3/ Testing --- Passed "make check" No specific test case related Thanks, Quinn Leng

Re: Review Request 60107: Add class definition for ObjectFilter.

98899a789610add924a7d2c0af943230cf914d2d Diff: https://reviews.apache.org/r/60107/diff/4/ Changes: https://reviews.apache.org/r/60107/diff/3-4/ Testing --- Passed "make check" No specific test case related Thanks, Quinn Leng

Review Request 60279: Add constructor for ObjectApprover::Object.

src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c Diff: https://reviews.apache.org/r/60279/diff/1/ Testing --- Passed "make check -j48" No specific test case related. Thanks, Quinn Leng

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

://reviews.apache.org/r/60279/diff/1-2/ Testing --- Passed "make check -j48" No specific test case related. Thanks, Quinn Leng

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

e.org/r/60107/diff/4-5/ Testing (updated) --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

t; > ``` Even if there are only two parameters? - Quinn --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179132 --- On June 27,

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

7/diff/6-7/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

7/diff/7-8/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

y->values.size() == 1); > > ``` taskArray.isSome() is to avoid it's null, but the EXPECT_TRUE check it's size is 1, does that make sense? - Quinn --- This is an automatically generated e-mail. To

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

7/diff/8-9/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

/diff/9-10/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179215 --- On June 29, 2017, 12:47 a.m., Quinn Leng wrote: > > --- > This is an automatically generated

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

diff/10-11/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

ea Diff: https://reviews.apache.org/r/60107/diff/11/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Review Request 60580: Added filtering to the '/frameworks' endpoint.

;GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Review Request 60581: Added filtering to the '/slaves' endpoint.

os-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

ed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

rg/r/60107/diff/11-12/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

diff/12-13/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

diff/13-14/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

diff/14-15/ Testing --- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

60581/diff/2-3/ Testing --- Passed 'make check -j48' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

--gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179488 --- On June 30, 2017, 11:57 p.m., Quinn Leng wrote: > > ---

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

erySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

ssed 'make check -j48' Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

-------- On June 30, 2017, 11:57 p.m., Quinn Leng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60107/ > -

Review Request 60712: Added filtering support for '/slave/containers' endpoint.

.org/r/60712/diff/1/ Testing --- Passed 'make check -j48' Passed 'GLOG_v=1 ./bin/mesos-test.sh --gtest_filter=SlaveTest.ContainersEndpoint --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

://reviews.apache.org/r/60279/diff/3/ Changes: https://reviews.apache.org/r/60279/diff/2-3/ Testing (updated) --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

700871e1502a65b0bb1fc31219e09219dbdb5340 Diff: https://reviews.apache.org/r/60279/diff/4/ Changes: https://reviews.apache.org/r/60279/diff/3-4/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Review Request 60716: Cleaned up authentication acceptor to have one class.

fdb591eccf273260902f3f695cf431f72ee3d817 src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a Diff: https://reviews.apache.org/r/60716/diff/1/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

ges: https://reviews.apache.org/r/60716/diff/1-2/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

;GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

uot;MasterTest.FrameworksEndpointQueryFramework" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60712: Added filtering support for '/slave/containers' endpoint.

42aa2081691eb5e Diff: https://reviews.apache.org/r/60712/diff/2/ Changes: https://reviews.apache.org/r/60712/diff/1-2/ Testing --- Passed 'make check -j48' Passed 'GLOG_v=1 ./bin/mesos-test.sh --gtest_filter=SlaveTest.ContainersEndpoint --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60716/#review180322 --- On July 12, 2017, 1:17 a.m., Quinn Leng wrote: > > --- &g

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

uot;MasterTest.FrameworksEndpointQueryFramework" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

f so, please > reply accordingly and drop the issue. That's a good update, I can do that in follow-up patch. - Quinn --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60716/#review180197 --

Review Request 60820: Add class definition for SlaveID acceptor.

/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 Diff: https://reviews.apache.org/r/60820/diff/1/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60820: Add class definition for SlaveID, ContainerID acceptors.

://reviews.apache.org/r/60820/diff/1-2/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60822: Add filtering to /slaves, /slave/containers and /frameworks endpoints.

break_on_failure' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Review Request 60822: Add filtering to /slaves and /frameworks endpoints.

ER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60820: Add class definition for SlaveID, ContainerID acceptors.

these three endpoints through SlaveWriter, FullFrameworkWriter) https://reviews.apache.org/r/60712/ , https://reviews.apache.org/r/60580/ , https://reviews.apache.org/r/60581/ These three patches are merged and closed. This is the class definition part of the merged code. - Quinn Leng On July 13

Re: Review Request 60822: Add filtering to /slaves, /slave/containers and /frameworks endpoints.

make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

/60716/diff/4/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

a64702431bbc4307757ec797cf4309 Diff: https://reviews.apache.org/r/60820/diff/6/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

) <https://reviews.apache.org/r/60716/#comment255643> New line between these two lines. - Quinn Leng On July 13, 2017, 8:18 p.m., Quinn Leng wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

tps://reviews.apache.org/r/60820/#comment255642> New line between these two lines - Quinn Leng On July 13, 2017, 8:23 p.m., Quinn Leng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60822: Add filtering to /slaves, /slave/containers and /frameworks endpoints.

11829cac src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 Diff: https://reviews.apache.org/r/60822/diff/3/ Testing --- Passed 'make check -j48' Thanks, Quinn Leng

Re: Review Request 60822: Add filtering to /slaves, /slave/containers and /frameworks endpoints.

gt; Try doing: ``` return __containers(authorizeContainer, None()); ``` src/slave/http.cpp Line 2083 (original), 2080 (patched) <https://reviews.apache.org/r/60822/#comment255656> too many spaces src/slave/http.cpp Line 2112 (original), 2109 (patched) <https://reviews.apac

Re: Review Request 60847: Added test cases for /slaves, /containers, /frameworks endpoints.

k" --gtest_repeat=1000 --gtest_break_on_failure' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Re: Review Request 60847: Added test cases for /slaves, /containers, /frameworks endpoints.

Kill this. src/tests/master_tests.cpp Lines 6121-6123 (patched) <https://reviews.apache.org/r/60847/#comment255665> Try to wait until master has marked framework as completed. src/tests/slave_tests.cpp Line 2361 (original), 2361 (patched) <https://reviews.apache.org/r/60847/#comment255

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

s - src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 Diff: https://reviews.apache.org/r/60822/diff/3/ Testing --- Passed 'make check -j48' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

/60716/diff/5/ Changes: https://reviews.apache.org/r/60716/diff/4-5/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

s://reviews.apache.org/r/60820/diff/6-7/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

> On July 13, 2017, 9:09 p.m., Quinn Leng wrote: > > src/master/http.cpp > > Lines 1561-1562 (original), 1579-1580 (patched) > > <https://reviews.apache.org/r/60822/diff/3/?file=1776167#file1776167line1593> > > > > Fit one line. It's too long to

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

c611ef50b11829cac src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 Diff: https://reviews.apache.org/r/60822/diff/4/ Changes: https://reviews.apache.org/r/60822/diff/3-4/ Testing --- Passed 'make check -j48' Thanks, Quinn Leng

Re: Review Request 60279: Added constructors for ObjectApprover::Object.

src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340 Diff: https://reviews.apache.org/r/60279/diff/4/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

/r/60716/diff/5/ Testing --- Passed "make check -j48" Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48' Thanks, Quinn Leng

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Review Request 60928: Added 'FRAMEWORK_ADDED' event for master streaming event.

Diff: https://reviews.apache.org/r/60928/diff/1/ Testing --- make check Thanks, Quinn Leng

Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming event.

8 src/master/master.cpp d895154c00eef17511c46ddd0b75922f952707eb Diff: https://reviews.apache.org/r/60929/diff/1/ Testing --- make check Thanks, Quinn Leng

Review Request 60930: Added 'FRAMEWORK_REMOVED' event for master streaming api.

930/diff/1/ Testing --- make check Thanks, Quinn Leng

Review Request 60931: Added test cases for framework events.

9712d8797e0c0c69dc1ebf1fe5ac1f Diff: https://reviews.apache.org/r/60931/diff/1/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 60820: Added class definition for the IDAcceptor.

7cf4309 src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 Diff: https://reviews.apache.org/r/60820/diff/8/ Changes: https://reviews.apache.org/r/60820/diff/7-8/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

il. To reply, visit: https://reviews.apache.org/r/60820/#review180833 ------- On July 14, 2017, 12:10 a.m., Quinn Leng wrote: > > --- > This is an automatically generated e-m

Re: Review Request 60820: Added class definition for the IDAcceptor.

a2 Diff: https://reviews.apache.org/r/60820/diff/8/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

11829cac src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 Diff: https://reviews.apache.org/r/60822/diff/5/ Changes: https://reviews.apache.org/r/60822/diff/4-5/ Testing --- Passed 'make check -j48' Thanks, Quinn Leng

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

on_failure' Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48' Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure' Thanks, Quinn Leng

Review Request 60948: Updated test cases for the /tasks endpoint.

/r/60948/diff/1/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 60847: Added test cases for /slaves, /slave/containers, /frameworks endpoints.

ated e-mail. To reply, visit: https://reviews.apache.org/r/60847/#review180852 --- On July 18, 2017, 6:28 p.m., Quinn Leng wrote: > > --- > This is a

Re: Review Request 60929: Added 'FRAMEWORK_UPDATED' event for master streaming api.

tobuf_utils.cpp 4e5ab02c90ad8490efbcc471f7fd7c48be0c4678 src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32 Diff: https://reviews.apache.org/r/60929/diff/6/ Changes: https://reviews.apache.org/r/60929/diff/5-6/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 60931: Added test cases for framework streaming events.

s (updated) - src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f Diff: https://reviews.apache.org/r/60931/diff/4/ Changes: https://reviews.apache.org/r/60931/diff/3-4/ Testing --- make check Thanks, Quinn Leng

Review Request 61189: Added authorization for V1 events.

="ContentType/MasterAPITest.EventsAuthorizationFiltering*" --verbose --gtest_repeat=100 --gtest_break_on_failure Thanks, Quinn Leng

Review Request 61194: Updated the docs for V1 Events.

tp-api.md c096a048001453e5b7efc1fb8e3b9db835685886 Diff: https://reviews.apache.org/r/61194/diff/1/ Testing --- Thanks, Quinn Leng

Re: Review Request 61194: Updated the docs for V1 Events.

nts. Diffs (updated) - docs/operator-http-api.md c096a048001453e5b7efc1fb8e3b9db835685886 Diff: https://reviews.apache.org/r/61194/diff/2/ Changes: https://reviews.apache.org/r/61194/diff/1-2/ Testing --- Thanks, Quinn Leng

Review Request 61222: Added V1 teardown call.

f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f Diff: https://reviews.apache.org/r/61222/diff/1/ Testing --- make check Thanks, Quinn Leng

Review Request 61262: Added 'heartbeat' event for the operator API.

ache.org/r/61262/diff/1/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 61222: Added V1 teardown Call.

4885339b2112b6dbdc930875c20e1f5872b1edbf Diff: https://reviews.apache.org/r/61222/diff/2/ Changes: https://reviews.apache.org/r/61222/diff/1-2/ Testing --- make check Thanks, Quinn Leng

Review Request 61408: Added test cases for V1 teardown Call.

--- make check Thanks, Quinn Leng

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

ary to keep it as a class memeber. src/tests/api_tests.cpp Lines 2189 (patched) <https://reviews.apache.org/r/61262/#comment258604> put int into the for bracket. - Quinn Leng On July 31, 2017, 5:30 p.m., Quinn Leng wrote: > > ---

Re: Review Request 61408: Added test cases for V1 teardown Call.

tps://reviews.apache.org/r/61408/#comment258608> check in the unversioned teardown call test case, if it doesn't contain authorization test, add it here. - Quinn Leng On Aug. 3, 2017, 5:57 p.m., Quinn Leng wrote: > > ---

Re: Review Request 61408: Added test cases for V1 teardown Call.

://reviews.apache.org/r/61408/diff/2/ Changes: https://reviews.apache.org/r/61408/diff/1-2/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9 Diff: https://reviews.apache.org/r/61262/diff/4/ Changes: https://reviews.apache.org/r/61262/diff/3-4/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 61408: Added test cases for V1 teardown Call.

://reviews.apache.org/r/61408/diff/3/ Changes: https://reviews.apache.org/r/61408/diff/2-3/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

http, > > DEFAULT_HEARTBEAT_INTERVAL, > > DEFAULT_HEARTBEAT_INTERVAL); > > ``` > > > > what do you think? I am also thinking about that too previously. Just not sure if this is compatible with our furture implementation. - Quinn ---

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

_tests.cpp 3ab4740bcac29ecb89585da6adb1f563d6fc1f5f Diff: https://reviews.apache.org/r/61262/diff/6/ Changes: https://reviews.apache.org/r/61262/diff/5-6/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 61408: Added test cases for V1 teardown Call.

://reviews.apache.org/r/61408/diff/4/ Changes: https://reviews.apache.org/r/61408/diff/3-4/ Testing --- make check Thanks, Quinn Leng

Re: Review Request 61189: Added authorization for V1 events.

check GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventsAuthorizationFiltering*" --verbose --gtest_repeat=100 --gtest_break_on_failure Thanks, Quinn Leng

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

_tests.cpp 3ab4740bcac29ecb89585da6adb1f563d6fc1f5f Diff: https://reviews.apache.org/r/61262/diff/7/ Changes: https://reviews.apache.org/r/61262/diff/6-7/ Testing --- make check -j48 Thanks, Quinn Leng

Re: Review Request 61189: Added authorization for V1 events.

ask task, FrameworkInfo info) > > { > > return authorizeTask->accept(task, info) && > > authorizeFramework->accept(info); > > } > > ``` > > > > This way you only need one acceptor per event and you hid t

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

_tests.cpp 3ab4740bcac29ecb89585da6adb1f563d6fc1f5f Diff: https://reviews.apache.org/r/61262/diff/8/ Changes: https://reviews.apache.org/r/61262/diff/7-8/ Testing --- make check -j48 Thanks, Quinn Leng

  1   2   >