---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86722
---
Ship it!
src/slave/resource_estimator.cpp
On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
src/tests/oversubscription_tests.cpp, line 66
https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66
We have const char* in for example
https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/
---
(Updated June 4, 2015, 5:56 p.m.)
Review request for mesos, Bartek Plotka,
On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
src/tests/oversubscription_tests.cpp, line 66
https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66
We have const char* in for example
https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86703
---
Patch looks great!
Reviews applied: [35028]
All tests passed.
-
On June 3, 2015, 11:30 p.m., Vinod Kone wrote:
src/slave/resource_estimators/fixed.cpp, line 47
https://reviews.apache.org/r/35028/diff/1/?file=977721#file977721line47
Since the slave now asks the estimator everytime it wants to forward an
update and doesn't store a cached value,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86507
---
src/slave/resource_estimators/fixed.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86502
---
LGTM :)
src/Makefile.am