Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86722 --- Ship it! src/slave/resource_estimator.cpp

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86703 --- Patch looks great! Reviews applied: [35028] All tests passed. - M

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- (Updated June 4, 2015, 5:56 p.m.) Review request for mesos, Bartek Plotka, Nikl

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 66 > > > > > > We have const char* in for example > > https://github.com/apache/mesos/blob/master/src/tests/hook_tests

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 66 > > > > > > We have const char* in for example > > https://github.com/apache/mesos/blob/master/src/tests/hook_tests

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/slave/resource_estimator.cpp, lines 46-48 > > > > > > How about wrapping like: > > > > ``` > > return Error( > > "Could not creat

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:30 p.m., Vinod Kone wrote: > > src/slave/resource_estimators/fixed.cpp, line 47 > > > > > > Since the slave now asks the estimator everytime it wants to forward an > > update and doesn't store a c

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86507 --- src/slave/resource_estimators/fixed.cpp

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86502 --- LGTM :) src/Makefile.am

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- (Updated June 3, 2015, 10:05 p.m.) Review request for mesos, Bartek Plotka, Nik