Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review141569 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122052 --- Patch looks great! Reviews applied: [39939] Passed command: expo

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 6:10 a.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122012 --- Ship it! Ship It! - Klaus Ma On March 4, 2016, 11:54 a.m., h

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:54 a.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122011 --- src/slave/containerizer/docker.cpp (lines 136 - 137)

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:41 a.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` wil

Re: Review Request 39939: Make docker_socket option support different protocols.

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` will a

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 11:02 a.m., Klaus Ma wrote: > > src/slave/containerizer/docker.cpp, lines 136-138 > > > > > > Two comments here: > > > > 1. Error message; I'd like to say: "Failed to create docker contai

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` wil

Re: Review Request 39939: Make docker_socket option support different protocols.

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` will a

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 3:13 a.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 3:02 a.m., Klaus Ma wrote: > > src/slave/containerizer/docker.cpp, lines 136-138 > > > > > > Two comments here: > > > > 1. Error message; I'd like to say: "Failed to create docker contain

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > > > > > Does the `docker_socket` support starting wit `unix:`? I think not, > > because the `Docker::create` wil

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122003 --- src/slave/containerizer/docker.cpp (line 134)

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122000 --- src/slave/containerizer/docker.cpp (lines 133 - 135)

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into containe

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 4, 2016, 2:23 a.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 12:41 p.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into contain

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated March 3, 2016, 4:40 p.m.) Review request for mesos, Klaus Ma and Timot

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into containe

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > > > > > I think we need to handle feature interaction with > > `docker_mesos_image`. Currently, we mount unix socket into containe

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review120096 --- src/slave/flags.cpp (line 437)

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review120094 --- docs/configuration.md (line 1029)

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review107466 --- Ship it! Ship It! - Timothy Chen On Nov. 4, 2015, 5:13 p.m., ha

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review105105 --- Patch looks great! Reviews applied: [39939] All tests passed. -