Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 9, 2016, 1:49 a.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
> On Feb. 9, 2016, 1:10 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 948 > > > > > > looks like you forgot to pass "this" to this callback? Good catch. Fixed - Anand

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118340 --- Fix it, then Ship it! src/tests/mesos.hpp (line 948)

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 9, 2016, 12:12 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
> On Feb. 8, 2016, 10 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 960 > > > > > > s/executor_/executor/ > > > > we typically don't use underscores for member variables. Our style guide does recomm

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 8, 2016, 10:15 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review118299 --- src/tests/mesos.hpp (line 937)

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 4, 2016, 11:11 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Feb. 3, 2016, 10:14 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review117527 --- src/tests/mesos.hpp (line 839)

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 19, 2016, 10:28 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 19, 2016, 8:05 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

2016-01-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/ --- (Updated Jan. 12, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler and Vin