Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 19, 2016, 10 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115135 --- How about a more succinct summary: "Traversed all roles for quota

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115232 --- The central part lgtm, will check the tests tomorrow morning in

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115265 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 19, 2016,

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115285 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 19, 2016, 12:38 p.m.) Review request for mesos, Alexander

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On 一月 19, 2016, 11:11 a.m., Alexander Rukletsov wrote: > > How about a more succinct summary: "Traversed all roles for quota > > allocation"? > > > > Changes touching allocator are vulnerable to races, especially in tests. > > Please extend the testing (and mention this in the "Testing

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review115149 --- src/tests/hierarchical_allocator_tests.cpp (line 1875)

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On Jan. 19, 2016, 12:42 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1875 > > > > > > Here's one question after reviewing this test: is there any priority > > between Quota? e.g. if

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On 一月 19, 2016, 12:42 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1875 > > > > > > Here's one question after reviewing this test: is there any priority > > between Quota? e.g. if

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On Jan. 19, 2016, 12:42 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1875 > > > > > > Here's one question after reviewing this test: is there any priority > > between Quota? e.g. if

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 16, 2016, 12:45 p.m.) Review request for mesos, Alexander

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 一月 16, 2016, 12:44 p.m.) Review request for mesos, Alexander

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114863 --- Patch looks great! Reviews applied: [41769] Passed command:

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On Jan. 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > > > > > This looks like a bug to me. I can't remember why we have `break` here > > in

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On 一月 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > > > > > This looks like a bug to me. I can't remember why we have `break` here > > in

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114184 --- src/master/allocator/mesos/hierarchical.cpp (lines 1164 - 1166)

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

> On 一月 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > > > > > This looks like a bug to me. I can't remember why we have `break` here > > in

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review112427 --- Patch looks great! Reviews applied: [41769] Passed command:

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/ --- (Updated 十二月 31, 2015, 11:34 p.m.) Review request for mesos, Alexander

Re: Review Request 41769: Made allocator traverse all roles for quota allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review112164 --- Patch looks great! Reviews applied: [41769] Passed command: