Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated May 12, 2016, 1:33 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

> On May 5, 2016, 9:45 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 40 > > > > > > (1) Can we make this `private` and add a `const std::string& get() > > const

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

> On May 5, 2016, 9:45 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 40 > > > > > > (1) Can we make this `private` and add a `const std::string& get() > > const

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131946 --- Fix it, then Ship it!

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131242 --- Ship it! Ship It! - Greg Mann On April 30, 2016, 1:56 a.m.,

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 30, 2016, 1:56 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

> On April 29, 2016, 7:27 p.m., Michael Park wrote: > > (1) Just so I understand, is this a necessary introduction? or is it an > > improvement? > > (2) In some parts, we access the `name.value` directly, and other times we > > use `stringify(name)`. From the implementation it looks like they

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review131166 --- (1) Just so I understand, is this a necessary introduction? or is

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 29, 2016, 3:24 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 26, 2016, 12:54 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

> On April 25, 2016, 2:48 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp, line 45 > > > > > > If this was `const` it would be much easier to reason how this works >

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/#review130422 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp