Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review150279 --- Ship it! Ship It! - Joseph Wu On Sept. 23, 2016, 4:59 p.m.,

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 691 > > > > > > Let's call this variable `expected_gids`. Done > On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > >

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote: > > 3rdparty/stout/tests/os_tests.cpp, lines 697-699 > > > > > > How about `EXPECT_EQ(tokens.get(), expected_gids);` here? > > Mao Geng wrote: > Not sure if

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 23, 2016, 11:59 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 23, 2016, 11:43 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote: > > 3rdparty/stout/tests/os_tests.cpp, lines 697-699 > > > > > > How about `EXPECT_EQ(tokens.get(), expected_gids);` here? > > Mao Geng wrote: > Not sure if

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote: > > 3rdparty/stout/tests/os_tests.cpp, lines 697-699 > > > > > > How about `EXPECT_EQ(tokens.get(), expected_gids);` here? Not sure if EXPECT_EQ can compare two

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review150202 --- 3rdparty/stout/tests/os_tests.cpp (lines 697 - 699)

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149997 --- Patch looks great! Reviews applied: [52048] Passed command:

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > Looks sane :) Thanks for reviewing! > On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 695 > > > > > > We don't

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 22, 2016, 7:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149936 --- Looks sane :) 3rdparty/stout/tests/os_tests.cpp (line 691)

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149544 --- Patch looks great! Reviews applied: [52048] Passed command:

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 19, 2016, 6:42 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/ --- (Updated Sept. 19, 2016, 6:41 p.m.) Review request for mesos, Gilbert Song and