Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review202003
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['63372']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/mesos-tests-stdout.log):

```
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 
(14643 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/0
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (14518 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/1
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (14787 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (14814 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (14502 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/0
[   OK ] ContentType/SchedulerTest.Revive/0 (14124 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/1
[   OK ] ContentType/SchedulerTest.Revive/1 (14456 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/0
[   OK ] ContentType/SchedulerTest.Suppress/0 (14385 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/1
[   OK ] ContentType/SchedulerTest.Suppress/1 (14771 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (19123 
ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (19412 
ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 
(19153 ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 
(19597 ms)
[ RUN  ] ContentType/SchedulerTest.Message/0
[   OK ] ContentType/SchedulerTest.Message/0 (14646 ms)
[ RUN  ] ContentType/SchedulerTest.Message/1
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/mesos-tests-stderr.log):

```
I0426 12:58:15.384744 13740 master.cpp:8935] Framework failover timeout, 
removing framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- (default)
I0426 12:58:15.384744 13740 master.cpp:9829] Removing framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- (default)
I0426 12:58:15.385751 13740 master.cpp:10547] Updating the state of task 
66141341-0244-477b-a7ad-c081b6abd91b of framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0426 12:58:15.385751  4956 slave.cpp:3919] Shutting down framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-
I0426 12:58:15.385751  4956 slave.cpp:6616] Shutting down executor 'default' of 
framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- (via HTTP)
I0426 12:58:15.387814 13740 master.cpp:10646] Removing task 
66141341-0244-477b-a7ad-c081b6abd91b with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- on 
agent a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.389746 13740 master.cpp:10675] Removing executor 'default' with 
resources [] of framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- on agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.391746 13276 hierarchical.cpp:344] Removed framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-
I0426 12:58:15.392760 16168 slave.cpp:919] Agent terminating
W0426 12:58:15.392760 16168 slave.cpp:3915] Ignoring shutdown framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- because it is terminating
I0426 12:58:15.392760  5328 master.cpp:1296] Agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02) disconnected
I0426 12:58:15.393760  5328 master.cpp:3296] Disconnecting agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.393760  5328 master.cpp:3315] Deactivating agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.394780 11792 hierarchical.cpp:766] Agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 deactivated
I0426 12:58:15.417757 

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201997
---



I'll fix the outstanding issues, make minor adjustments, align accordinf to the 
80 chars per line rule and commit this shortly.


docs/memory-profiling.md
Lines 50 (patched)


can be beneficial



docs/memory-profiling.md
Lines 98 (patched)


... with the `/stop`...


- Alexander Rukletsov


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 192 (patched)
> > 
> >
> > Let's have an inline link in form []() for consistency.
> 
> Benno Evers wrote:
> The problem is that the url itself contains a `)`, confusing the markdown 
> parser. It's possible to escape that `)` with a backslash, but then the link 
> will be incorrect for people reading the markdown directly.

We can use another link, e.g., http://jemalloc.net/jemalloc.3.html. Moreover, 
the latter points to the version bundled with Mesos.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 122-124 (patched)
> > 
> >
> > Is `dot` tool required as well?
> 
> Benno Evers wrote:
> Wasn't that what you found testing on Mac?
> 
> Alexander Rukletsov wrote:
> That was a test on linux. Have you confirmed?

Looks like this according to 
http://download.redis.io/redis-stable/deps/jemalloc/bin/jeprof.in


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

> On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote:
> > Have you rendered using our website renderer?

Yes.


> On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 54 (patched)
> > 
> >
> > I would like to explicitly tell people that this is the second part, 
> > with the first being switching to jemalloc. Also, I would like to educate 
> > them, that the second (memory profiling) requires the first, while the 
> > opposite is not true and people will likely reap profit even without 
> > enabling memory profiling functionlaity.
> > 
> > Can you please add this info somewhere to the doc?

I added a paragraph, but since this document is about memory profiling, I'm not 
sure how much the non-memory-profiling related use cases of jemalloc are 
relevant here.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201844
---


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/
---

(Updated April 25, 2018, 2:07 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Added documentation for memory profiling.


Diffs (updated)
-

  CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
  docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
  docs/memory-profiling.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63372/diff/9/

Changes: https://reviews.apache.org/r/63372/diff/8-9/


Testing
---


Thanks,

Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201844
---



Have you rendered using our website renderer?


docs/memory-profiling.md
Lines 26 (patched)


s/:/.

Maybe even better:
... support jemalloc only; there are several ways to connect it to Mesos.



docs/memory-profiling.md
Lines 51 (patched)


Please decide whether or not to back tick jemalloc throughout the doc.



docs/memory-profiling.md
Lines 54 (patched)


I would like to explicitly tell people that this is the second part, with 
the first being switching to jemalloc. Also, I would like to educate them, that 
the second (memory profiling) requires the first, while the opposite is not 
true and people will likely reap profit even without enabling memory profiling 
functionlaity.

Can you please add this info somewhere to the doc?



docs/memory-profiling.md
Lines 109 (patched)


Nit: period ourside the link please


- Alexander Rukletsov


On April 24, 2018, 2:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 24, 2018, 2:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 98 (patched)
> > 
> >
> > comma after i.e.
> 
> Benno Evers wrote:
> Not according to the internet: 
> https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e

Yes according to Mesos:
```
alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui 
--exclude-dir=src/python --exclude-dir=src/java "i.e., " src | wc -l
 157

alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui 
--exclude-dir=src/python --exclude-dir=src/java "i.e. " src | wc -l 
  33

alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui 
--exclude-dir=src/python --exclude-dir=src/java "e.g. " src | wc -l
  61

alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui 
--exclude-dir=src/python --exclude-dir=src/java "e.g., " src | wc -l
 273
```


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 122-124 (patched)
> > 
> >
> > Is `dot` tool required as well?
> 
> Benno Evers wrote:
> Wasn't that what you found testing on Mac?

That was a test on linux. Have you confirmed?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 24, 2018, 2:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 24, 2018, 2:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 31 (patched)
> > 
> >
> > the bundled version?

I think 'a' is correct here.


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 82-84 (patched)
> > 
> >
> > Please tell people they will get an `id` of the progiling run that can 
> > be used to uniqly identify it.

I think its better not to overcomplicate: For people trying things for the 
first time and following the guide, concurrent runs will be a non-issue, and 
it's mentioned later in the scripting section anyways.


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 98 (patched)
> > 
> >
> > comma after i.e.

Not according to the internet: 
https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 122-124 (patched)
> > 
> >
> > Is `dot` tool required as well?

Wasn't that what you found testing on Mac?


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 168 (patched)
> > 
> >
> > Does \~\~\~{.bash} work?

It works in the sense that it produces a monospace code block (i.e. no syntax 
highlighting), but the style guide says this so I assume we shouldn't use it:

```
**NOTE:** Because of shortcomings of Doxygen's markdown parser we currently use 
indentation for wrapping all non C++ code blocks.
```


> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 192 (patched)
> > 
> >
> > Let's have an inline link in form []() for consistency.

The problem is that the url itself contains a `)`, confusing the markdown 
parser. It's possible to escape that `)` with a backslash, but then the link 
will be incorrect for people reading the markdown directly.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 24, 2018, 2:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 24, 2018, 2:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/
---

(Updated April 24, 2018, 2:40 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Added documentation for memory profiling.


Diffs (updated)
-

  CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
  docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
  docs/memory-profiling.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63372/diff/8/

Changes: https://reviews.apache.org/r/63372/diff/7-8/


Testing
---


Thanks,

Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---




docs/memory-profiling.md
Lines 6 (patched)


IIRC, the convention is to use `#` only for the title, i.e., this line, 
meaning you should add one `#` to each section below. Also, the title above 
should coincide with this line.



docs/memory-profiling.md
Lines 22 (patched)


Please links in "[]()" format.



docs/memory-profiling.md
Lines 27 (patched)


You mention here memory profiling but actually speak about jemalloc. How 
about the following.

"To make memory profiling possible, jemalloc memory allocator is required. 
There are two ways..." 

or

"A prerequisite for memory profiling is a suitable allocator. We currently 
support jemalloc, which can be connected via one of the following ways..."



docs/memory-profiling.md
Lines 31 (patched)


the bundled version?



docs/memory-profiling.md
Lines 31-32 (patched)


The end of the sentence sounds a bit weird. Can you please rephrase?



docs/memory-profiling.md
Lines 34 (patched)


What do you mean under present? On the build host? On the target host? 
Maybe rephrasing this saying something like "Users can provide their own 
jemalloc build via..."



docs/memory-profiling.md
Lines 36-37 (patched)


Maybe decorate this as a `**NOTE:**` to capture people's attention?



docs/memory-profiling.md
Lines 41 (patched)


Please back tick types.



docs/memory-profiling.md
Lines 50 (patched)


s/,/:/



docs/memory-profiling.md
Lines 53-54 (patched)


Let's explain a bit more, users will appreciate! Something like this: 
"Switching to the jemalloc allocator alone is not enough to get memory dumps, 
the binaries itself should have memory profiling enabled. To do this, start..."



docs/memory-profiling.md
Lines 71 (patched)


This section lacks some guidance regarding the UX. Please mention somewhere 
in this section things like
1. There can only be one active profiling run.
2. Data from a single, most recently finished profiling run are stored.
3. Fumbling with jemalloc memory profiling out of band is unsupported and 
can lead to weird results.



docs/memory-profiling.md
Lines 78 (patched)


What are the other ways? Are they alternatives or you discourage using them?



docs/memory-profiling.md
Lines 82-84 (patched)


Please tell people they will get an `id` of the progiling run that can be 
used to uniqly identify it.



docs/memory-profiling.md
Lines 98 (patched)


comma after i.e.



docs/memory-profiling.md
Lines 100-102 (patched)


No need to put this link onto a separate line. "Check out [the official 
jemalloc documentation](link) for the description of the file format"



docs/memory-profiling.md
Lines 108 (patched)


Back tick `jeprof`



docs/memory-profiling.md
Lines 109 (patched)


Period at the end.



docs/memory-profiling.md
Lines 111 (patched)


Dito re `jeprof`



docs/memory-profiling.md
Lines 122-124 (patched)


Is `dot` tool required as well?



docs/memory-profiling.md
Lines 125 (patched)


Is this blank line necessary?



docs/memory-profiling.md
Lines 127-128 (patched)


I don't think this adds much value : ), you can directly start with the 
next paragraph.



docs/memory-profiling.md
Lines 151 (patched)


maybe prepend the line with `$` to indicate it is a copypasteable command?



docs/memory-profiling.md
Lines 167 (patched)


this?



docs/memory-profiling.md
Lines 168 (patched)


Does \~\~\~{.bash} work?



docs/memory-profiling.md
Lines 183 (patched)

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/
---

(Updated April 13, 2018, 6:49 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Added jeprof section.


Repository: mesos


Description
---

Added documentation for memory profiling.


Diffs (updated)
-

  docs/memory-profiling.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63372/diff/6/

Changes: https://reviews.apache.org/r/63372/diff/5-6/


Testing
---


Thanks,

Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review200635
---



Please also call out this feature in the CHANGELOG.

- Alexander Rukletsov


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review200396
---



Bad patch!

Reviews applied: [63372, 63371, 63370, 63368, 63366, 65462, 65461, 63367]

Failed command: python support/apply-reviews.py -n -r 63366

Error:
2018-04-03 19:50:34 URL:https://reviews.apache.org/r/63366/diff/raw/ 
[12984/12984] -> "63366.patch" [1]
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22085/console

- Mesos Reviewbot


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review200380
---



FAIL: Failed to apply the dependent review: 63366.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63366`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372

Relevant logs:

- 
[apply-review-63366-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/apply-review-63366-stdout.log):

```
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
```

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198404
---




docs/memory-profiling.md
Lines 22 (patched)


Ain't it called `--enable-jemalloc-allocator`?



docs/memory-profiling.md
Lines 49 (patched)


This endpoint spits out a huge JSON file even on a fresh master without any 
load. Maybe it makes sense to say what might be interesting / what this JSON 
includes; including JSON schema would also be great.



docs/memory-profiling.md
Lines 95-97 (patched)


How a user gets a compatible `jeprof` installed? Do we expect them to 
figure out the bundled version of jemalloc and then figure out how to get and 
install jeprof onto the machine? Can we do it ourselves during the configure 
step? Or maybe better have memory-profiler use the bundled jeprof?


- Alexander Rukletsov


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197983
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198066
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198027
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198062
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198058
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198053
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198048
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198023
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197987
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198015
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198044
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198039
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 5:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 5:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197999
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198031
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197991
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198009
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198035
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 5:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 5:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198005
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review198019
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197978
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197971
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197967
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197962
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197958
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197954
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197950
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197946
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197940
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197934
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197930
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197923
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197918
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197906
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197898
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197894
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197890
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197884
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197880
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 8:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197876
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197870
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197866
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197862
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197857
---



Bad review!

Error:
Circular dependency detected for review 63367. Please fix the 'depends_on' 
field.

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review197844
---



Bad review!

Reviews applied: [63372, 63371, 63370, 63368, 63366, 65462, 65461, 63367]

Error:
Circular dependency detected for review 63366.Please fix the 'depends_on' field.

- Mesos Reviewbot


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review196142
---



FAIL: Failed to apply the dependent review: 63366.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63366`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372

Relevant logs:

- 
[apply-review-63366-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/apply-review-63366-stdout.log):

```
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
```

- Mesos Reviewbot Windows


On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated Jan. 24, 2018, 4:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/
---

(Updated Jan. 24, 2018, 4:40 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rewritten for API change.


Summary (updated)
-

Added documentation for memory profiling.


Repository: mesos


Description (updated)
---

Added documentation for memory profiling.


Diffs (updated)
-

  docs/memory-profiling.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63372/diff/2/

Changes: https://reviews.apache.org/r/63372/diff/1-2/


Testing
---


Thanks,

Benno Evers