Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193557 --- Ship it! Ship It! - Jiang Yan Xu On Dec. 12, 2017, 4:54

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193544 --- FAIL: Some Mesos tests failed. Reviews applied: `['64250',

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193536 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 12, 2017, 12:54 p.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193466 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193460 --- LGTM sans Ilya's comment about only use `replicated_log` flag

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 7, 2017, 1:36 p.m., Ilya Pronin wrote: > > src/tests/master_tests.cpp > > Lines 7477 (patched) > > > > > > Ditto re replicated log based registry. > > Megha Sharma wrote: > I added this specifically

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 8, 2017, 6:42 p.m.) Review request for mesos, Ilya Pronin, James

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193189 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193141 --- src/master/master.cpp Lines 6806-6810 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192895 --- Awesome! Only minor comments below. src/master/master.cpp Lines

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 2, 2017, 12:41 a.m., Megha Sharma wrote: > > src/tests/upgrade_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Sorry my bad looks like the fix for this test is still needed. I am not > >

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 4, 2017, 6:43 p.m., Jiang Yan Xu wrote: > > src/tests/master_allocator_tests.cpp > > Lines 1452-1454 (original), 1452-1459 (patched) > > > > > > So these tests had to be changed becauase the master is not

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192794 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 1, 2017, 4:41 p.m., Megha Sharma wrote: > > src/tests/upgrade_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Sorry my bad looks like the fix for this test is still needed. I am not > > clear

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192733 --- Mainly looked at the reason for the test changes. Will take

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192607 --- src/tests/upgrade_tests.cpp Line 138 (original), 138 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 2, 2017, 12:29 a.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 2, 2017, 12:12 a.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 1, 2017, 9:29 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Line 6808 (original), 6808 (patched) > > > > > > When considering the comment by Ilya in MESOS-6406 (i.e., what if > > agents GCed

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192557 --- src/master/master.cpp Line 6808 (original), 6808 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192519 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 11:22 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 7:22 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 7:01 p.m., Ilya Pronin wrote: > > src/master/master.cpp > > Lines 6789 (patched) > > > > > > I think this is not specific to unreachable agents. Can be an agent > > that was recovered after

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 11:22 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 11:22 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 64098: Send status updates when agent re-registers.

> On Nov. 28, 2017, 11:22 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 6788 (patched) > > > > > > I think this type of status updates could benefit from a distinct > > reason for to make it more

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192041 --- Reviewed the non-testing portion. Will continue to review the

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review191979 --- Looks good to me overall. Great to see this patch coming. Do we

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Nov. 28, 2017, 12:29 a.m.) Review request for mesos, James Peach and