Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

> On March 14, 2018, 6:45 p.m., Andrew Schwartzmeyer wrote: > > Ship It! Tested on Windows and Linux (at least the build and tests all pass). - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199234 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 14, 2018,

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

> On March 14, 2018, 11:51 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 105 (patched) > > > > > > There needs to be an equivalent to these two `set(PROTO` lines in the > > `PROTOC_IN

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199228 --- src/cmake/MesosProtobuf.cmake Lines 105 (patched)

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199226 --- Let me apply these patches on Windows and make sure everything is

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/ --- (Updated March 14, 2018, 11:05 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

> On March 14, 2018, 7:50 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 94 (patched) > > > > > > We put CPP_OUT files under an build/include/lib? > > Chun-Hung Hsiao wrote: > Yeah.

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

> On March 14, 2018, 7:50 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 94 (patched) > > > > > > We put CPP_OUT files under an build/include/lib? Yeah. The reason is that, for CSI supp

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199202 --- src/cmake/MesosProtobuf.cmake Line 24 (original), 24 (patched)

Re: Review Request 65997: Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/ --- (Updated March 14, 2018, 2:56 a.m.) Review request for mesos, Andrew Schwartzme