Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-08-26 Thread James Peach 


> On June 9, 2015, 12:28 a.m., Cody Maloney wrote:
> > configure.ac, line 171
> > 
> >
> > Since these all follow about the same structure could we add an 
> > autoconf macro which takes the package name followed by the help 
> > description and  does the rest automatically?

If you send me a JIRA issue, I would prefer to do that as a separate change. 
This is already larger that I'm really comfortable with.


> On June 9, 2015, 12:28 a.m., Cody Maloney wrote:
> > configure.ac, line 58
> > 
> >
> > nit: Could you document auto here? Right now it's an implicit magic 
> > value like 'bundled' in a lot of ways.
> > 
> > I also wonder if it is possible to have this macro set the AC_ARG_WITH 
> > / AC_ARG_ENABLE, but that definitely isn't necessary / blocker here.

That's documented in rule 4 - "Otherwise use the policy set by 
--enable-bundled".


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86739
---


On July 15, 2015, 4:59 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> ---
> 
> (Updated July 15, 2015, 4:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2537
> https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> ---
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
> exhaustive!) combinations of enabling and disableing bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
> --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I 
> can do once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-08-26 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---

(Updated Aug. 26, 2015, 8:10 p.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Changes
---

Rebased.


Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537


Repository: mesos


Description
---

Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.

The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.


Diffs (updated)
-

  configure.ac 87461d73ed04c4cf176c3475ded9f98dadcda608 

Diff: https://reviews.apache.org/r/35084/diff/


Testing
---

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
exhaustive!) combinations of enabling and disableing bundled packages.

For example, on CentOS, this alost works:
  $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
--with-gmock=bundled

To work completely, this change needs to be propagated to libprocess, which I 
can do once reviewers agree that it's the right behavior.


Thanks,

James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-07-14 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---

(Updated July 15, 2015, 4:59 a.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537


Repository: mesos


Description
---

Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.

The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.


Diffs (updated)
-

  configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 

Diff: https://reviews.apache.org/r/35084/diff/


Testing
---

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
exhaustive!) combinations of enabling and disableing bundled packages.

For example, on CentOS, this alost works:
  $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
--with-gmock=bundled

To work completely, this change needs to be propagated to libprocess, which I 
can do once reviewers agree that it's the right behavior.


Thanks,

James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread Cody Maloney 


> On June 9, 2015, 12:28 a.m., Cody Maloney wrote:
> >

Partial review, going to review more thoroughly later, just posting so it 
doesn't get lost since it was on the old revision


- Cody


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86739
---


On June 9, 2015, 12:02 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> ---
> 
> (Updated June 9, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2537
> https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> ---
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
> exhaustive!) combinations of enabling and disableing bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
> --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I 
> can do once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread Cody Maloney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86739
---



configure.ac


nit: Could you document auto here? Right now it's an implicit magic value 
like 'bundled' in a lot of ways.

I also wonder if it is possible to have this macro set the AC_ARG_WITH / 
AC_ARG_ENABLE, but that definitely isn't necessary / blocker here.



configure.ac


Since these all follow about the same structure could we add an autoconf 
macro which takes the package name followed by the help description and  does 
the rest automatically?


- Cody Maloney


On June 9, 2015, 12:02 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> ---
> 
> (Updated June 9, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2537
> https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> ---
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
> exhaustive!) combinations of enabling and disableing bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
> --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I 
> can do once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---

(Updated June 9, 2015, 12:02 a.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537


Repository: mesos


Description
---

Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.

The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.


Diffs (updated)
-

  configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 

Diff: https://reviews.apache.org/r/35084/diff/


Testing
---

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
exhaustive!) combinations of enabling and disableing bundled packages.

For example, on CentOS, this alost works:
  $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
--with-gmock=bundled

To work completely, this change needs to be propagated to libprocess, which I 
can do once reviewers agree that it's the right behavior.


Thanks,

James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review86717
---


Patch looks great!

Reviews applied: [33752, 35084]

All tests passed.

- Mesos ReviewBot


On June 4, 2015, 7:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> ---
> 
> (Updated June 4, 2015, 7:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2537
> https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> ---
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
> exhaustive!) combinations of enabling and disableing bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
> --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I 
> can do once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-04 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---

(Updated June 4, 2015, 7:36 p.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Bugs: MESOS-2537
https://issues.apache.org/jira/browse/MESOS-2537


Repository: mesos


Description
---

Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.

The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.


Diffs
-

  configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 

Diff: https://reviews.apache.org/r/35084/diff/


Testing
---

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
exhaustive!) combinations of enabling and disableing bundled packages.

For example, on CentOS, this alost works:
  $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
--with-gmock=bundled

To work completely, this change needs to be propagated to libprocess, which I 
can do once reviewers agree that it's the right behavior.


Thanks,

James Peach

Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-04 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/
---

Review request for mesos.


Repository: mesos


Description
---

Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
consistent behavior for bundled packages selected by either
--enable-bundled-$PACKAGE or --with-$PACKAGE.

The default policy is set by --enable-bundled and overridden when
the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
option. If --with-$PACKAGE is specified as "bundled", the bundled
version is selected.


Diffs
-

  configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 

Diff: https://reviews.apache.org/r/35084/diff/


Testing
---

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not 
exhaustive!) combinations of enabling and disableing bundled packages.

For example, on CentOS, this alost works:
  $ onfigure.developer  --disable-bundled --with-zookeeper=bundled 
--with-gmock=bundled

To work completely, this change needs to be propagated to libprocess, which I 
can do once reviewers agree that it's the right behavior.


Thanks,

James Peach