---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94781
---
Ship it!
Maybe the code around checking for acceptable headers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 10, 2015, 9:52 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94203
---
Patch looks great!
Reviews applied: [37097, 36402]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94321
---
Patch looks great!
Reviews applied: [37097, 36402]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94019
---
Patch looks great!
Reviews applied: [36402]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 11:05 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 11:05 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 5, 2015, 12:24 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 5, 2015, 12:32 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 5:42 p.m.)
Review request for mesos, Anand Mazumdar,
On Aug. 3, 2015, 9:38 p.m., Ben Mahler wrote:
Is this ready to review? Mind updating the 'issues' accordingly?
Just did, thanks for comments :)
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94112
---
3rdparty/libprocess/src/http.cpp (line 155)
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
This will not crash, tokenize will always return a vector of at least
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94105
---
Looking better! Can you please pull out the fixes to
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 156
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line156
This will crash the program if tokens is empty!
Please see comment below.
- Isabel
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
Looking better! Can you please pull out the fixes to 'acceptsEncoding' into
a separate review? Also, would like to see tests for the cases that weren't
handled correctly (e.g. gzipp;q=1.0 should not match gzip). Pulling the
changes apart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review93970
---
Is this ready to review? Mind updating the 'issues' accordingly?
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 3, 2015, 8:19 p.m.)
Review request for mesos, Anand Mazumdar,
On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 126
https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line126
Whoops ! Let's return false as earlier. Also add a test-case for empty
check. ( Accept-Encoding )
Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review92343
---
Thanks Isabel!
Could we remove the changes to 'acceptEncoding'?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91859
---
Patch looks great!
Reviews applied: [36402]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated July 15, 2015, 10:51 p.m.)
Review request for mesos, Anand Mazumdar,
On July 10, 2015, 10:13 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 216
https://reviews.apache.org/r/36402/diff/1/?file=1008565#file1008565line216
I did not review the entire patch but I stopped at this. Seems like I
am missing something here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
---
Have not gone through the whole review yet. It would be worth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated July 15, 2015, 11:54 p.m.)
Review request for mesos, Anand Mazumdar,
On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, lines 135-143
https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line135
Can we get these comments back ?
They're on the header file now, do we want them duplciate here?
On July
On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 126
https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line126
Whoops ! Let's return false as earlier. Also add a test-case for empty
check. ( Accept-Encoding )
Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91356
---
3rdparty/libprocess/src/http.cpp (line 206)
On July 10, 2015, 10:13 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 216
https://reviews.apache.org/r/36402/diff/1/?file=1008565#file1008565line216
I did not review the entire patch but I stopped at this. Seems like I
am missing something here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91361
---
Patch looks great!
Reviews applied: [36402]
All tests passed.
-
On July 10, 2015, 10:13 p.m., Anand Mazumdar wrote:
3rdparty/libprocess/src/http.cpp, line 216
https://reviews.apache.org/r/36402/diff/1/?file=1008565#file1008565line216
I did not review the entire patch but I stopped at this. Seems like I
am missing something here.
35 matches
Mail list logo
