Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92673
---

Ship it!


Ship It!

- Vinod Kone


On July 22, 2015, 10:54 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> ---
> 
> (Updated July 22, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu 


> On July 22, 2015, 10:30 p.m., Vinod Kone wrote:
> > src/tests/persistent_volume_tests.cpp, line 700
> > 
> >
> > Would it receive TASK_FAILED here or immediately after slave recovery 
> > finishes, irrespective of whether killTask was called?
> > 
> > Also, I would revert the dependency order of these reviews or just 
> > merge them.

Reordered the dependency.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92665
---


On July 22, 2015, 10:54 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> ---
> 
> (Updated July 22, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/
---

(Updated July 22, 2015, 10:54 p.m.)


Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.


Changes
---

Review comments.


Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124


Repository: mesos


Description
---

Added a persistent volume test for slave recovery.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
c5f72d5b7a118eb121e268f982955c73159a61e1 

Diff: https://reviews.apache.org/r/36683/diff/


Testing
---

make check

NOTE: this test will fail if the subsequent patch is not applied.


Thanks,

Jie Yu

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92665
---



src/tests/persistent_volume_tests.cpp (line 598)


s/TASK_FAILED/TASK_FAILED after slave finishes recovery/ ?



src/tests/persistent_volume_tests.cpp (line 700)


Would it receive TASK_FAILED here or immediately after slave recovery 
finishes, irrespective of whether killTask was called?

Also, I would revert the dependency order of these reviews or just merge 
them.


- Vinod Kone


On July 22, 2015, 8:09 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> ---
> 
> (Updated July 22, 2015, 8:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/
---

(Updated July 22, 2015, 8:09 p.m.)


Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.


Changes
---

Review comments.


Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124


Repository: mesos


Description
---

Added a persistent volume test for slave recovery.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
c5f72d5b7a118eb121e268f982955c73159a61e1 

Diff: https://reviews.apache.org/r/36683/diff/


Testing
---

make check

NOTE: this test will fail if the subsequent patch is not applied.


Thanks,

Jie Yu

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu 


> On July 22, 2015, 6:22 p.m., Vinod Kone wrote:
> > src/tests/persistent_volume_tests.cpp, lines 641-648
> > 
> >
> > This task doesn't look like it is writing a file but rather testing if 
> > the directory is present in a while loop?

Yes, it's testing if the persistent volume directory exists or not. Without 
applying the patch, the volume directory will be removed incorrectly and the 
task will become TASK_FAILED.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92621
---


On July 22, 2015, 6:59 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> ---
> 
> (Updated July 22, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92621
---



src/tests/persistent_volume_tests.cpp (lines 595 - 596)


Can you expand the comment on what it means for proper recovery? I couldn't 
tell from reading the test. Are you not expected to get TASK_KILLED if recovery 
fails?



src/tests/persistent_volume_tests.cpp (lines 641 - 648)


This task doesn't look like it is writing a file but rather testing if the 
directory is present in a while loop?


- Vinod Kone


On July 22, 2015, 6:59 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> ---
> 
> (Updated July 22, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
> https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-21 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/
---

Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.


Bugs: MESOS-3124
https://issues.apache.org/jira/browse/MESOS-3124


Repository: mesos


Description
---

Added a persistent volume test for slave recovery.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
c5f72d5b7a118eb121e268f982955c73159a61e1 

Diff: https://reviews.apache.org/r/36683/diff/


Testing
---

make check

NOTE: this test will fail if the subsequent patch is not applied.


Thanks,

Jie Yu