Re: Review Request 39939: Make docker_socket option support different protocols.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review141569
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On March 4, 2016, 6:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 6:10 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122052
---



Patch looks great!

Reviews applied: [39939]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 4, 2016, 6:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 6:10 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 6:10 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122012
---


Ship it!




Ship It!

- Klaus Ma


On March 4, 2016, 11:54 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 11:54 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:54 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comments.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122011
---




src/slave/containerizer/docker.cpp (lines 136 - 137)


I should mention this early, it was always good to add some detail info to 
the error messages or logs.

What about update the message as:

return Error("The current docker socket '" + flags.docker_socket + "' is 
not valid,"
 " only unix domain socket is supported for `docker_socket` 
when"
 " `docker_mesos_image` is enabled");


- Guangya Liu


On 三月 4, 2016, 3:41 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 三月 4, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:41 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > 
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.
> 
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
> `Docker::create` already added `unix:` prefix, the format of `docker_socket` 
> should be `tcp://0.0.0.0:2375, /var/run/docker.sock`
> 
> haosdent huang wrote:
> I think still could, when we pass unix:///var/run/docker.sock as 
> docker_socket. It would go into this, right?
> 
> ```
>   if (strings::startsWith(socket, "/")) {
> docker_ = new Docker(path, "unix://" + socket);
>   } else {
> docker_ = new Docker(path, socket); <--- If we use unix:///
>   }
> ```
> 
> Guangya Liu wrote:
> Yes, then what about update the configuration.md, flags.cpp etc by adding 
> unix:///var/run/docker.sock as a valid option?

Got it, let me update.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > 
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.
> 
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
> `Docker::create` already added `unix:` prefix, the format of `docker_socket` 
> should be `tcp://0.0.0.0:2375, /var/run/docker.sock`
> 
> haosdent huang wrote:
> I think still could, when we pass unix:///var/run/docker.sock as 
> docker_socket. It would go into this, right?
> 
> ```
>   if (strings::startsWith(socket, "/")) {
> docker_ = new Docker(path, "unix://" + socket);
>   } else {
> docker_ = new Docker(path, socket); <--- If we use unix:///
>   }
> ```

Yes, then what about update the configuration.md, flags.cpp etc by adding 
unix:///var/run/docker.sock as a valid option?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On 三月 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 三月 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

> On March 4, 2016, 11:02 a.m., Klaus Ma wrote:
> > src/slave/containerizer/docker.cpp, lines 136-138
> > 
> >
> > Two comments here:
> > 
> > 1. Error message; I'd like to say: "Failed to create docker container; 
> > only unix domain socket is supported for `docker_socket` when 
> > `docker_mesos_image` is enabled"
> > 2. Can you also highlight this limitation/restriction to document/help
> 
> haosdent huang wrote:
> Because outside exists
> 
> ```
>   Try containerizer =
> DockerContainerizer::create(flags, fetcher);
>   if (containerizer.isError()) {
> return Error("Could not create DockerContainerizer: " +
>  containerizer.error());
> ```
> 
> I change to `only unix domain socket is supported for docker_socket when 
> docker_mesos_image is enabled`.

That's OK to me, thanks :).


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122000
---


On March 4, 2016, 11:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > 
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.
> 
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
> `Docker::create` already added `unix:` prefix, the format of `docker_socket` 
> should be `tcp://0.0.0.0:2375, /var/run/docker.sock`

I think still could, when we pass unix:///var/run/docker.sock as docker_socket. 
It would go into this, right?

```
  if (strings::startsWith(socket, "/")) {
docker_ = new Docker(path, "unix://" + socket);
  } else {
docker_ = new Docker(path, socket); <--- If we use unix:///
  }
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > 
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.

Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
`Docker::create` already added `unix:` prefix, the format of `docker_socket` 
should be `tcp://0.0.0.0:2375, /var/run/docker.sock`


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On 三月 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 三月 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:13 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya and @klaus1982's comments.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:02 a.m., Klaus Ma wrote:
> > src/slave/containerizer/docker.cpp, lines 136-138
> > 
> >
> > Two comments here:
> > 
> > 1. Error message; I'd like to say: "Failed to create docker container; 
> > only unix domain socket is supported for `docker_socket` when 
> > `docker_mesos_image` is enabled"
> > 2. Can you also highlight this limitation/restriction to document/help

Because outside exists

```
  Try containerizer =
DockerContainerizer::create(flags, fetcher);
  if (containerizer.isError()) {
return Error("Could not create DockerContainerizer: " +
 containerizer.error());
```

I change to `only unix domain socket is supported for docker_socket when 
docker_mesos_image is enabled`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122000
---


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > 
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.

As I check, it should support if you run `docker -H unix://`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---




src/slave/containerizer/docker.cpp (line 134)


Does the `docker_socket` support starting wit `unix:`? I think not, because 
the `Docker::create` will add `unix:` automatically.


- Guangya Liu


On 三月 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 三月 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122000
---




src/slave/containerizer/docker.cpp (lines 133 - 135)


I think we can use on `if` here: `if (docker_mesos_images.isSome && 
!startWith(unix) && !startWith("/"))`.



src/slave/containerizer/docker.cpp (lines 136 - 138)


Two comments here:

1. Error message; I'd like to say: "Failed to create docker container; only 
unix domain socket is supported for `docker_socket` when `docker_mesos_image` 
is enabled"
2. Can you also highlight this limitation/restriction to document/help


- Klaus Ma


On March 4, 2016, 10:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > 
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
> Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?
> 
> haosdent huang wrote:
> My concern here is if we use host network when we launch slave in docker, 
> use tcp protocol should still works.
> 
> Klaus Ma wrote:
> When `docker_mesos_image` is enabled, `docker_socket` are mounted into 
> docker by volume which is not worked for TCP ( 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L293
>  ).
> 
> IMO, two options:
> 
> 1. Highlight in document that TCP docker_socket can not work with 
> `docker_mesos_image`
> 2. Add logic for `docker_mesos_image`, just pass docker_socket into slave 
> in docker instead of mounting it; we also need to update document that it's 
> user's responsibility to make sure network is accessable.

Thank you very much. I add a check here.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 2:23 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @klaus1982's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

> On Feb. 22, 2016, 12:41 p.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > 
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
> Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?
> 
> haosdent huang wrote:
> My concern here is if we use host network when we launch slave in docker, 
> use tcp protocol should still works.

When `docker_mesos_image` is enabled, `docker_socket` are mounted into docker 
by volume which is not worked for TCP ( 
https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L293
 ).

IMO, two options:

1. Highlight in document that TCP docker_socket can not work with 
`docker_mesos_image`
2. Add logic for `docker_mesos_image`, just pass docker_socket into slave in 
docker instead of mounting it; we also need to update document that it's user's 
responsibility to make sure network is accessable.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On March 4, 2016, 12:40 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 3, 2016, 4:40 p.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Rebase and address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > 
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
> Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?

My concern here is if we use host network when we launch slave in docker, use 
tcp protocol should still works.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On March 3, 2016, 4:40 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > 
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.

Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a check 
here?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On Feb. 22, 2016, 3:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Feb. 22, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---




src/slave/flags.cpp (line 437)


I think we need to handle feature interaction with `docker_mesos_image`. 
Currently, we mount unix socket into container; but it'll failed when using TCP 
socket.


- Klaus Ma


On Feb. 22, 2016, 11:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Feb. 22, 2016, 11:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120094
---




docs/configuration.md (line 1029)


s/unix:///var/run/docker.sock//var/run/docker.sock ?

Or else the Line 105 in docker.cpp may need some update.



docs/configuration.md (line 1030)


s/default/by default



src/slave/flags.cpp (line 441)


by default


- Guangya Liu


On 二月 22, 2016, 3:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated 二月 22, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review107466
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 4, 2015, 5:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Nov. 4, 2015, 5:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review105105
---


Patch looks great!

Reviews applied: [39939]

All tests passed.

- Mesos ReviewBot


On Nov. 4, 2015, 5:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Nov. 4, 2015, 5:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs
-

  docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
  src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
  src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
  src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang