Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114672 --- Ship it! Very nice! I'll make some minor adjustments based on the

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114633 --- Patch looks great! Reviews applied: [42053, 42212] Passed command

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 15, 2016, 12:49 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114615 --- src/tests/master_tests.cpp (line 4032)

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114599 --- These issues ae based on offline discussions with bmahler. src/te

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114539 --- Patch looks great! Reviews applied: [42053, 42212] Passed command

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 14, 2016, 4:11 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114385 --- src/tests/master_tests.cpp (line 3989)

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114384 --- src/tests/master_tests.cpp (line 4090)

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114382 --- Talking to bmahler offline, we decided to split the current test in

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114198 --- Patch looks great! Reviews applied: [42053, 42212] Passed command

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 13, 2016, 11:01 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114119 --- Patch looks great! Reviews applied: [42053, 42212] Passed command

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- (Updated Jan. 12, 2016, 10:12 p.m.) Review request for mesos and Ben Mahler.

Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3307 https://issues.ap