Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review120045 --- Hm.. I would expect this patch to be testing the functionality

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119369 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490]

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- (Updated Feb. 16, 2016, 6:23 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- (Updated Feb. 16, 2016, 6:20 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43490: Added testcase for TASK_KILLING state.

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, lines 575-576 > > > > > > one line I think this the common style adapted across all of the test cases, so I am keeping them as

Re: Review Request 43490: Added testcase for TASK_KILLING state.

> On Feb. 16, 2016, 10:27 a.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, lines 578-579 > > > > > > one line Dropping the issue for the same reason like above. - Abhishek

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119289 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490]

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review119285 --- src/tests/mesos.hpp (line 420)

Re: Review Request 43490: Added testcase for TASK_KILLING state.

> On Feb. 12, 2016, 10:50 a.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, lines 476-483 > > > > > > I think that this case cannot cover the case of framework capabaility > > `TASK_KILLING_STATE`, what

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- (Updated Feb. 16, 2016, 8:29 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review118992 --- src/tests/scheduler_tests.cpp (lines 476 - 483)

Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4547

Re: Review Request 43490: Added testcase for TASK_KILLING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43490/#review118895 --- Patch looks great! Reviews applied: [43487, 43488, 43489, 43490]