---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123738
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 15, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---
(Updated March 15, 2016, 3:37 p.m.)
Review request for mesos and Benjamin Banni
> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but
> > what I find unfortunate about your approach is that with this patch we'd
> > create a temporary directory and incur the overhead for all tests in this
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123660
---
Fix it, then Ship it!
3rdparty/libprocess/src/tests/io_tests.c
> On March 4, 2016, 8:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but
> > what I find unfortunate about your approach is that with this patch we'd
> > create a temporary directory and incur the overhead for all tests in this
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123593
---
Patch looks great!
Reviews applied: [44380]
Passed command: expo
> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote:
> > Looks mostly good to me. I left some comments, but if you want to make any
> > progress here you'll still need to find a shepherd (see
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/).
>
> Yong Tang wrote:
> T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---
(Updated March 15, 2016, 1:38 a.m.)
Review request for mesos and Benjamin Banni
> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote:
> > Looks mostly good to me. I left some comments, but if you want to make any
> > progress here you'll still need to find a shepherd (see
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/).
Thanks for the help Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123382
---
Looks mostly good to me. I left some comments, but if you want to
> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but
> > what I find unfortunate about your approach is that with this patch we'd
> > create a temporary directory and incur the overhead for all tests in this
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122168
---
Patch looks great!
Reviews applied: [44380]
Passed command: expo
> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but
> > what I find unfortunate about your approach is that with this patch we'd
> > create a temporary directory and incur the overhead for all tests in this
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---
(Updated March 4, 2016, 6:56 p.m.)
Review request for mesos and Benjamin Bannie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122073
---
Patch looks great!
Reviews applied: [44380]
Passed command: expo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---
I think using a `TemporaryDirectoryTest` fixture is the right appr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122027
---
Ship it!
Ship It!
- haosdent huang
On March 4, 2016, 7:27 a.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-4807
https://iss
18 matches
Mail list logo