Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 757
> > 
> >
> > What about `ShareableInfo`? This is also consistent with 
> > `RevocableInfo`.
> 
> Anindya Sinha wrote:
> I am not sure if that is a huge deal though. I would prefer to keep it as 
> ShareInfo, but if there is a strong opinion regarding this I am open to 
> change this to ShareableInfo.

Updated to SharedInfo


> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > s/optional ShareInfo share/optional ShareableInfo shareable
> 
> Anindya Sinha wrote:
> Will change as appropriate.

Updated to `optional SharedInfo shared`.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---


On April 29, 2016, 12:15 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 29, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > How about `optional SharedInfo shared`?
> > 
> > [shareable](http://www.merriam-webster.com/dictionary/shareable): 
> > capable of being shared
> > 
> > The following sentences read pretty clear to me.
> > - Some resource types in Mesos are shareable.
> > - Currently only persistent volumes are shareable. (This has nothing to 
> > do with whether `SHARE` operation has been applied, just that this type of 
> > resource can be made shared.)
> > - The `SHARE` operation makes a nonshared resource **shared**. 
> > - The `UNSHARE` operation makes **shared** resource nonshared.
> > - `SharedInfo` is currently empty but in the future we may add policies 
> > around how this resource should be **shared**.
> > 
> > Plus we can compare this with `shared_ptr` which is semantically very 
> > similar.
> > 
> > If we agree to this please also change the use of these words elsewhere 
> > appropriately.
> 
> Anindya Sinha wrote:
> I think ShareInfo seems fine to me. However, I think if there is a strong 
> opinion regarding this, I think Shareable is better simply because it 
> describes the resource (ie. adjective) and is on the same principles as 
> Revocable (as pointed by Guangya Liu).
> However, I stringly believe ShareInfo should be fine.
> 
> Guangya Liu wrote:
> In my understaind, I think that this is similar with `RevocableInfo` as 
> following:
> 
>   message RevocableInfo {}
> 
>   // If this is set, the resources are revocable, i.e., any tasks or
>   // executors launched using these resources could get preempted or
>   // throttled at any time. This could be used by frameworks to run
>   // best effort tasks that do not need strict uptime or performance
>   // guarantees. Note that if this is set, 'disk' or 'reservation'
>   // cannot be set.
>   optional RevocableInfo revocable = 9;
> 
> Agree with Anindya, using the concept of `Shareable` will have same 
> principal with `Revocable`.
> 
> Jiang Yan Xu wrote:
> `shared` and `shareable` are both adjectives, `share` is a verb.
> 
> `shareable` and `shared` have similar meanings except that former 
> emphasizes on **capability** and the latter on the **state**: operation SHARE 
> marks a resource shared just like RESERVE marks a resource reserved 
> (`Resources::isReserved()`), even though in protobuf it's captured by a noun 
> `reservation`.
> 
> Besides IMO **shared** describes the **status** better, my concerns is 
> that in the future we'll need APIs for determining if some resources **are 
> capable of being shared** (`Resources::isShareable(...)`) and we lose the 
> word to conveniently describe it if we use it for something else now. (If 
> this was a one off thing we wouldn't even call it shared resources, just 
> shared volumes).
> 
> My apologies that dicussions around this should have been captured 
> earlier in the design phase but since it's a public API I think we should be 
> more rigorous otherwise it requires deprecation and carefully orchestrated 
> upgrades, etc. to change it in the future.
> 
> Thoughts?

I am not convinced that `shared` is better than `shareable`. However, I do not 
think that it is a great use of time to discuss this further. So, I shall 
change the protobuf field to `shared`. Sounds ok?


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
---


On April 29, 2016, 12:15 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 29, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/
---

(Updated April 29, 2016, 12:15 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Clarified comments within the Resource protobuf.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
---

Added ShareInfo in Resource protobuf to allow for sharing of resources.


Diffs (updated)
-

  include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
  include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 

Diff: https://reviews.apache.org/r/45958/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Jiang Yan Xu]

> On April 17, 2016, 11:47 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > How about `optional SharedInfo shared`?
> > 
> > [shareable](http://www.merriam-webster.com/dictionary/shareable): 
> > capable of being shared
> > 
> > The following sentences read pretty clear to me.
> > - Some resource types in Mesos are shareable.
> > - Currently only persistent volumes are shareable. (This has nothing to 
> > do with whether `SHARE` operation has been applied, just that this type of 
> > resource can be made shared.)
> > - The `SHARE` operation makes a nonshared resource **shared**. 
> > - The `UNSHARE` operation makes **shared** resource nonshared.
> > - `SharedInfo` is currently empty but in the future we may add policies 
> > around how this resource should be **shared**.
> > 
> > Plus we can compare this with `shared_ptr` which is semantically very 
> > similar.
> > 
> > If we agree to this please also change the use of these words elsewhere 
> > appropriately.
> 
> Anindya Sinha wrote:
> I think ShareInfo seems fine to me. However, I think if there is a strong 
> opinion regarding this, I think Shareable is better simply because it 
> describes the resource (ie. adjective) and is on the same principles as 
> Revocable (as pointed by Guangya Liu).
> However, I stringly believe ShareInfo should be fine.
> 
> Guangya Liu wrote:
> In my understaind, I think that this is similar with `RevocableInfo` as 
> following:
> 
>   message RevocableInfo {}
> 
>   // If this is set, the resources are revocable, i.e., any tasks or
>   // executors launched using these resources could get preempted or
>   // throttled at any time. This could be used by frameworks to run
>   // best effort tasks that do not need strict uptime or performance
>   // guarantees. Note that if this is set, 'disk' or 'reservation'
>   // cannot be set.
>   optional RevocableInfo revocable = 9;
> 
> Agree with Anindya, using the concept of `Shareable` will have same 
> principal with `Revocable`.

`shared` and `shareable` are both adjectives, `share` is a verb.

`shareable` and `shared` have similar meanings except that former emphasizes on 
**capability** and the latter on the **state**: operation SHARE marks a 
resource shared just like RESERVE marks a resource reserved 
(`Resources::isReserved()`), even though in protobuf it's captured by a noun 
`reservation`.

Besides IMO **shared** describes the **status** better, my concerns is that in 
the future we'll need APIs for determining if some resources **are capable of 
being shared** (`Resources::isShareable(...)`) and we lose the word to 
conveniently describe it if we use it for something else now. (If this was a 
one off thing we wouldn't even call it shared resources, just shared volumes).

My apologies that dicussions around this should have been captured earlier in 
the design phase but since it's a public API I think we should be more rigorous 
otherwise it requires deprecation and carefully orchestrated upgrades, etc. to 
change it in the future.

Thoughts?


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
---


On April 8, 2016, 4:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Guangya Liu]

> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > How about `optional SharedInfo shared`?
> > 
> > [shareable](http://www.merriam-webster.com/dictionary/shareable): 
> > capable of being shared
> > 
> > The following sentences read pretty clear to me.
> > - Some resource types in Mesos are shareable.
> > - Currently only persistent volumes are shareable. (This has nothing to 
> > do with whether `SHARE` operation has been applied, just that this type of 
> > resource can be made shared.)
> > - The `SHARE` operation makes a nonshared resource **shared**. 
> > - The `UNSHARE` operation makes **shared** resource nonshared.
> > - `SharedInfo` is currently empty but in the future we may add policies 
> > around how this resource should be **shared**.
> > 
> > Plus we can compare this with `shared_ptr` which is semantically very 
> > similar.
> > 
> > If we agree to this please also change the use of these words elsewhere 
> > appropriately.
> 
> Anindya Sinha wrote:
> I think ShareInfo seems fine to me. However, I think if there is a strong 
> opinion regarding this, I think Shareable is better simply because it 
> describes the resource (ie. adjective) and is on the same principles as 
> Revocable (as pointed by Guangya Liu).
> However, I stringly believe ShareInfo should be fine.

In my understaind, I think that this is similar with `RevocableInfo` as 
following:

  message RevocableInfo {}

  // If this is set, the resources are revocable, i.e., any tasks or
  // executors launched using these resources could get preempted or
  // throttled at any time. This could be used by frameworks to run
  // best effort tasks that do not need strict uptime or performance
  // guarantees. Note that if this is set, 'disk' or 'reservation'
  // cannot be set.
  optional RevocableInfo revocable = 9;

Agree with Anindya, using the concept of `Shareable` will have same principal 
with `Revocable`.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
---


On April 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > How about `optional SharedInfo shared`?
> > 
> > [shareable](http://www.merriam-webster.com/dictionary/shareable): 
> > capable of being shared
> > 
> > The following sentences read pretty clear to me.
> > - Some resource types in Mesos are shareable.
> > - Currently only persistent volumes are shareable. (This has nothing to 
> > do with whether `SHARE` operation has been applied, just that this type of 
> > resource can be made shared.)
> > - The `SHARE` operation makes a nonshared resource **shared**. 
> > - The `UNSHARE` operation makes **shared** resource nonshared.
> > - `SharedInfo` is currently empty but in the future we may add policies 
> > around how this resource should be **shared**.
> > 
> > Plus we can compare this with `shared_ptr` which is semantically very 
> > similar.
> > 
> > If we agree to this please also change the use of these words elsewhere 
> > appropriately.

I think ShareInfo seems fine to me. However, I think if there is a strong 
opinion regarding this, I think Shareable is better simply because it describes 
the resource (ie. adjective) and is on the same principles as Revocable (as 
pointed by Guangya Liu).
However, I stringly believe ShareInfo should be fine.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
---


On April 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 757
> > 
> >
> > What about `ShareableInfo`? This is also consistent with 
> > `RevocableInfo`.

I am not sure if that is a huge deal though. I would prefer to keep it as 
ShareInfo, but if there is a strong opinion regarding this I am open to change 
this to ShareableInfo.


> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > s/optional ShareInfo share/optional ShareableInfo shareable

Will change as appropriate.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---


On April 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Jiang Yan Xu]

> On April 9, 2016, 12:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 756
> > 
> >
> > s/containers/tasks ? Tasks may be more clear here.

+1.

There are quite a number of details about how tasks and containers relate here 
w.r.t shared resources (e.g., even within a container multiple tasks can use 
the same shared resource) but here I think to avoid getting into too much 
details `tasks` is easier to understand and is certainly correct.


> On April 9, 2016, 12:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 761
> > 
> >
> > Can you please add a note here that this pareameter is only work for 
> > persiste volume for now?

+1.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---


On April 8, 2016, 4:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
---




include/mesos/mesos.proto (line 762)


How about `optional SharedInfo shared`?

[shareable](http://www.merriam-webster.com/dictionary/shareable): capable 
of being shared

The following sentences read pretty clear to me.
- Some resource types in Mesos are shareable.
- Currently only persistent volumes are shareable. (This has nothing to do 
with whether `SHARE` operation has been applied, just that this type of 
resource can be made shared.)
- The `SHARE` operation makes a nonshared resource **shared**. 
- The `UNSHARE` operation makes **shared** resource nonshared.
- `SharedInfo` is currently empty but in the future we may add policies 
around how this resource should be **shared**.

Plus we can compare this with `shared_ptr` which is semantically very 
similar.

If we agree to this please also change the use of these words elsewhere 
appropriately.


- Jiang Yan Xu


On April 8, 2016, 4:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 8, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---




include/mesos/mesos.proto (line 756)


s/containers/tasks ? Tasks may be more clear here.



include/mesos/mesos.proto (line 757)


What about `ShareableInfo`? This is also consistent with `RevocableInfo`.



include/mesos/mesos.proto (line 759)


s/i.e./i.e.,



include/mesos/mesos.proto (line 761)


Can you please add a note here that this pareameter is only work for 
persiste volume for now?



include/mesos/mesos.proto (line 762)


s/optional ShareInfo share/optional ShareableInfo shareable


- Guangya Liu


On 四月 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated 四月 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
---

Added ShareInfo in Resource protobuf to allow for sharing of resources.


Diffs
-

  include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
  include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 

Diff: https://reviews.apache.org/r/45958/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha