Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-25 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134796
---


Ship it!




Ship It!

- Vinod Kone


On May 24, 2016, 2:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 24, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134519
---



Patch looks great!

Reviews applied: [47695]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 24, 2016, 2:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 24, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> >

Hi, @janisz Really appreciate your favour to help test this! Just updated, may 
you help to review this again? Thank you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134408
---


On May 24, 2016, 2:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 24, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

(Updated May 24, 2016, 2:38 a.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @janisz's comments.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.
* updated `release-guide.md` with the new website generation and
  development workflows.


Diffs (updated)
-

  docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
  site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing
---

Tested in OS X and Ubuntu 14.04

For document changes, could verified from 
https://github.com/haosdent/mesos/tree/MESOS-5431/site

To verify website works fine after this changes, could check it via this gif:

![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)


Thanks,

haosdent huang

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > site/README.md, line 12
> > 
> >
> > Running this command will end up with error: `unable to prepare 
> > context: unable to evaluate symlinks in context path: lstat no such file or 
> > directory`. Later this document assumed user is in `site` dir. To be 
> > consistend replace `site` with `.`

Oh, I former document, we suppose user under `mesos` root directory

```
docker build -t mesos/website support/site-docker
```

Let me describe this in the document.


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > support/site-docker/Dockerfile, line 6
> > 
> >
> > Do we really need whole `Development Tools` to build website.

Good catch! We only need `gcc-c++ make` to build the native library when 
`bundle install`.


> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote:
> > site/README.md, line 47
> > 
> >
> > I think this section needs example that will work for 99% users.

Good suggestion! Let me add.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134408
---


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134425
---



Patch looks great!

Reviews applied: [47695]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski 


> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote:
> >
> 
> haosdent huang wrote:
> Hi, @janisz. Thank you very much for your detail reviews, may you help to 
> review this patch again? Thank you in advance.

Tested. LGTM but I left some minor comments.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134318
---


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134408
---




site/README.md (line 9)


Running this command will end up with error: `unable to prepare context: 
unable to evaluate symlinks in context path: lstat no such file or directory`. 
Later this document assumed user is in `site` dir. To be consistend replace 
`site` with `.`



site/README.md (line 32)


I think this section needs example that will work for 99% users.



support/site-docker/Dockerfile (line 6)


Do we really need whole `Development Tools` to build website.


- Tomasz Janiszewski


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134404
---




support/site-docker/Dockerfile (line 10)


We have to use `en_US.UTF-8` otherwise `rake` would failed when I test this.


- haosdent huang


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134403
---




site/Rakefile (line 75)


My bad that didn't update it correctly in 
https://reviews.apache.org/r/47698/


- haosdent huang


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134400
---




site/Gemfile.lock (line 100)


`Gemfile.lock` is generated by `bundle install`. Because we add `gem 
"therubyracer"` to Gemfile, `bundle install` update this file.


- haosdent huang


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 


> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote:
> >

Hi, @janisz. Thank you very much for your detail reviews, may you help to 
review this patch again? Thank you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134318
---


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 


> On May 22, 2016, 5:46 p.m., Vinod Kone wrote:
> > site/Rakefile, line 5
> > 
> >
> > shouldn't the "build" task happen after "doxygen" and "javadoc"?

According my test, there are not differences not matter we put it before 
`:build` or after `:build`. I put it after `:build` because I saw

```
The doxygen and javadoc pages must be generated after running rake.
```

in https://github.com/apache/mesos/tree/master/site

But let me move it before `:build` because not differences.


> On May 22, 2016, 5:46 p.m., Vinod Kone wrote:
> > site/Rakefile, lines 75-82
> > 
> >
> > why the change from "pubish" to "source" here?

haha, there is a long story here. At first, I use `publish` folder when 
generate `javadoc` and `doxygen`.
However, `middleman server` only serve files under `sources`(`middlman server` 
would generate a sitemap structure internal and route requests by it). If we 
want to make it serve files for our custom folder under `publish`, we need to 
upgrade `middleman` from 3 to 4 and use `import_path` config item.
After I upgrade `middleman` to 4, I find the site broken and try to fix them 
and make it work under `middleman` 4 . Eventually, I neary change almost files 
under `site` folder... At that time, I think the better way is just put then 
under `source` folder when generate `javadoc` and `doxygen`.

We still could keep it use `publish` here, and it should be shown after we 
public it to the apache website. However, we could not preview `javadoc` and 
`doxygen` locally when using `middleman server`. So I perfer to use `source` 
folder here.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134279
---


On May 23, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 23, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

(Updated May 23, 2016, 5:49 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @vinodkone, @janisz's comments.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description (updated)
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.
* updated `release-guide.md` with the new website generation and
  development workflows.


Diffs (updated)
-

  docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
  site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing (updated)
---

Tested in OS X and Ubuntu 14.04

For document changes, could verified from 
https://github.com/haosdent/mesos/tree/MESOS-5431/site

To verify website works fine after this changes, could check it via this gif:

![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)


Thanks,

haosdent huang

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134318
---




site/Dockerfile (line 1)


Why not officail [Ruby image](https://hub.docker.com/_/ruby/)



site/Dockerfile (line 8)


We can get rid of nodejs by adding `gem 'therubyracer'` to `Gemfile


- Tomasz Janiszewski


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134279
---




site/README.md (line 15)


I think `make` is enough here?



site/README.md (line 36)


s/Git/git/



site/README.md (lines 63 - 68)


The old version of the text here is fine. No need to update it.



site/Rakefile (line 5)


shouldn't the "build" task happen after "doxygen" and "javadoc"?



site/Rakefile (lines 75 - 82)


why the change from "pubish" to "source" here?



site/build.sh (lines 28 - 30)


bundle install && rake && rake dev


- Vinod Kone


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134265
---



Patch looks great!

Reviews applied: [47695]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

(Updated May 22, 2016, 10:45 a.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Add testing done.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.


Diffs
-

  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Dockerfile PRE-CREATION 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing (updated)
---

Tested in OS X and Ubuntu 14.04

For document changes, could verified from 
https://github.com/haosdent/mesos/tree/MESOS-5431/site


Thanks,

haosdent huang

Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.


Diffs
-

  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Dockerfile PRE-CREATION 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing
---


Thanks,

haosdent huang