[GitHub] spark pull request: [SPARK-11476] [DOCS] Incorrect function referr...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9529#issuecomment-154564660 **[Test build #45261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45261/consoleFull)** for PR 9529 at commit

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44197538 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StateSpec.scala --- @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154570059 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-154574543 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9409#discussion_r44198806 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -419,3 +419,30 @@ case class

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9409#issuecomment-154574551 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9409#discussion_r44198887 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -419,3 +419,30 @@ case class

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-06 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-154575961 /cc @rxin @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44201615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -151,6 +164,30 @@ abstract class Expression extends

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44201576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -151,6 +164,30 @@ abstract class Expression extends

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44202414 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -135,6 +147,7 @@ abstract class Expression extends

[GitHub] spark pull request: [SPARK-8467][MLlib][PySpark] Add LDAModel.desc...

2015-11-06 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/8643#issuecomment-154585403 @jkbradley @davies could you review it? I modified the type conversion using `SerDe.dumps`. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-154585601 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154585515 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154585547 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8514] LU factorization on BlockMatrix

2015-11-06 Thread nilmeier
Github user nilmeier commented on the pull request: https://github.com/apache/spark/pull/8563#issuecomment-154591819 I'll look through this, thank you. I usually follow the style guide conventions while running the scripts, but I have missed some of the other conventions.​

[GitHub] spark pull request: [HOTFIX] Fix python tests after #9527

2015-11-06 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9533 [HOTFIX] Fix python tests after #9527 #9527 missed updating the python tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marmbrus/spark

[GitHub] spark pull request: [SPARK-11433] [SQL] Cleanup the subquery name ...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9385#issuecomment-154594596 Thanks for your contribution, but I'm tempted to not make this change unless there is actually a bug. We are eliminating the subqueries because they will impact

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2015-11-06 Thread gliptak
Github user gliptak commented on the pull request: https://github.com/apache/spark/pull/9532#issuecomment-154594465 The error message displayed seems to have no relation to the pull request change ... The compile does fail with: [error]

[GitHub] spark pull request: [SPARK-11566][MLlib][Python] Refactoring Gauss...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9534#issuecomment-154597554 **[Test build #45276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45276/consoleFull)** for PR 9534 at commit

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154597482 **[Test build #45269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45269/consoleFull)** for PR 9531 at commit

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44205755 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -151,6 +164,30 @@ abstract class Expression

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154597511 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11476] [DOCS] Incorrect function referr...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9529#issuecomment-154564850 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11217][ML] save/load for non-meta estim...

2015-11-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9454#issuecomment-154567630 Spark merge script not happy. Maybe a conflict was just introduced? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-154567482 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9344#discussion_r44196614 --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryPool.scala --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11555] spark on yarn spark-class --num-...

2015-11-06 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9523#issuecomment-154575019 LGTM. One day I'd like to see this duplication of command-line arguments vs. SparkConf entries go away... Merging to the 3 branches. --- If your project is set

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44200916 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -203,6 +203,10 @@ case class

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44202059 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44202038 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44202061 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -275,8 +275,9 @@ object

[GitHub] spark pull request: [SPARK-9241][SQL] Supporting multiple DISTINCT...

2015-11-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9406#discussion_r44203475 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala --- @@ -213,3 +216,178 @@ object Utils {

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44203476 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44203542 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [HOTFIX] Fix python tests after #9527

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44205619 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala --- @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44205625 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala --- @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-154564354 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-154564403 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11217][ML] save/load for non-meta estim...

2015-11-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9454#issuecomment-154567840 Nevermind, second time's the charm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9241][SQL] Supporting multiple DISTINCT...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9406#discussion_r44198936 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala --- @@ -213,3 +216,178 @@ object Utils {

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-154574561 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9409#issuecomment-154574766 This is great. Only minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9409#issuecomment-154574581 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9480#discussion_r44201792 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154583398 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-154583314 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44202262 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: SPARK-11565 Replace deprecated DigestUtils.sha...

2015-11-06 Thread gliptak
GitHub user gliptak opened a pull request: https://github.com/apache/spark/pull/9532 SPARK-11565 Replace deprecated DigestUtils.shaHex call You can merge this pull request into a Git repository by running: $ git pull https://github.com/gliptak/spark SPARK-11565 Alternatively

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9531#discussion_r44202704 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -1478,18 +1478,54 @@ class DataFrame private[sql]( /** *

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154586827 **[Test build #45263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45263/consoleFull)** for PR 9480 at commit

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154586930 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44203245 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9409#discussion_r44203342 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -419,3 +419,30 @@ case class

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9409#discussion_r44203267 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -419,3 +419,30 @@ case class

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44203695 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/9513#issuecomment-154590891 Made a pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11044][SQL] Parquet writer version fixe...

2015-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9060#issuecomment-154597634 @liancheng I assume you missed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-15459 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-154597740 **[Test build #45272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45272/consoleFull)** for PR 9488 at commit

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154599114 Alright, going to merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-9065][Streaming][PySpark] Add MessageHa...

2015-11-06 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7410#issuecomment-154563459 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11217][ML] save/load for non-meta estim...

2015-11-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9454#issuecomment-154567294 I'll merge this with branch-1.6 and master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11561][SQL] Rename text data source's c...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154567189 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-154567471 **[Test build #45264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45264/consoleFull)** for PR 9524 at commit

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44198001 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StateSpec.scala --- @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154571410 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154578494 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-11420 Updating Stddev support via Impera...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-154579413 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11269][SQL] Java API support & test cas...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9528#issuecomment-154579447 **[Test build #45253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45253/consoleFull)** for PR 9528 at commit

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154579300 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11410] [PYSPARK] Add python bindings fo...

2015-11-06 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9504#issuecomment-154579437 Since the last commit only updated the doc, I will merge this into master and 1.6 branch, thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154579345 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44200358 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/StateMap.scala --- @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9409#issuecomment-154579232 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11451][SQL] Support single distinct cou...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9409#issuecomment-154579253 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9531#issuecomment-154579148 **[Test build #45269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45269/consoleFull)** for PR 9531 at commit

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-154583982 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4557] [Streaming] Spark Streaming forea...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9488#issuecomment-154584002 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...

2015-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7888#discussion_r44201943 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -88,7 +88,8 @@ private[spark] class TaskSchedulerImpl( val

[GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...

2015-11-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/7888#discussion_r44201957 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -88,7 +88,8 @@ private[spark] class TaskSchedulerImpl( val

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44202348 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44202796 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9531#discussion_r44202818 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -1478,18 +1478,54 @@ class DataFrame private[sql]( /** *

[GitHub] spark pull request: [SPARK-11564][SQL] Dataset Java API audit

2015-11-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9531#discussion_r44202846 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -1478,18 +1478,54 @@ class DataFrame private[sql]( /** *

[GitHub] spark pull request: [SPARK-5565] [ML] LDA wrapper for Pipelines AP...

2015-11-06 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9513#discussion_r44203600 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-9241][SQL] Supporting multiple DISTINCT...

2015-11-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9406#discussion_r44203629 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala --- @@ -213,3 +216,178 @@ object Utils {

[GitHub] spark pull request: [SPARK-9241][SQL] Supporting multiple DISTINCT...

2015-11-06 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/9406#discussion_r44203639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala --- @@ -213,3 +216,178 @@ object Utils {

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154590257 **[Test build #1999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1999/consoleFull)** for PR 9480 at commit

[GitHub] spark pull request: SPARK-11420 Updating Stddev support via Impera...

2015-11-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-154593369 Even though its simple, I think this implementation is boxing the result, which could result in slower performance on real workloads (but is harder to see in micro

[GitHub] spark pull request: [SPARK-11555] spark on yarn spark-class --num-...

2015-11-06 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/9523#issuecomment-154598834 @tgravescs , sorry for missing this parameter `--num-workers`. I suppose user will not directly invoke yarn client through `spark-class`. Also from

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-154602302 **[Test build #45277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45277/consoleFull)** for PR 9535 at commit

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154568105 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154568133 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11389][CORE] Add support for off-heap m...

2015-11-06 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9344#issuecomment-154568018 LGTM, pending on tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11217][ML] save/load for non-meta estim...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-11-06 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r44197569 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StateSpec.scala --- @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-10371] [SQL] Implement subexpr eliminat...

2015-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9480#issuecomment-154570265 **[Test build #1999 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1999/consoleFull)** for PR 9480 at commit

  1   2   3   4   5   6   7   8   >