[GitHub] spark pull request: [SPARK-11684] [R] [ML] [Doc] Update SparkR glm...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9727#issuecomment-157334398 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11684] [R] [ML] [Doc] Update SparkR glm...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9727#issuecomment-157334049 **[Test build #46077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46077/consoleFull)** for PR 9727 at commit

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157337188 **[Test build #2074 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2074/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157336863 [Test build #2073 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2073/consoleFull) for PR 9367 at commit

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9748#discussion_r45046886 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -377,6 +374,55 @@ private[serializer] object KryoSerializer {

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9748#discussion_r45046890 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -377,6 +374,55 @@ private[serializer] object KryoSerializer {

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9748#issuecomment-157340731 Oh I didn't notice that #9243 was reverted. So `RoaringBitmap` is still a direct dependency, and before this PR, Kryo can't serialize it properly. Then this LGTM

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45052442 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0;

[GitHub] spark pull request: [SPARK-11751]Doc describe error in the "Spark ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9734#issuecomment-157360669 **[Test build #2077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2077/consoleFull)** for PR 9734 at commit

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157362476 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157362475 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157362455 **[Test build #46081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46081/consoleFull)** for PR 9740 at commit

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157362569 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157371547 **[Test build #46082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46082/consoleFull)** for PR 9763 at commit

[GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7888#issuecomment-157335123 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7888#issuecomment-157335041 **[Test build #46073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46073/consoleFull)** for PR 7888 at commit

[GitHub] spark pull request: [SPARK-11698][Streaming] Add option to ignore ...

2015-11-17 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/9665#issuecomment-157335148 This seems like a very very specific niche use case. I am not sure whether this sort of a one-off option is a good idea. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11779][DOCS] Fix reference to deprecate...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9768#issuecomment-157346906 **[Test build #2076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2076/consoleFull)** for PR 9768 at commit

[GitHub] spark pull request: [SPARK-11775][PYSPARK][SQL] Allow PySpark to r...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9766#issuecomment-157350327 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11775][PYSPARK][SQL] Allow PySpark to r...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9766#issuecomment-157350194 **[Test build #46078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46078/consoleFull)** for PR 9766 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157363022 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/9707#issuecomment-157334797 LGTM. I wonder whether we can add a unit test to test this behavior. We could create a CheckpointWriter with a mock JobGenerator, and then test whether the latest

[GitHub] spark pull request: [SPARK-11684] [R] [ML] [Doc] Update SparkR glm...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9727#issuecomment-157334397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9748#issuecomment-157340460 Lacking background knowledge to sign off this one. Referenced discussions in #9243, https://github.com/metamx/spark/pull/1, SPARK-5949, and SPARK-11016. If understand

[GitHub] spark pull request: [SPARK-11775][PYSPARK][SQL] Allow PySpark to r...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9766#issuecomment-157350329 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9552] Add force control for killExecuto...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7888#issuecomment-157335125 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157338196 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157338193 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9748#discussion_r45046892 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -377,6 +374,55 @@ private[serializer] object KryoSerializer {

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/9748#discussion_r45046897 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -377,6 +374,55 @@ private[serializer] object KryoSerializer {

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9748#issuecomment-157341226 Yep, LGTM, thanks for going back and taking care of this loose end @davies --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157341345 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157342417 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157342415 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11767] [SQL] limit the size of caced ba...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9760#issuecomment-157342723 This changes LGTM, but I don't quite understand this line in the PR description: > ... This PR introduce a hard limit as 4M for total columns (up to 50

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354774 **[Test build #46070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46070/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11740][Streaming]Fix the race condition...

2015-11-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9707#discussion_r45044684 --- Diff: python/pyspark/streaming/tests.py --- @@ -699,11 +698,11 @@ def check_output(n): # Verify that getOrCreate() uses existing SparkContext

[GitHub] spark pull request: [SPARK-9026] Modifications to JobWaiter, Futur...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9264#issuecomment-157338424 **[Test build #2075 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2075/consoleFull)** for PR 9264 at commit

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157342265 **[Test build #46075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46075/consoleFull)** for PR 9763 at commit

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9733#discussion_r45052370 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -120,7 +120,7 @@ private[sql] object JDBCRDD extends

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread jbonofre
Github user jbonofre commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45055081 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0;

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157363885 **[Test build #2072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2072/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157367136 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157367132 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157373552 Oh. I just got confused for a bit. Sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11771][YARN][TRIVIAL] maximum memory in...

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9758#discussion_r45045562 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -258,7 +258,8 @@ private[spark] class Client( if (executorMem > maxMem)

[GitHub] spark pull request: [SPARK-11779][DOCS] Fix reference to deprecate...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9768#issuecomment-157339909 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11779][DOCS] Fix reference to deprecate...

2015-11-17 Thread philipphoffmann
GitHub user philipphoffmann opened a pull request: https://github.com/apache/spark/pull/9768 [SPARK-11779][DOCS] Fix reference to deprecated MESOS_NATIVE_LIBRARY MESOS_NATIVE_LIBRARY was renamed in favor of MESOS_NATIVE_JAVA_LIBRARY. This commit fixes the reference in the

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157341844 Please note that https://github.com/apache/spark/pull/9754 updated unintentionally this to clean up at mater branch however, that is supposed to be merged with

[GitHub] spark pull request: [SPARK-11779][DOCS] Fix reference to deprecate...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9768#issuecomment-157341519 That's correct as of the version supported in Spark 1.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-11692][SQL] Support for Parquet logical...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9658#issuecomment-157343609 Hm, I don't quite get it... So this PR is only for master (targeting 1.7). I don't think we need to backport this one to anywhere else. --- If your project is set up

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157353135 Yes, ideally. @JoshRosen am I right that we have to add the new method to the `JavaRDDLike` trait or the abstract class that implements it in order to avoid binary

[GitHub] spark pull request: [SPARK-11773][SPARKR] Implement collection fun...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9764#issuecomment-157362335 **[Test build #46079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46079/consoleFull)** for PR 9764 at commit

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157367766 **[Test build #2074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2074/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157367868 **[Test build #2078 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2078/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157369352 [Test build #2073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2073/console) for PR 9367 at commit

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157371768 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-157371764 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157414057 @nongli I saw you have a related discussion with @chenghao-intel . The failed test case was introduced in your PR https://github.com/apache/spark/pull/9480. I am not

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418537 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418522 **[Test build #46091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46091/consoleFull)** for PR 7753 at commit

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157421084 [Test build #2079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2079/console) for PR 9367 at commit

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-17 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157420688 can someone from Spark SQL committers or experts also look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11195][CORE] Use correct classloader fo...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9367#issuecomment-157422891 [Test build #2080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2080/console) for PR 9367 at commit

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread jbonofre
Github user jbonofre commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45083392 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0;

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415429 **[Test build #46089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46089/consoleFull)** for PR 9743 at commit

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157418529 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11057] [SQL] Add correlation and covari...

2015-11-17 Thread NarineK
Github user NarineK commented on the pull request: https://github.com/apache/spark/pull/9366#issuecomment-157419321 yes, there is even a test case which covers that case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9733#issuecomment-157419417 You don't need a new PR, just push a new commit here. It's better, as it preserves the history of the discussion. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157421443 LGTM. This is on the border of needing a JIRA IMHO. https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11191] [SQL] [FOLLOW-UP] Cleans up unne...

2015-11-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9737#issuecomment-157421259 Also backported to branch-1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/9165#discussion_r45082916 --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js --- @@ -169,7 +169,7 @@ sorttable = { for (var i=0;

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157410913 **[Test build #46090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46090/consoleFull)** for PR 9770 at commit

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415572 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157415577 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-157417841 **[Test build #46091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46091/consoleFull)** for PR 7753 at commit

[GitHub] spark pull request: [SPARK-8658] [SQL] [FOLLOW-UP] AttributeRefere...

2015-11-17 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/9761#issuecomment-157421827 This change looks good to me. The failing test is not valid anymore and should be changed to verify that the hash codes are not equal. --- If your project is set up for

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157421857 **[Test build #2081 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2081/consoleFull)** for PR 9771 at commit

[GitHub] spark pull request: [SPARK-11089] [SQL] Adds option for disabling ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9740#issuecomment-157336274 **[Test build #46081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46081/consoleFull)** for PR 9740 at commit

[GitHub] spark pull request: [SPARK-11530] [MLLIB] Return eigenvalues with ...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9736#issuecomment-157336366 **[Test build #2072 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2072/consoleFull)** for PR 9736 at commit

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9697#issuecomment-157336315 LGTM @pwendell as I can't see why MiMa would need to look at private classes of any type. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11779][DOCS] Fix reference to deprecate...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9768#issuecomment-157342003 **[Test build #2076 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2076/consoleFull)** for PR 9768 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354977 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354973 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157364779 **[Test build #46083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46083/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-7012][SQL] Add support for NOT NULL mod...

2015-11-17 Thread sabhyankar
Github user sabhyankar commented on a diff in the pull request: https://github.com/apache/spark/pull/8746#discussion_r45070100 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala --- @@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398049 **[Test build #46085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46085/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397984 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398356 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157398361 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11725][SQL] correctly handle null input...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9770#issuecomment-157401188 **[Test build #46088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46088/consoleFull)** for PR 9770 at commit

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread vivkul
GitHub user vivkul opened a pull request: https://github.com/apache/spark/pull/9771 rmse was wrongly calculated It was multiplying with U instaed of dividing by U You can merge this pull request into a Git repository by running: $ git pull https://github.com/vivkul/spark

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157399730 **[Test build #46083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46083/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: rmse was wrongly calculated

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9771#issuecomment-157403077 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/9743#discussion_r45074174 --- Diff: R/pkg/inst/tests/test_sparkSQL.R --- @@ -294,9 +294,21 @@ test_that("create DataFrame with complex types", { test_that("create DataFrame from a

[GitHub] spark pull request: [SPARK-11281][SPARKR] Add tests covering the i...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9743#issuecomment-157409861 **[Test build #46089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46089/consoleFull)** for PR 9743 at commit

[GitHub] spark pull request: [SPARK-11447][SQL] change NullType to StringTy...

2015-11-17 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/9720#discussion_r45069001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -280,6 +280,12 @@ object HiveTypeCoercion {

[GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9165#issuecomment-157399487 **[Test build #2078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2078/consoleFull)** for PR 9165 at commit

[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9732#issuecomment-157397991 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157400218 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   3   4   5   6   7   8   9   10   >